-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify ephemeral storage trigger logic to use net::CookieOptions. #9095
Conversation
@@ -470,7 +470,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest, | |||
} | |||
|
|||
IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest, | |||
DISABLED_NavigationCookiesArePartitioned) { | |||
NavigationCookiesArePartitioned) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the name of this test because "navigation cookies" doesn't mean anything to me. This is presumably for network cookies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually what we really need is to check network and JS for all tests now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extended/added tests to check network and JS cookie set.
45ef6c8
to
02e9189
Compare
02e9189
to
e5225e0
Compare
This PR generalizes ephemeral storage check to allow it to be used in 1p context. Also this PR restores navigation cookie handling in ephemeral storage mode (which is required for 1p-ES).
The idea is to fill
net::CookieOptions
with ephemeral storage values everywhere it's required and then use it inCookieMonster
directly.All planned changes can be seen here: #8881. This is a first part to simplify the PR review process.
Issue: brave/brave-browser#15906
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: