Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button color in IPFS interstitial page in light theme #7619

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jan 15, 2021

Resolves brave/brave-browser#13599

Buttons in other interstitial pages are using this, this PR adds this for .ipfs button in our own css.
https://source.chromium.org/chromium/chromium/src/+/master:components/security_interstitials/core/common/resources/interstitial_common.css;l=33?q=interstitial_common&ss=chromium

With this, the page looks like below:
Screen Shot 2021-01-15 at 11 03 44 AM
Screen Shot 2021-01-15 at 11 03 34 AM

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Pre-condition: In brave://settings, Method to resolve IPFS resources is set to Local Node, IPFS public gateway fallback switch is off.

  1. Turn off wifi, open brave://ipfs to start the local node with 0 connected peers.
  2. Visit ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR to see the interstitial page.

@yrliou yrliou added this to the 1.21.x - Nightly milestone Jan 15, 2021
@yrliou yrliou requested a review from bbondy January 15, 2021 19:12
@yrliou yrliou self-assigned this Jan 15, 2021
@yrliou yrliou merged commit 218f4df into master Jan 15, 2021
@yrliou yrliou deleted the ipfs_fix_button_color_in_light branch January 15, 2021 19:56
@yrliou
Copy link
Member Author

yrliou commented Jan 15, 2021

Verified locally, didn't wait for CI to finish as it's just a trivial css change.

@kjozwiak
Copy link
Member

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.21.7 Chromium: 88.0.4324.87 (Official Build) nightly (x86_64)
--- | ---
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | macOS Version 11.1 (Build 20C69)
Light Dark
Screen Shot 2021-01-16 at 10 26 10 PM Screen Shot 2021-01-16 at 10 32 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The color of Proceed with Public Gateway button on IPFS interstitial page for Light theme is wrong
3 participants