-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ac amount react page android #7411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React app changes look good.
FIx debug error Update NTP banner behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Based on the conversation here : https://bravesoftware.slack.com/archives/C8ZJB9F9B/p1607744941053300 merging above PR. |
Issue 1: brave/brave-browser#13148
Issue 2: brave/brave-browser#13150
Issue 3: brave/brave-browser#13158
Issue 4: brave/brave-browser#13160
Issue 5: brave/brave-browser#13166
Issue 6: brave/brave-browser#13161
Clean profile scenarios
Upgrade scenario:
|
Resolves brave/brave-browser#13148 brave/brave-browser#13150 brave/brave-browser#13158 brave/brave-browser#13160 brave/brave-browser#13161 brave/brave-browser#13166
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: