-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Today: optimize fetching #7353
Conversation
54a74f1
to
4aacfd6
Compare
}).catch((e) => console.error(e)) | ||
// Refreshing of content after prefs changed is throttled, so wait | ||
// a while before seeing if we have new content yet. | ||
// This doens't have to be exact since we often check for update when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/doens't/doesn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes, works good! Code changes look good too. Async startup/shutdown when Today enabled/disabled, debounced re-fetch for publisher pref changes. Very nice 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
CI passed apart from Windows but that was "unstable" not "fail" so 👍 |
- Do not fetch any data from remote until user has interacted with brave today once - Fix double-fetching due to feed fetch also fetching sources which notifies feed there is an update which then performs feed fetch... - Debounce fetch feed update when user is toggling publishers
4aacfd6
to
d174f90
Compare
Brave Today: optimize fetching
Verification PASSED on
Followed the cases/summary motioned via both brave/brave-browser#13059 & brave/brave-browser#13058 and ran through the following cases:
|
Brave Today: optimize fetching
1.19.x - Uplift #7353 (today-optimize-fetch)
1.18.x - Uplift #7353 (today-optimize-fetch)
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: