Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 120.0.6099.56 to Chromium 120.0.6099.62. #21263

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 6, 2023

Resolves brave/brave-browser#34723

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Dec 6, 2023
@mkarolin mkarolin self-assigned this Dec 6, 2023
@mkarolin mkarolin requested review from a team as code owners December 6, 2023 01:02
@github-actions github-actions bot removed the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

[puLL-Merge] - brave/brave-core@21263

Description

This pull request updates the transport security state generator's input file parser to reflect new certificate pin sets, and updates the revision of the associated Chromium tag to a more recent version. The motivator for this change is to maintain up-to-date security standards and make sure that the certificate pinning reflects the current trusted certificate authorities.

Changes

chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc

  • Update embedded certificate pin sets with a new timestamp.

package.json

  • Update the Chromium tag from 120.0.6099.56 to 120.0.6099.62.

patches/chrome-browser-about_flags.cc.patch

  • Adjust patch offsets and context due to the changes in chrome/browser/about_flags.cc between the two Chromium revisions.

patches/extensions-browser-api-socket-tcp_socket.cc.patch

  • Adjust patch offsets and context due to changes in extensions/browser/api/socket/tcp_socket.cc between the two Chromium revisions.

Security Hotspots

  • chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc

    • Ensure that the updated certificate pin sets are from a trusted source and that the pin sets correspond correctly to the intended certificate authorities. Validation of this change is crucial as incorrect pinning can lead to security vulnerabilities or prevent valid connections from being established.
  • Update to package.json and Chromium revision tag

    • Verify that the new Chromium tag resolves any known security issues present in the previous version. It is important to ensure no new vulnerabilities are introduced with this update.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjozwiak kjozwiak merged commit 21c9d56 into master Dec 6, 2023
@kjozwiak kjozwiak deleted the 120.0.6099.62_master branch December 6, 2023 05:38
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 120.0.6099.56 to Chromium 120.0.6099.62.
3 participants