From bf8da48d2f162073b4b1056f766f4751395cef2b Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Wed, 27 Feb 2019 18:59:37 -0300 Subject: [PATCH 01/16] move shields out of subfolder --- .../extension/brave_extension/BUILD.gn | 16 ++++++++-------- .../blockedResources/blockedResources.tsx | 0 .../blockedResources/scriptsList.tsx | 0 .../blockedResources/staticList.tsx | 0 .../{braveShields => }/braveShields.tsx | 0 .../components/{braveShields => }/footer.tsx | 0 .../components/{braveShields => }/header.tsx | 0 .../{braveShields => }/interfaceControls.tsx | 0 .../{braveShields => }/privacyControls.tsx | 0 9 files changed, 8 insertions(+), 8 deletions(-) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/blockedResources/blockedResources.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/blockedResources/scriptsList.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/blockedResources/staticList.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/braveShields.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/footer.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/header.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/interfaceControls.tsx (100%) rename components/brave_extension/extension/brave_extension/components/{braveShields => }/privacyControls.tsx (100%) diff --git a/components/brave_extension/extension/brave_extension/BUILD.gn b/components/brave_extension/extension/brave_extension/BUILD.gn index 571f11ec73cd..5afef7c5f970 100644 --- a/components/brave_extension/extension/brave_extension/BUILD.gn +++ b/components/brave_extension/extension/brave_extension/BUILD.gn @@ -40,14 +40,14 @@ transpile_web_ui("brave_extension") { "background/reducers/shieldsPanelReducer.ts", "background/store.ts", "braveShieldsPanel.tsx", - "components/braveShields/braveShields.tsx", - "components/braveShields/footer.tsx", - "components/braveShields/header.tsx", - "components/braveShields/interfaceControls.tsx", - "components/braveShields/privacyControls.tsx", - "components/braveShields/blockedResources/blockedResources.tsx", - "components/braveShields/blockedResources/scriptsList.tsx", - "components/braveShields/blockedResources/staticList.tsx", + "components/braveShields.tsx", + "components/footer.tsx", + "components/header.tsx", + "components/interfaceControls.tsx", + "components/privacyControls.tsx", + "components/blockedResources/blockedResources.tsx", + "components/blockedResources/scriptsList.tsx", + "components/blockedResources/staticList.tsx", "constants/cosmeticFilterTypes.ts", "constants/resourceIdentifiers.ts", "constants/runtimeActionTypes.ts", diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/blockedResources.tsx b/components/brave_extension/extension/brave_extension/components/blockedResources/blockedResources.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/blockedResources.tsx rename to components/brave_extension/extension/brave_extension/components/blockedResources/blockedResources.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/scriptsList.tsx b/components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/scriptsList.tsx rename to components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/staticList.tsx b/components/brave_extension/extension/brave_extension/components/blockedResources/staticList.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/blockedResources/staticList.tsx rename to components/brave_extension/extension/brave_extension/components/blockedResources/staticList.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/braveShields.tsx b/components/brave_extension/extension/brave_extension/components/braveShields.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/braveShields.tsx rename to components/brave_extension/extension/brave_extension/components/braveShields.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/footer.tsx b/components/brave_extension/extension/brave_extension/components/footer.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/footer.tsx rename to components/brave_extension/extension/brave_extension/components/footer.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/header.tsx b/components/brave_extension/extension/brave_extension/components/header.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/header.tsx rename to components/brave_extension/extension/brave_extension/components/header.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/interfaceControls.tsx b/components/brave_extension/extension/brave_extension/components/interfaceControls.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/interfaceControls.tsx rename to components/brave_extension/extension/brave_extension/components/interfaceControls.tsx diff --git a/components/brave_extension/extension/brave_extension/components/braveShields/privacyControls.tsx b/components/brave_extension/extension/brave_extension/components/privacyControls.tsx similarity index 100% rename from components/brave_extension/extension/brave_extension/components/braveShields/privacyControls.tsx rename to components/brave_extension/extension/brave_extension/components/privacyControls.tsx From 0f97d2b91aeed8d9948faeb0f8e1385568ebd28f Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Wed, 27 Feb 2019 19:43:57 -0300 Subject: [PATCH 02/16] replace getMessage method name with getLocale for parity with brave-core --- .../background/api/localeAPI.ts | 2 +- .../blockedResources/scriptsList.tsx | 26 +++++++++---------- .../blockedResources/staticList.tsx | 4 +-- .../brave_extension/components/footer.tsx | 4 +-- .../brave_extension/components/header.tsx | 12 ++++----- .../components/interfaceControls.tsx | 10 +++---- .../components/privacyControls.tsx | 22 ++++++++-------- 7 files changed, 40 insertions(+), 40 deletions(-) diff --git a/components/brave_extension/extension/brave_extension/background/api/localeAPI.ts b/components/brave_extension/extension/brave_extension/background/api/localeAPI.ts index 6f68f70a50ea..5d2cea906087 100644 --- a/components/brave_extension/extension/brave_extension/background/api/localeAPI.ts +++ b/components/brave_extension/extension/brave_extension/background/api/localeAPI.ts @@ -6,7 +6,7 @@ * Gets the locale message specified in messages.json * @param {string} message - The locale string */ -export const getMessage = (message: string): string => { +export const getLocale = (message: string): string => { if (chrome.i18n) { return chrome.i18n.getMessage(message) } diff --git a/components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx b/components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx index 35a523743676..cfdccbeda370 100644 --- a/components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx +++ b/components/brave_extension/extension/brave_extension/components/blockedResources/scriptsList.tsx @@ -31,7 +31,7 @@ import { BlockJSOptions } from '../../../types/other/blockTypes' import { NoScriptInfo } from '../../../types/other/noScriptInfo' // Utils -import { getMessage } from '../../../background/api/localeAPI' +import { getLocale } from '../../../background/api/localeAPI' interface Props { origin: string @@ -103,13 +103,13 @@ export default class StaticList extends React.PureComponent { { list[origin].willBlock - ? {getMessage('blocked')} - : {getMessage('allow')} + ? {getLocale('blocked')} + : {getLocale('allow')} } {origin} { list[origin].willBlock - ? {getMessage('undo')} + ? {getLocale('undo')} : null } @@ -126,13 +126,13 @@ export default class StaticList extends React.PureComponent { { list[origin].willBlock - ? {getMessage('allowed')} - : {getMessage('block')} + ? {getLocale('allowed')} + : {getLocale('block')} } {origin} { list[origin].willBlock - ? {getMessage('undo')} + ? {getLocale('undo')} : null } @@ -151,9 +151,9 @@ export default class StaticList extends React.PureComponent { - {getMessage('blockedScripts')} ({this.blockedListSize}) + {getLocale('blockedScripts')} ({this.blockedListSize}) - {getMessage('allowAll')} + {getLocale('allowAll')} {this.renderEnabledList(noScriptInfo)} @@ -161,22 +161,22 @@ export default class StaticList extends React.PureComponent { - {getMessage('allowedScripts')} ({this.allowedListSize}) + {getLocale('allowedScripts')} ({this.allowedListSize}) - {getMessage('blockAll')} + {getLocale('blockAll')} {this.renderDisabledList(noScriptInfo)} - {getMessage('cancel')} + {getLocale('cancel')}