-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BraveShieldsDisabledForUrls and BraveShieldsEnabledForUrls policies #15409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9aafa67
to
1f1a3d7
Compare
32aaabd
to
13b65a6
Compare
5bf00d0
to
ba24e0f
Compare
1f1a3d7
to
c68dd34
Compare
7f46ec4
to
b83cc84
Compare
c68dd34
to
5832fe3
Compare
8cef90b
to
4181cd5
Compare
bridiver
reviewed
Nov 2, 2022
patches/components-content_settings-core-browser-content_settings_policy_provider.cc.patch
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Nov 2, 2022
bridiver
reviewed
Nov 2, 2022
A Storybook has been deployed to preview UI for the latest push |
bsclifton
approved these changes
Nov 4, 2022
bridiver
reviewed
Nov 4, 2022
components/brave_shields/browser/brave_shields_util_unittest.cc
Outdated
Show resolved
Hide resolved
f423cee
to
6b4b3f2
Compare
A Storybook has been deployed to preview UI for the latest push |
6b4b3f2
to
1ac6b36
Compare
A Storybook has been deployed to preview UI for the latest push |
1ac6b36
to
83fb7d2
Compare
A Storybook has been deployed to preview UI for the latest push |
bridiver
approved these changes
Nov 7, 2022
83fb7d2
to
ff14a05
Compare
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#25394
BraveShieldsDisabledForUrls
to disable shields urlsBraveShieldsEnabledForUrls
to enable shields urlsUrls set by policies are protected from editing via popup or other ways
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Computer\HKEY_CURRENT_USER\SOFTWARE\Policies\BraveSoftware\Brave
and check that settings set by policy cannot be changed by user and work as expected