From fb1e34c50603d2de96c0730360ad0375ad4b7359 Mon Sep 17 00:00:00 2001 From: mkarolin Date: Fri, 11 Dec 2020 21:48:37 -0500 Subject: [PATCH] Fixes Welcome to Brave page title l10n. Fixes brave/brave-browser#13118 --- browser/ui/BUILD.gn | 1 + browser/ui/webui/brave_webui_source.cc | 4 ++++ components/brave_welcome_ui/brave_welcome.html | 7 ++++++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/browser/ui/BUILD.gn b/browser/ui/BUILD.gn index a58b231b15b6..8b6338ed6eb2 100644 --- a/browser/ui/BUILD.gn +++ b/browser/ui/BUILD.gn @@ -289,6 +289,7 @@ source_set("ui") { "//brave/components/brave_sync:profile_sync_service_helper", "//brave/components/brave_new_tab_ui:generated_resources", "//brave/components/brave_welcome_ui:generated_resources", + "//chrome/app:chromium_strings", "//components/sync_device_info", "//third_party/blink/public/common", ] diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc index 16cbd46e7871..e2894026effd 100644 --- a/browser/ui/webui/brave_webui_source.cc +++ b/browser/ui/webui/brave_webui_source.cc @@ -21,6 +21,7 @@ #if !defined(OS_ANDROID) #include "brave/browser/ui/webui/navigation_bar_data_provider.h" #include "brave/components/brave_rewards/resources/grit/brave_rewards_resources.h" +#include "chrome/grit/chromium_strings.h" #endif namespace { @@ -358,6 +359,9 @@ void CustomizeWebUIHTMLSource(const std::string &name, } }, { std::string("welcome"), { +#if !defined(OS_ANDROID) + { "headerText", IDS_WELCOME_HEADER }, +#endif { "welcome", IDS_BRAVE_WELCOME_PAGE_MAIN_TITLE }, { "whatIsBrave", IDS_BRAVE_WELCOME_PAGE_MAIN_DESC }, { "letsGo", IDS_BRAVE_WELCOME_PAGE_MAIN_BUTTON }, diff --git a/components/brave_welcome_ui/brave_welcome.html b/components/brave_welcome_ui/brave_welcome.html index 3ab2c50b7ff6..becf9edca212 100644 --- a/components/brave_welcome_ui/brave_welcome.html +++ b/components/brave_welcome_ui/brave_welcome.html @@ -3,7 +3,12 @@ -Welcome to Brave + + $i18n{headerText} + + + Welcome to Brave +