Fixes Welcome to Brave page title l10n.

Fixes brave/brave-browser#13118
brave · Dec 12, 2020 · fb1e34c · fb1e34c
1 parent d48424e
commit fb1e34c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/browser/ui/BUILD.gn b/browser/ui/BUILD.gn
@@ -289,6 +289,7 @@ source_set("ui") {
       "//brave/components/brave_sync:profile_sync_service_helper",
       "//brave/components/brave_new_tab_ui:generated_resources",
       "//brave/components/brave_welcome_ui:generated_resources",
+      "//chrome/app:chromium_strings",
       "//components/sync_device_info",
       "//third_party/blink/public/common",
     ]

diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc
@@ -21,6 +21,7 @@
 #if !defined(OS_ANDROID)
 #include "brave/browser/ui/webui/navigation_bar_data_provider.h"
 #include "brave/components/brave_rewards/resources/grit/brave_rewards_resources.h"
+#include "chrome/grit/chromium_strings.h"
 #endif
 
 namespace {
@@ -358,6 +359,9 @@ void CustomizeWebUIHTMLSource(const std::string &name,
       }
     }, {
       std::string("welcome"), {
+#if !defined(OS_ANDROID)
+        { "headerText", IDS_WELCOME_HEADER },
+#endif
         { "welcome", IDS_BRAVE_WELCOME_PAGE_MAIN_TITLE },
         { "whatIsBrave", IDS_BRAVE_WELCOME_PAGE_MAIN_DESC },
         { "letsGo", IDS_BRAVE_WELCOME_PAGE_MAIN_BUTTON },

diff --git a/components/brave_welcome_ui/brave_welcome.html b/components/brave_welcome_ui/brave_welcome.html
@@ -3,7 +3,12 @@
 <head>
 <meta charset="utf-8">
 <meta name="viewport" content="width=device-width">
-<title>Welcome to Brave</title>
+<if expr="not is_android">
+  <title>$i18n{headerText}</title>
+</if>
+<if expr="is_android">
+  <title>Welcome to Brave</title>
+</if>
 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
 <link rel="shortcut icon" href="favicon.ico" type="image/x-icon">
 <script src="chrome://resources/js/promise_resolver.js"></script>