From ec9e5088b8e286d4860a12b7147083da6b31d653 Mon Sep 17 00:00:00 2001 From: Brandon T Date: Mon, 24 Feb 2025 21:38:29 -0500 Subject: [PATCH] Add guards against displaying the translation overlay when other popups are displayed. --- .../Browser/BrowserViewController/BVC+Translate.swift | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Translate.swift b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Translate.swift index bbf81afcf19c..cbc53490fa73 100644 --- a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Translate.swift +++ b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Translate.swift @@ -28,6 +28,7 @@ extension BrowserViewController: BraveTranslateScriptHandlerDelegate { } return Preferences.Translate.translateEnabled.value == nil + && !topToolbar.inOverlayMode && topToolbar.secureContentState == .secure && Preferences.Translate.translateURLBarOnboardingCount.value < 2 && shouldShowTranslationOnboardingThisSession && presentedViewController == nil @@ -100,6 +101,11 @@ extension BrowserViewController: BraveTranslateScriptHandlerDelegate { } func presentToast(tab: Tab?, languageInfo: BraveTranslateLanguageInfo) { + if presentedViewController != nil || topToolbar.inOverlayMode || tab !== tabManager.selectedTab + { + return + } + let popover = PopoverController( content: TranslateToast(languageInfo: languageInfo) { [weak tab] _ in tab?.translateHelper?.startTranslation(canShowToast: false)