diff --git a/android/browsertests_apk/AndroidManifest.xml.jinja2 b/android/browsertests_apk/AndroidManifest.xml.jinja2
index 34849a60c4a0..ad7511b7b6e7 100644
--- a/android/browsertests_apk/AndroidManifest.xml.jinja2
+++ b/android/browsertests_apk/AndroidManifest.xml.jinja2
@@ -86,23 +86,6 @@
-
-
-
-
-
-
-
-
diff --git a/android/java/apk_for_test.flags b/android/java/apk_for_test.flags
index cf1076fdcd77..a8ccc5460371 100644
--- a/android/java/apk_for_test.flags
+++ b/android/java/apk_for_test.flags
@@ -448,10 +448,6 @@
public (...);
}
--keep class org.chromium.chrome.browser.omnibox.suggestions.AutocompleteCoordinator {
- *** createViewProvider(...);
-}
-
-keep class org.chromium.chrome.browser.omnibox.suggestions.BraveAutocompleteCoordinator {
*** createViewProvider(...);
}
@@ -470,8 +466,6 @@
*** mDropdownHeight;
*** mPriorityOrderedSuggestionProcessors;
public (...);
- *** getVisibleSuggestionsCount(...);
- *** getProcessorForSuggestion(...);
}
-keep class org.chromium.chrome.browser.omnibox.suggestions.BraveDropdownItemViewInfoListBuilder {
diff --git a/android/java/org/chromium/chrome/browser/externalnav/BraveExternalNavigationHandler.java b/android/java/org/chromium/chrome/browser/externalnav/BraveExternalNavigationHandler.java
index 9cbfc4f1f652..ca8c4be86865 100644
--- a/android/java/org/chromium/chrome/browser/externalnav/BraveExternalNavigationHandler.java
+++ b/android/java/org/chromium/chrome/browser/externalnav/BraveExternalNavigationHandler.java
@@ -65,6 +65,7 @@ public OverrideUrlLoadingResult clobberCurrentTabWithFallbackUrl(
params.getRedirectHandler().setShouldNotOverrideUrlLoadingOnCurrentRedirectChain();
}
GURL browserFallbackGURL = new GURL(browserFallbackUrl);
- return clobberCurrentTab(browserFallbackGURL, params.getReferrerUrl());
+ return clobberCurrentTab(browserFallbackGURL, params.getReferrerUrl(),
+ params.getInitiatorOrigin(), params.isRendererInitiated());
}
}
diff --git a/android/java/org/chromium/chrome/browser/settings/BraveSettingsActivity.java b/android/java/org/chromium/chrome/browser/settings/BraveSettingsActivity.java
index 88c71ac9e377..68035a6ddd01 100644
--- a/android/java/org/chromium/chrome/browser/settings/BraveSettingsActivity.java
+++ b/android/java/org/chromium/chrome/browser/settings/BraveSettingsActivity.java
@@ -38,4 +38,10 @@ public boolean onOptionsItemSelected(MenuItem item) {
}
return super.onOptionsItemSelected(item);
}
+
+ @Override
+ protected boolean supportsDynamicColors() {
+ // Dynamic colors cause styling issues with Brave theme.
+ return false;
+ }
}
diff --git a/android/java/org/chromium/chrome/browser/site_settings/BraveSiteSettingsDelegate.java b/android/java/org/chromium/chrome/browser/site_settings/BraveSiteSettingsDelegate.java
index 49dbdf155343..4579658db302 100644
--- a/android/java/org/chromium/chrome/browser/site_settings/BraveSiteSettingsDelegate.java
+++ b/android/java/org/chromium/chrome/browser/site_settings/BraveSiteSettingsDelegate.java
@@ -7,7 +7,7 @@
import android.content.Context;
import android.content.Intent;
-import android.graphics.Bitmap;
+import android.graphics.drawable.Drawable;
import org.chromium.base.Callback;
import org.chromium.chrome.browser.ChromeTabbedActivity;
@@ -22,19 +22,12 @@ public BraveSiteSettingsDelegate(Context context, Profile profile) {
}
@Override
- public void closeButton() {
- Intent intent =
- new Intent(BraveActivity.getChromeTabbedActivity(), ChromeTabbedActivity.class);
- intent.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
- BraveActivity.getChromeTabbedActivity().startActivity(intent);
- }
-
- @Override
- public void getFaviconImageForURL(GURL faviconUrl, Callback callback) {
+ public void getFaviconImageForURL(GURL faviconUrl, Callback callback) {
if (!faviconUrl.isValid()) {
callback.onResult(null);
return;
}
+
super.getFaviconImageForURL(faviconUrl, callback);
}
}
diff --git a/android/java/org/chromium/chrome/browser/toolbar/top/BraveTopToolbarCoordinator.java b/android/java/org/chromium/chrome/browser/toolbar/top/BraveTopToolbarCoordinator.java
index b57840fe1d52..4c8636545812 100644
--- a/android/java/org/chromium/chrome/browser/toolbar/top/BraveTopToolbarCoordinator.java
+++ b/android/java/org/chromium/chrome/browser/toolbar/top/BraveTopToolbarCoordinator.java
@@ -55,8 +55,6 @@ public BraveTopToolbarCoordinator(ToolbarControlContainer controlContainer,
ObservableSupplier appMenuButtonHelperSupplier,
ObservableSupplier tabModelSelectorSupplier,
ObservableSupplier homepageEnabledSupplier,
- ObservableSupplier startSurfaceAsHomepageSupplier,
- ObservableSupplier homepageManagedByPolicySupplier,
ObservableSupplier identityDiscStateSupplier,
Callback invalidatorCallback, Supplier identityDiscButtonSupplier,
Supplier resourceManagerSupplier,
@@ -73,7 +71,6 @@ public BraveTopToolbarCoordinator(ToolbarControlContainer controlContainer,
layoutStateProviderSupplier, normalThemeColorProvider, overviewThemeColorProvider,
browsingModeMenuButtonCoordinator, overviewModeMenuButtonCoordinator,
appMenuButtonHelperSupplier, tabModelSelectorSupplier, homepageEnabledSupplier,
- startSurfaceAsHomepageSupplier, homepageManagedByPolicySupplier,
identityDiscStateSupplier, invalidatorCallback, identityDiscButtonSupplier,
resourceManagerSupplier, isProgressBarVisibleSupplier,
isIncognitoModeEnabledSupplier, isGridTabSwitcherEnabled, isTabletGtsPolishEnabled,
diff --git a/android/java/res/layout/new_tab_page_layout.xml b/android/java/res/layout/new_tab_page_layout.xml
index 6f5378629f19..1181b0b1cc73 100644
--- a/android/java/res/layout/new_tab_page_layout.xml
+++ b/android/java/res/layout/new_tab_page_layout.xml
@@ -115,6 +115,13 @@
android:layout_marginTop="16dp"
android:visibility="gone"/>
+
+
New folder
+
+ Unnamed folder
+
Bookmark all tabs
@@ -298,6 +301,9 @@
New Folder
+
+ Unnamed Folder
+
Bookmark All Tabs
diff --git a/app/brave_main_delegate_browsertest.cc b/app/brave_main_delegate_browsertest.cc
index 7e436d13c957..c7b335788da1 100644
--- a/app/brave_main_delegate_browsertest.cc
+++ b/app/brave_main_delegate_browsertest.cc
@@ -7,6 +7,7 @@
#include "build/build_config.h"
#include "chrome/browser/domain_reliability/service_factory.h"
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_features.h"
+#include "chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_features.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/chrome_test_utils.h"
@@ -82,12 +83,14 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
const base::Feature* disabled_features[] = {
&autofill::features::kAutofillEnableAccountWalletStorage,
&autofill::features::kAutofillEnableOfferNotificationForPromoCodes,
+ &autofill::features::kAutofillEnableRemadeDownstreamMetrics,
&autofill::features::kAutofillSaveCardUiExperiment,
&autofill::features::kAutofillServerCommunication,
&autofill::features::kAutofillUpstreamAllowAdditionalEmailDomains,
&blink::features::kAdInterestGroupAPI,
- &blink::features::kBrowsingTopics,
&blink::features::kAllowURNsInIframes,
+ &blink::features::kBrowsingTopics,
+ &blink::features::kClientHintsMetaEquivDelegateCH,
&blink::features::kComputePressure,
&blink::features::kConversionMeasurement,
&blink::features::kCssSelectorFragmentAnchor,
@@ -107,6 +110,9 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&commerce::kShoppingPDPMetrics,
&commerce::kRetailCoupons,
&enterprise_connectors::kLocalContentAnalysisEnabled,
+#if BUILDFLAG(IS_WIN)
+ &features::kAppBoundEncryptionMetrics,
+#endif
#if !BUILDFLAG(IS_ANDROID)
&features::kCopyLinkToText,
#endif
@@ -115,10 +121,10 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&features::kFedCm,
&features::kFirstPartySets,
&features::kIdleDetection,
+ &features::kIsolatePrerenders,
&features::kNavigationRequestPreconnect,
&features::kNotificationTriggers,
&features::kOmniboxTriggerForNoStatePrefetch,
- &features::kPrivacyGuide,
&features::kPrivacyGuide2,
&features::kPrivacySandboxAdsAPIsOverride,
&features::kSCTAuditing,
diff --git a/app/brave_strings.grd b/app/brave_strings.grd
index 833b3b5b62fd..47059a884565 100644
--- a/app/brave_strings.grd
+++ b/app/brave_strings.grd
@@ -636,15 +636,9 @@ Permissions you've already given to websites and apps may apply to this account.
Extensions, apps, and themes from unknown sources can harm your device. Brave recommends only installing them from the $1Web Store
-
- Brave blocked this file because it's encrypted. Ask its owner to decrypt it
-
Brave blocked this file because it has malware
-
- Brave blocked this file because it's too big for a security check. Try again with files up to 50 MB
-
Brave recommends scanning this file because it may be dangerous
@@ -1425,8 +1419,8 @@ Permissions you've already given to websites and apps may apply to this account.
Brave is exploring new features that allow sites to deliver the same browsing experience using less of your info
-
- During the trials, you can see and remove topics of interest sites use to show you ads. Brave estimates your interests based on your recent browsing history.
+
+ You can see and remove topics of interest sites use to show you ads. Brave estimates your interests based on your recent browsing history.
Learn more about ad personalization in Brave
diff --git a/app/chromeos_shared_strings.grdp b/app/chromeos_shared_strings.grdp
index 01ad56ce294a..0631be6591f3 100644
--- a/app/chromeos_shared_strings.grdp
+++ b/app/chromeos_shared_strings.grdp
@@ -24,4 +24,27 @@
PUK
+
+
+ Permission requested
+
+
+ $1Super Kiosk app wants to copy files from $2FooBar 4GB.
+
+
+ $1Super Kiosk app wants to access $2FooBar 4GB. It may modify or delete your files.
+
+
+ Allow
+
+
+ Deny
+
+
+ Read-only access to $1FooBar 4GB has been granted.
+
+
+ Read and write access to $1FooBar 4GB has been granted.
+
+
diff --git a/app/generated_resources.grd b/app/generated_resources.grd
index 2c3fa891e4df..aa39c97c669b 100644
--- a/app/generated_resources.grd
+++ b/app/generated_resources.grd
@@ -463,14 +463,14 @@ are declared in tools/grit/grit_rule.gni.
Tabs from other devices
-
- Sign in to Brave
+
+ Turn on sync
-
+
Continue from another device
-
- To get your tabs from your other devices, sign in to Brave.
+
+ To get your tabs from your other devices, turn on sync
@@ -573,6 +573,9 @@ are declared in tools/grit/grit_rule.gni.
Open in Reader
+
+ Recognize P&DF text
+
&Reload
@@ -639,6 +642,10 @@ are declared in tools/grit/grit_rule.gni.
Copy link to highlight
+
+ Add a note
+
+
Remove highlight
@@ -759,6 +766,9 @@ are declared in tools/grit/grit_rule.gni.
Select &all
+
+ &Translate to $1English
+
&Search $1Brave for “$2flowers”
@@ -774,6 +784,9 @@ are declared in tools/grit/grit_rule.gni.
Search any part of the page with $1Google Lens
+
+ Search inside image with $1Google Lens
+
Search images with $1Google Lens
@@ -818,6 +831,9 @@ are declared in tools/grit/grit_rule.gni.
Open in Reader
+
+ Recognize P&DF text
+
&Reload
@@ -884,6 +900,10 @@ are declared in tools/grit/grit_rule.gni.
Copy Link to Highlight
+
+ Add a Note
+
+
Remove Highlight
@@ -1016,6 +1036,9 @@ are declared in tools/grit/grit_rule.gni.
Select &All
+
+ &Translate to $1English
+
&Search $1Brave for “$2flowers”
@@ -1031,6 +1054,9 @@ are declared in tools/grit/grit_rule.gni.
Search Any Part of the Page with $1Google Lens
+
+ Search inside Image with $1Google Lens
+
Search Images with $1Google Lens
@@ -2313,11 +2339,11 @@ are declared in tools/grit/grit_rule.gni.
Show all downloads
-
- ''' • '''
+
+ $1100/120 MB • $2Opening in 10 seconds...
-
- '''↓ '''
+
+ ↓ $1100/120 MB
Resuming...
@@ -2355,6 +2381,12 @@ are declared in tools/grit/grit_rule.gni.
Open Now
+
+ Review
+
+
+ Try again
+
Out of storage space
@@ -2385,9 +2417,6 @@ are declared in tools/grit/grit_rule.gni.
Your organization blocked this file because it didn't meet a security policy
-
- Your organization blocked this file because it has sensitive content
-
Something went wrong
@@ -2439,9 +2468,18 @@ are declared in tools/grit/grit_rule.gni.
Sensitive content
-
+
Your organization recommends deleting this file because it has sensitive content
+
+ Your organization blocked this file because it has sensitive or dangerous content. Ask its owner to fix.
+
+
+ Your organization blocked this file because it is encrypted. Ask its owner to decrypt.
+
+
+ Your organization blocked this file because it is too big for a security check. You can open files up to 50 MB.
+
Try again
@@ -2454,6 +2492,38 @@ are declared in tools/grit/grit_rule.gni.
Checking with your organization's security policies...
+
+ Anyone using this device can see downloaded files
+
+
+ Resume
+
+
+ Pause
+
+
+ Cancel
+
+
+ Open
+
+
+
+ Show in Finder
+
+
+
+
+
+ Show in folder
+
+
+
+
+ Show in Folder
+
+
+
@@ -2743,7 +2813,7 @@ are declared in tools/grit/grit_rule.gni.
Device Credentials
@@ -2756,6 +2826,12 @@ are declared in tools/grit/grit_rule.gni.
Bluetooth device $1 would like permission to pair.
+
+ Confirm passkey
+
+
+ Please confirm that $1123456 is the passkey displayed on Bluetooth device $2.
+
@@ -2943,6 +3019,9 @@ are declared in tools/grit/grit_rule.gni.
This site may be trying to trick you into allowing intrusive notifications
+
+ Notifications from this site may be disruptive
+
Notifications were automatically blocked because you usually don't allow them
@@ -3117,7 +3196,7 @@ are declared in tools/grit/grit_rule.gni.
Certificate Signature Value
- E&xport...
+ E&xport selected certificate...
@@ -3497,6 +3576,9 @@ are declared in tools/grit/grit_rule.gni.
Not Critical
+
+ Error: Unable to decode certificate
+
Error: Unable to decode extension
@@ -3951,17 +4033,14 @@ are declared in tools/grit/grit_rule.gni.
Reload
-
- Refresh the page to use "$1Gmail Checker"
-
-
- Refresh
+
+ Reload the page to use "$1Gmail Checker"
-
- Always allow the extension to run on this site if you don't want to see this message again.
+
+ Reload the page to use these extensions
-
- Always allow on this site
+
+ Reload the page to apply your changes
@@ -4454,9 +4533,22 @@ are declared in tools/grit/grit_rule.gni.
Perform security-related tasks for your organization, such as managing certificates and keys stored on the device
+
+
+ Read information about your browser, OS, device, installed software, registry values and files
+
+
+
+
+ Read information about your browser, OS, device, installed software and files
+
+
Read information about your browser, OS, and device
+
+ Add remote apps to the ChromeOS launcher
+
Run ChromeOS Flex diagnostic tests.
@@ -5392,8 +5484,8 @@ Keep your key file in a safe place. You will need it to create new versions of y
Component updated
-
- Component not updated
+
+ Component already up to date
Update error
@@ -6304,6 +6396,12 @@ Keep your key file in a safe place. You will need it to create new versions of y
<br>
You can manage settings from the card menu or see more options in Customize Brave.
+
+ You’re seeing recipes based on your recent Search activity for recipes.
+ <br>
+ <br>
+ You can manage settings from the card menu or see more options in Customize Brave.
+
Recipe ideas
@@ -6550,6 +6648,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
You won't see cards on this page again
+
+ Following
+
@@ -6665,12 +6766,27 @@ Keep your key file in a safe place. You will need it to create new versions of y
Side Panel
+
+ Google Lens
+
Read anything
+
+ Text formatting
+
+
+ Font
+
+
+ Decrease font-size
+
+
+ Increase font-size
+
@@ -6794,7 +6910,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
Open with
- Remember my choice
+ Remember this choice
Open
@@ -6808,9 +6924,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
Open in app
-
- Open websites in apps installed on your device
-
@@ -6823,11 +6936,17 @@ Keep your key file in a safe place. You will need it to create new versions of y
Select an app on your $1Chromebook to open this link
+
+ Open websites in apps installed on your $1Chromebook
+
Select an app on your device to open this link
+
+ Open websites in apps installed on your device
+
@@ -6848,6 +6967,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
Full screen
+
+ Exit full screen
+
Home
@@ -6932,6 +7054,12 @@ Keep your key file in a safe place. You will need it to create new versions of y
Site Access Option
+
+ Scroll backward
+
+
+ Scroll forward
+
@@ -7290,9 +7418,6 @@ Check your passwords anytime in $1Brave P
Move your password
-
- Import
-
Import Passwords To Brave
@@ -8078,6 +8203,12 @@ Check your passwords anytime in $1Brave P
Toggle Recently Closed Items
+
+ Expand recently closed
+
+
+ Collapse recently closed
+
@@ -8542,8 +8673,11 @@ Check your passwords anytime in $1Brave P
$1Your devices$2 · $3foo@gmail.com
-
- You can send tabs between devices that are signed in with the same Brave sync chain
+
+ To send this tab to another device, sign in to Brave on both devices
+
+
+ To send this tab to another device, sign in to Brave there
@@ -9267,9 +9401,6 @@ Check your passwords anytime in $1Brave P
Turn on Brave browser sync?
-
- Brave browser sync is on
-
Your bookmarks, passwords, history, and more are synced on all your devices
@@ -9326,6 +9457,12 @@ Check your passwords anytime in $1Brave P
Separate your browsing?
+
+ This new profile will be managed by your organization. <a href="$1" target="_blank">https://help.google.com/articleLinkLearn more</a>
+
+
+ This new profile will be managed by $1example.com. <a href="$2" target="_blank">https://help.google.com/articleLinkLearn more</a>
+
@@ -9848,6 +9985,9 @@ Please help our engineers fix this problem. Tell us what happened right before y
Page language to translate
+
+ Translate full page
+
@@ -9904,6 +10044,9 @@ Please help our engineers fix this problem. Tell us what happened right before y
Page Language to Translate
+
+ Translate Full Page
+
Reset
@@ -9979,6 +10122,9 @@ Please help our engineers fix this problem. Tell us what happened right before y
This site may be trying to trick you into allowing intrusive notifications.
+
+ Notifications from this site may be disruptive
+
@@ -11596,18 +11742,22 @@ Please help our engineers fix this problem. Tell us what happened right before y
-
-
-
- Redirect blocked:
-
-
- Redirect blocked
-
-
- Redirect blocked on this page.
-
-
+
+
+ Redirect blocked:
+
+
+ Redirect blocked
+
+
+ Redirect blocked on this page.
+
+
+ Always allow
+
+
+ Open Anyway
+
@@ -11931,6 +12081,13 @@ Please help our engineers fix this problem. Tell us what happened right before y
Try again
+
+
+
+ Brave needs permission to use Bluetooth to connect to your device
+
+
+
Choose another option
@@ -12382,6 +12539,27 @@ Please help our engineers fix this problem. Tell us what happened right before y
Open now
+
+
+ Enhanced Safe Browsing is on
+
+
+ Enhanced Safe Browsing is off
+
+
+
+ You have Brave's strongest security against dangerous websites, downloads and extensions
+
+
+ You're getting standard security protection. To get more protection against dangerous websites, downloads, and extensions, turn on Enhanced Safe Browsing in Brave settings.
+
+
+ Got it
+
+
+ Brave settings
+
+
Also turn on Enhanced Safe Browsing for this Brave profile?
@@ -12780,6 +12958,18 @@ Please help our engineers fix this problem. Tell us what happened right before y
Close menu
+
+ Click on any key with your mouse, then press a keyboard key to customize
+
+
+ Key is missing. Press a keyboard key to customize
+
+
+ The following keys aren’t supported: Tab, Shift, Control, Escape, Caps lock, Volume
+
+
+ Press a keyboard key to customize
+
@@ -12792,8 +12982,8 @@ Please help our engineers fix this problem. Tell us what happened right before y
Limited sharing between sites
-
- Brave is exploring ways to limit ad spam, fraud, and sharing between sites. Brave also $1estimates your interests that sites can use to show you ads. You can manage your interests in settings.
+
+ Brave is finding new ways to reduce tracking and keep you even safer as you browse. Brave also $1estimates your interests and enables you to manage them. Then, sites you visit can ask Brave for your interests to show you ads.
Go to settings
@@ -12804,8 +12994,8 @@ Please help our engineers fix this problem. Tell us what happened right before y
estimates your interests - Brave can estimate your interests
-
- We’re exploring ways to restrict cross-site tracking while enabling sites to stop ad spam and fraud.
+
+ We’re exploring ways to restrict tracking while enabling sites to stop ad spam and fraud.
More control over the ads you see
@@ -12840,24 +13030,27 @@ Please help our engineers fix this problem. Tell us what happened right before y
-
+
Let Brave Assistant help you change your password
-
+
Brave Assistant in Brave can complete actions across websites for you
-
- To help you complete tasks, Brave will receive the URLs and contents of sites on which you use Assistant, as well as information you submit through Assistant. This information may be stored in your Brave sync chain. You can turn it off in Brave settings. $1Learn more
+
+ To help you complete tasks, Brave will receive the URLs and contents of sites on which you use Assistant, as well as information you submit through Assistant. This information may be stored in your Brave sync chain. You can turn off Assistant in Brave settings. $1Learn more
-
+
Learn more
-
+
Cancel
-
+
I agree
+
+ Opening $1example.com...
+
diff --git a/app/generated_resources_override.grd b/app/generated_resources_override.grd
index 78a98817af35..2d1eae15ca42 100644
--- a/app/generated_resources_override.grd
+++ b/app/generated_resources_override.grd
@@ -331,6 +331,15 @@ are declared in tools/grit/grit_rule.gni.
+
+
+
+
+
+
+
+
+
@@ -448,6 +457,10 @@ are declared in tools/grit/grit_rule.gni.
+
+
+
+
@@ -984,9 +997,6 @@ are declared in tools/grit/grit_rule.gni.
-
-
-
@@ -1007,6 +1017,9 @@ are declared in tools/grit/grit_rule.gni.
+
+
+
Sign-in data will be stored on this device after you exit Private mode. You'll be able to sign in to this website with your device again later.
diff --git a/app/media_router_strings.grdp b/app/media_router_strings.grdp
index 092fc95a6414..62ac9dc3e00a 100644
--- a/app/media_router_strings.grdp
+++ b/app/media_router_strings.grdp
@@ -42,9 +42,6 @@
Always show icon
-
- Report an issue
-
Added by your administrator
diff --git a/app/os_settings_search_tag_strings.grdp b/app/os_settings_search_tag_strings.grdp
index 26fb6318e30b..801976ace2ca 100644
--- a/app/os_settings_search_tag_strings.grdp
+++ b/app/os_settings_search_tag_strings.grdp
@@ -1120,6 +1120,9 @@
A11y
+
+ Assistive technology
+
Always show accessibility options
@@ -1132,27 +1135,63 @@
Manage a11y
-
- BraveVox (spoken feedback)
+
+ Text-to-speech
+
+
+ Automatic reading
+
+
+ Read aloud
+
+
+ Low vision speech tools
+
+
+ Speech synthesis
-
+
+ ChromeVox (spoken feedback)
+
+
Screen reader
+
+ Braille
+
- Cursor color
+ Cursor color
+
+
+ Mouse color
+
+
+ Pointer color
Select-to-speak
- Text-to-speech
+ Text-to-speech voice settings
- TTS
+ Spoken language
+
+
+ Speech engines
+
+
+ eSpeak
+
+
+ Preferred voice
Text-to-speech rate
+
+ Speech speed
+
Text-to-speech pitch
@@ -1165,21 +1204,39 @@
Text-to-speech engines
+
+ Display and magnification
+
+
+ Low vision display tools
+
High contrast mode
- Inverted colors
+ Invert colors
Fullscreen magnifier
+
+ Zoom
+
+
+ Magnify screen
+
Magnifier follows keyboard focus
Docked magnifier
+
+ Partial magnifier
+
+
+ Keyboard and text input
+
Sticky keys
@@ -1192,24 +1249,85 @@
Speak-to-type
+
+ Speech-to-text
+
+
+ Speech recognition
+
+
+ Voice typing
+
Highlight keyboard focus
+
+ Focus ring
+
Highlight text caret
+
+ Text cursor highlighter
+
+
+ Cursor and touchpad
+
+
+ Mouse accessibility settings
+
+
+ Pointer accessibility settings
+
Automatically click when cursor stops
+
+ Auto clicks
+
Large cursor
+
+ Show large mouse cursor
+
+
+ Big mouse cursor
+
+
+ Big pointer
+
+
+ Mouse size
+
- Highlight cursor when moving
+ Highlight mouse cursor when moving
+
+
+ Highlight pointer
+
+
+ Circle pointer
+
+
+ Circle cursor
Tablet navigation buttons
+
+ Audio and captions
+
+
+ Subtitles
+
+
+ Closed captions
+
+
+ Text for audio
+
+
Mono audio
@@ -1219,12 +1337,18 @@
Startup sound
+
+ Play sound on startup
+
Caption preferences
Live Caption
+
+ Auto captions
+
Switch access
diff --git a/app/os_settings_strings.grdp b/app/os_settings_strings.grdp
index e1058cd7ef8f..5dae2bf7a9d4 100644
--- a/app/os_settings_strings.grdp
+++ b/app/os_settings_strings.grdp
@@ -38,7 +38,7 @@
-
+
Search result $11 of $22: $3Network Settings. Press Enter to navigate to section.
@@ -911,7 +911,7 @@
Show navigation buttons
- Navigate home, back, and switch apps with buttons in tablet mode. Turned on when BraveVox or Automatic clicks is enabled.
+ Navigate home, back, and switch apps with buttons in tablet mode. Turned on when ChromeVox or Automatic clicks is enabled.
@@ -963,14 +963,14 @@
Enable sticky keys (to perform keyboard shortcuts by typing them sequentially)
-
- Enable BraveVox (spoken feedback)
+
+ Enable ChromeVox (spoken feedback)
-
- Open BraveVox settings
+
+ Open ChromeVox settings
-
- Open BraveVox tutorial
+
+ Open ChromeVox tutorial
Enable fullscreen magnifier
@@ -1524,6 +1524,36 @@ Press an assigned switch or key to remove assignment.
Manage accessibility features
+
+ Text-to-Speech
+
+
+ ChromeVox screen reader and select-to-speak
+
+
+ Display and magnification
+
+
+ High-contrast mode, magnifier, and display settings
+
+
+ Keyboard and text input
+
+
+ Sticky keys, on-screen keyboard, dictation, switch access, and enhanced highlight
+
+
+ Cursor and touchpad
+
+
+ Automatic click, cursor size, cursor color, and highlight cursor
+
+
+ Audio and captions
+
+
+ Mono audio, sounds on startup, and captions
+
@@ -1844,7 +1874,7 @@ Press an assigned switch or key to remove assignment.
Add playbook
- Apply playbook
+ Select playbook
Select an Ansible Playbook to add
@@ -2173,6 +2203,9 @@ Press an assigned switch or key to remove assignment.
Bluetooth device details
+
+ Devices saved to your account
+
Connect to Bluetooth device
@@ -2186,7 +2219,7 @@ Press an assigned switch or key to remove assignment.
Scan for new devices
- Easily connect and set up devices close by
+ Easily connect and set up Fast Pair devices close by
Bluetooth enabled
@@ -2194,6 +2227,12 @@ Press an assigned switch or key to remove assignment.
Bluetooth disabled
+
+ Devices saved to your account
+
+
+ Fast Pair devices saved to $1john@google.com
+
@@ -2216,6 +2255,17 @@ Press an assigned switch or key to remove assignment.
Set up button
+
+
+ Audio
+
+
+ Output
+
+
+ Volume
+
+
Mouse
@@ -2584,7 +2634,7 @@ Press an assigned switch or key to remove assignment.
-
+
Add Cellular...
@@ -3156,11 +3206,14 @@ Press an assigned switch or key to remove assignment.
Set a PIN or password
- This PIN or password protects your data on this $1Chromebook, including any content you stream from your phone.
+ This PIN or password protects your data on this $1Chromebook, including any information you access from your phone
Choose either one each time you sign in
+
+ If Smart Lock is turned on, you won't need to enter a PIN or password
+
Make sure your phone is nearby, unlocked, and has Bluetooth and Wi-Fi turned on
@@ -3254,11 +3307,35 @@ Press an assigned switch or key to remove assignment.
You can't view your phone's notifications on this managed account. Try again with a different account. <a target="_blank" href="$1https://google.com/">Learn more</a>
-
- Your phone and $1Chromebook are connected
+
+ You can now view your phone's recent photos, media, notifications, and apps
+
+
+ You can now view your phone's recent photos, media, and notifications
+
+
+ You can now view your phone's notifications and apps
-
- Keep in mind, dismissing notifications on your Chromebook will also dismiss them on your phone
+
+ You can now view your phone's recent photos, media, and apps
+
+
+ You can now view your phone's recent photos and media
+
+
+ You can now view your phone's notifications
+
+
+ You can now view your phone's apps
+
+
+ You can set up more features in Phone Hub settings
+
+
+ Permission still needed to complete setup
+
+
+ Learn more about Phone Hub
@@ -4173,7 +4250,7 @@ Press an assigned switch or key to remove assignment.
Available devices
-
+
Storage Usage Overview
@@ -4248,9 +4325,18 @@ Press an assigned switch or key to remove assignment.
Privacy Hub
+
+ Internal camera deactivated by hardware switch
+
Camera
+
+ Microphone
+
+
+ All microphones disabled by devices hardware switch
+ $1ChromeOS Flex hardware support and stability
diff --git a/app/profiles_strings.grdp b/app/profiles_strings.grdp
index 334b6425db32..3bca371a3339 100644
--- a/app/profiles_strings.grdp
+++ b/app/profiles_strings.grdp
@@ -667,9 +667,6 @@
Your session is managed by your organization. Administrators can delete your profile and also monitor your network traffic.
-
- Next
-
Choose an account
diff --git a/app/settings_brave_strings.grdp b/app/settings_brave_strings.grdp
index a4a0f7234279..0b743bdcbd27 100644
--- a/app/settings_brave_strings.grdp
+++ b/app/settings_brave_strings.grdp
@@ -282,9 +282,12 @@
-
+
Brave Assistant in Brave
+
+ Brave Assistant in Brave can complete actions across websites for you
+
@@ -307,4 +310,14 @@
Help make Brave better by reporting the <a is="action-link" target="_blank">current settings</a>
+
+
+
+
+ Certificates managed by Brave
+
+
+ Information about how Brave manages its root certificates
+
+
diff --git a/app/settings_brave_strings_override.grdp b/app/settings_brave_strings_override.grdp
index c78a686c0617..291092232a91 100644
--- a/app/settings_brave_strings_override.grdp
+++ b/app/settings_brave_strings_override.grdp
@@ -34,4 +34,6 @@
-
+
+
+
diff --git a/app/settings_strings.grdp b/app/settings_strings.grdp
index 42e2af636760..03bd17a9e2bd 100644
--- a/app/settings_strings.grdp
+++ b/app/settings_strings.grdp
@@ -33,6 +33,9 @@
Report an issue
+
+ Send feedback
+
@@ -160,6 +163,15 @@
Show bookmarks
+
+ Side panel
+
+
+ Show on left
+
+
+ Show on right
+
New Tab page
@@ -515,9 +527,6 @@
Removing this password will not delete your account on $1airbnb.com. Change your password or delete your account on $2<a href="https://airbnb.com" target="_blank">airbnb.com</a> to keep it safe from others.
-
- Site
-
App
@@ -748,6 +757,18 @@
Remove from device
+
+ Import passwords
+
+
+ Import passwords
+
+
+ Choose file
+
+
+ To import passwords, select a CSV file.
+
Export passwords...
@@ -994,7 +1015,7 @@
There was an error while trying to write the file: $1Permission denied..
-
+
Certificates are being provisioned for these certificate profiles
@@ -1229,6 +1250,11 @@
Languages
+
+
+ Preferred languages
+
+
Search languages
@@ -1293,6 +1319,9 @@
Uses the same spell checker that’s used in Brave search. Text you type in the browser is sent to Brave.
+
+ Check for spelling errors when you type text on web pages
+
Spell check isn’t supported for the languages you selected
@@ -1963,6 +1992,14 @@
Manage HTTPS/SSL certificates and settings
+
+
+ Manage device certificates
+
+
+ Manage HTTPS/SSL certificates on your device
+
+
Manage
@@ -2008,8 +2045,8 @@
Content settings
-
- Site Settings
+
+ Site settings
Control what information websites can use and what content they can show you
@@ -3125,21 +3162,39 @@
Clear all data?
+
+ Clear displayed data?
+
- Total storage used by sites:
+ Total storage used by sites: $18 GB
+
+
+ Total storage used by displayed sites: $18 GB
Clear all data
+
+ Clear displayed data
+
This will clear $18 GB of data stored by sites
+
+ This will clear $18 GB of data stored by displayed sites
+
This will clear $18 GB of data stored by sites and installed apps
+
+ This will clear $18 GB of data stored by displayed sites and installed apps
+
You'll be signed out of all sites, including in open tabs
+
+ You'll be signed out of displayed sites, including in open tabs
+
Clear site data
@@ -3369,9 +3424,6 @@
Local storage
-
- Media license
-
File system
@@ -3393,6 +3445,9 @@
Cache Storage
+
+ Quota-managed storage
+
@@ -3460,9 +3515,6 @@
Show profile stats
-
- Also remove your existing data from this device
-
Sync will start once you leave sync settings
diff --git a/app/settings_strings_override.grdp b/app/settings_strings_override.grdp
index 4263cda27b53..6d323d3ef79e 100644
--- a/app/settings_strings_override.grdp
+++ b/app/settings_strings_override.grdp
@@ -54,10 +54,12 @@
-
+
+
+
@@ -100,6 +102,8 @@
+
+
diff --git a/app/shared_settings_strings.grdp b/app/shared_settings_strings.grdp
index f967a2240f53..cb3bbe6173f4 100644
--- a/app/shared_settings_strings.grdp
+++ b/app/shared_settings_strings.grdp
@@ -3,10 +3,10 @@
-
+ $1Bluetooth subpage back button
-
+
Click to navigate away from $1Bluetooth subpage.
@@ -228,9 +228,6 @@
Google Drive search suggestions
-
- Helps you complete tasks, such as changing your password, throughout the web
-
diff --git a/browser/android/preferences/background_video_playback_tab_helper.cc b/browser/android/preferences/background_video_playback_tab_helper.cc
index 96932c5d9f35..dfbfbcef81a5 100644
--- a/browser/android/preferences/background_video_playback_tab_helper.cc
+++ b/browser/android/preferences/background_video_playback_tab_helper.cc
@@ -71,7 +71,7 @@ void BackgroundVideoPlaybackTabHelper::DidFinishNavigation(
return;
}
if (IsBackgroundVideoPlaybackEnabled(web_contents())) {
- web_contents()->GetMainFrame()->ExecuteJavaScript(
+ web_contents()->GetPrimaryMainFrame()->ExecuteJavaScript(
k_youtube_background_playback_script, base::NullCallback());
}
}
diff --git a/browser/brave_ads/ads_tab_helper.cc b/browser/brave_ads/ads_tab_helper.cc
index 75c8981f5555..ee75616e2461 100644
--- a/browser/brave_ads/ads_tab_helper.cc
+++ b/browser/brave_ads/ads_tab_helper.cc
@@ -140,7 +140,8 @@ void AdsTabHelper::DidFinishNavigation(
}
void AdsTabHelper::DocumentOnLoadCompletedInPrimaryMainFrame() {
- content::RenderFrameHost* render_frame_host = web_contents()->GetMainFrame();
+ content::RenderFrameHost* render_frame_host =
+ web_contents()->GetPrimaryMainFrame();
if (search_result_ad_service_) {
search_result_ad_service_->MaybeRetrieveSearchResultAd(
render_frame_host, tab_id_, should_process_);
diff --git a/browser/brave_profile_prefs.cc b/browser/brave_profile_prefs.cc
index 1911e8177235..e0f72bee2021 100644
--- a/browser/brave_profile_prefs.cc
+++ b/browser/brave_profile_prefs.cc
@@ -328,10 +328,6 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
registry->SetDefaultPrefValue(prefs::kPrivacySandboxApisEnabledV2,
base::Value(false));
- // Disable Chromium's privacy sandbox
- registry->SetDefaultPrefValue(prefs::kPrivacySandboxFlocEnabled,
- base::Value(false));
-
// Importer: selected data types
registry->RegisterBooleanPref(kImportDialogExtensions, true);
registry->RegisterBooleanPref(kImportDialogPayments, true);
diff --git a/browser/brave_rewards/extension_rewards_service_observer.cc b/browser/brave_rewards/extension_rewards_service_observer.cc
index 7e05b6f9aeda..eb7ae29af1fb 100644
--- a/browser/brave_rewards/extension_rewards_service_observer.cc
+++ b/browser/brave_rewards/extension_rewards_service_observer.cc
@@ -311,7 +311,7 @@ void ExtensionRewardsServiceObserver::OnUnblindedTokensReady(
std::unique_ptr event(new extensions::Event(
extensions::events::BRAVE_START,
extensions::api::brave_rewards::OnUnblindedTokensReady::kEventName,
- std::vector()));
+ base::Value::List()));
event_router->BroadcastEvent(std::move(event));
}
diff --git a/browser/brave_shields/domain_block_page_browsertest.cc b/browser/brave_shields/domain_block_page_browsertest.cc
index 65ffa7e6ade9..f684395fd41d 100644
--- a/browser/brave_shields/domain_block_page_browsertest.cc
+++ b/browser/brave_shields/domain_block_page_browsertest.cc
@@ -64,12 +64,12 @@ class DomainBlockTestBase : public AdBlockServiceTest {
void NavigateTo(const GURL& url) {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
- content::RenderFrameHost* frame = web_contents()->GetMainFrame();
+ content::RenderFrameHost* frame = web_contents()->GetPrimaryMainFrame();
ASSERT_TRUE(WaitForRenderFrameReady(frame));
}
void Click(const std::string& id) {
- content::RenderFrameHost* frame = web_contents()->GetMainFrame();
+ content::RenderFrameHost* frame = web_contents()->GetPrimaryMainFrame();
frame->ExecuteJavaScriptForTests(
base::ASCIIToUTF16("document.getElementById('" + id + "').click();\n"),
base::NullCallback());
diff --git a/browser/brave_wallet/brave_wallet_service_delegate_impl.cc b/browser/brave_wallet/brave_wallet_service_delegate_impl.cc
index 5274bb13236c..a0c704932c47 100644
--- a/browser/brave_wallet/brave_wallet_service_delegate_impl.cc
+++ b/browser/brave_wallet/brave_wallet_service_delegate_impl.cc
@@ -199,7 +199,7 @@ void BraveWalletServiceDelegateImpl::FireActiveOriginChanged() {
url::Origin BraveWalletServiceDelegateImpl::GetActiveOriginInternal() {
content::WebContents* contents = GetActiveWebContents();
- return contents ? contents->GetMainFrame()->GetLastCommittedOrigin()
+ return contents ? contents->GetPrimaryMainFrame()->GetLastCommittedOrigin()
: url::Origin();
}
diff --git a/browser/brave_wallet/brave_wallet_tab_helper_browsertest.cc b/browser/brave_wallet/brave_wallet_tab_helper_browsertest.cc
index 7e97cc168474..01fbe695b775 100644
--- a/browser/brave_wallet/brave_wallet_tab_helper_browsertest.cc
+++ b/browser/brave_wallet/brave_wallet_tab_helper_browsertest.cc
@@ -37,7 +37,7 @@ const char kEmbeddedTestServerDirectory[] = "brave-wallet";
base::OnceClosure ShowChooserBubble(
content::WebContents* contents,
std::unique_ptr controller) {
- return chrome::ShowDeviceChooserDialog(contents->GetMainFrame(),
+ return chrome::ShowDeviceChooserDialog(contents->GetPrimaryMainFrame(),
std::move(controller));
}
diff --git a/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc b/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc
index 8ed873068837..973b76f1665d 100644
--- a/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc
+++ b/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc
@@ -34,8 +34,8 @@ std::u16string GetHIDTitle(content::WebContents* content, const GURL& url) {
std::vector filters;
std::vector exclusion_filters;
auto hid_chooser_controller = std::make_unique(
- content->GetMainFrame(), std::move(filters), std::move(exclusion_filters),
- base::DoNothing());
+ content->GetPrimaryMainFrame(), std::move(filters),
+ std::move(exclusion_filters), base::DoNothing());
return hid_chooser_controller->GetTitle();
}
} // namespace
diff --git a/browser/brave_wallet/ethereum_provider_impl_unittest.cc b/browser/brave_wallet/ethereum_provider_impl_unittest.cc
index 200eb0795b25..b1487127cd58 100644
--- a/browser/brave_wallet/ethereum_provider_impl_unittest.cc
+++ b/browser/brave_wallet/ethereum_provider_impl_unittest.cc
@@ -10,6 +10,7 @@
#include
#include "base/callback_helpers.h"
+#include "base/files/scoped_temp_dir.h"
#include "base/json/json_reader.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_number_conversions.h"
@@ -213,7 +214,7 @@ class EthereumProviderImplUnitTest : public testing::Test {
host_content_settings_map(), json_rpc_service(), tx_service(),
keyring_service(), brave_wallet_service_,
std::make_unique(
- web_contents(), web_contents()->GetMainFrame()),
+ web_contents(), web_contents()->GetPrimaryMainFrame()),
prefs());
observer_.reset(new TestEventsListener());
@@ -369,7 +370,7 @@ class EthereumProviderImplUnitTest : public testing::Test {
void Navigate(const GURL& url) { web_contents()->NavigateAndCommit(url); }
url::Origin GetOrigin() {
- return web_contents()->GetMainFrame()->GetLastCommittedOrigin();
+ return web_contents()->GetPrimaryMainFrame()->GetLastCommittedOrigin();
}
void CreateBraveWalletTabHelper() {
@@ -993,11 +994,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApproveTransaction) {
"\"gas\":\"0x0974\",\"to\":"
"\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x016345785d8a0000\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1064,11 +1063,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApproveTransactionError) {
"\",\"gasPrice\":\"0x09184e72a000\","
"\"gas\":\"0x0974\",\"to\":\"0xbe8\","
"\"value\":\"0x016345785d8a0000\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1103,11 +1100,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApproveTransactionNoPermission) {
"\"gas\":\"0x0974\",\"to\":"
"\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x016345785d8a0000\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1146,11 +1141,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApprove1559Transaction) {
"\",\"maxFeePerGas\":\"0x1\",\"maxPriorityFeePerGas\":\"0x1\","
"\"gas\":\"0x1\",\"to\":\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x00\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1214,11 +1207,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApprove1559TransactionNoChainId) {
"\",\"maxFeePerGas\":\"0x1\",\"maxPriorityFeePerGas\":\"0x1\","
"\"gas\":\"0x1\",\"to\":\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x00\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1282,11 +1273,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApprove1559TransactionError) {
"\"gasPrice\":\"0x01\", "
"\"gas\":\"0x00\",\"to\":\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x00\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
@@ -1320,11 +1309,9 @@ TEST_F(EthereumProviderImplUnitTest, AddAndApprove1559TransactionNoPermission) {
"\",\"maxFeePerGas\":\"0x0\",\"maxPriorityFeePerGas\":\"0x0\","
"\"gas\":\"0x00\",\"to\":\"0xbe862ad9abfe6f22bcb087716c7d89a26051f74c\","
"\"value\":\"0x00\"}]}";
- base::JSONReader::ValueWithError value_with_error =
- base::JSONReader::ReadAndReturnValueWithError(
- normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
- base::JSONParserOptions::JSON_PARSE_RFC);
- absl::optional& response = value_with_error.value;
+ absl::optional response = base::JSONReader::Read(
+ normalized_json_request, base::JSON_PARSE_CHROMIUM_EXTENSIONS |
+ base::JSONParserOptions::JSON_PARSE_RFC);
provider()->Request(
response->Clone(),
base::BindLambdaForTesting(
diff --git a/browser/brave_wallet/external_wallets_importer.cc b/browser/brave_wallet/external_wallets_importer.cc
index 1b9a961487d8..0fc6221fe1ea 100644
--- a/browser/brave_wallet/external_wallets_importer.cc
+++ b/browser/brave_wallet/external_wallets_importer.cc
@@ -50,11 +50,7 @@ void OnRunWithStorage(base::OnceCallback callback,
ValueStore* storage) {
DCHECK(IsOnBackendSequence());
DCHECK(storage);
- auto current_settings = storage->Get().PassSettings();
- if (current_settings)
- std::move(callback).Run(std::move(*current_settings->GetIfDict()));
- else
- std::move(callback).Run(base::Value::Dict());
+ std::move(callback).Run(storage->Get().PassSettings());
}
std::string GetLegacyCryptoWalletsPassword(const std::string& password,
@@ -97,10 +93,10 @@ std::string GetLegacyCryptoWalletsPassword(const std::string& password,
// bytes size
// https://github.com/urbit/argon2-wasm/blob/c9e73723cebe3d76cf286f5c7709b64edb25c684/index.js#L73
size_t character_count = 0;
- for (int32_t i = 0; i < (int32_t)salt_str->size(); ++i) {
+ for (size_t i = 0; i < salt_str->size(); ++i) {
base_icu::UChar32 code_point;
- if (base::ReadUnicodeCharacter((const char*)salt_str->data(),
- salt_str->size(), &i, &code_point))
+ if (base::ReadUnicodeCharacter(salt_str->data(), salt_str->size(), &i,
+ &code_point))
++character_count;
}
@@ -124,10 +120,11 @@ std::string GetLegacyCryptoWalletsPassword(const std::string& password,
// unicdoe encoding and replace it with � (code point 0xFFFD) // NOLINT
// because js implementation forcibly utf8 decode sub_key
// https://github.com/brave/KeyringController/blob/0769514cea07e85ae190f30765d0a301c631c56b/index.js#L547
- for (int32_t i = 0; i < (int32_t)sub_key.size(); ++i) {
+ for (size_t i = 0; i < sub_key.size(); ++i) {
base_icu::UChar32 code_point;
- if (!base::ReadUnicodeCharacter((const char*)sub_key.data(), sub_key.size(),
- &i, &code_point) ||
+ if (!base::ReadUnicodeCharacter(
+ reinterpret_cast(sub_key.data()), sub_key.size(), &i,
+ &code_point) ||
!base::IsValidCodepoint(code_point)) {
code_point = 0xfffd;
}
diff --git a/browser/brave_wallet/solana_provider_impl_unittest.cc b/browser/brave_wallet/solana_provider_impl_unittest.cc
index dfcc50de6c43..b2a0bc496ef3 100644
--- a/browser/brave_wallet/solana_provider_impl_unittest.cc
+++ b/browser/brave_wallet/solana_provider_impl_unittest.cc
@@ -117,7 +117,7 @@ class SolanaProviderImplUnitTest : public testing::Test {
provider_ = std::make_unique(
keyring_service_, brave_wallet_service_, tx_service_,
std::make_unique(
- web_contents(), web_contents()->GetMainFrame()));
+ web_contents(), web_contents()->GetPrimaryMainFrame()));
observer_.reset(new TestEventsListener());
provider_->Init(observer_->GetReceiver());
}
@@ -132,7 +132,7 @@ class SolanaProviderImplUnitTest : public testing::Test {
void Navigate(const GURL& url) { web_contents()->NavigateAndCommit(url); }
url::Origin GetOrigin() {
- return web_contents()->GetMainFrame()->GetLastCommittedOrigin();
+ return web_contents()->GetPrimaryMainFrame()->GetLastCommittedOrigin();
}
std::vector GetPendingSignMessageRequests()
diff --git a/browser/brave_wallet/solana_provider_renderer_browsertest.cc b/browser/brave_wallet/solana_provider_renderer_browsertest.cc
index 13e399c9b208..74e2240583da 100644
--- a/browser/brave_wallet/solana_provider_renderer_browsertest.cc
+++ b/browser/brave_wallet/solana_provider_renderer_browsertest.cc
@@ -693,7 +693,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, Connect) {
result2.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetError(SolanaProviderError::kUserRejectedRequest, kErrorMessage);
@@ -726,7 +726,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, IsConnected) {
EXPECT_EQ(base::Value(true), result.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
// just make TestSolanaProvider::IsConnected to return false
@@ -806,7 +806,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, SignTransaction) {
result4.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetError(SolanaProviderError::kUserRejectedRequest, kErrorMessage);
@@ -868,7 +868,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, SignAllTransactions) {
result5.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetError(SolanaProviderError::kUserRejectedRequest, kErrorMessage);
@@ -892,7 +892,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, SignAndSendTransaction) {
serialized_tx_str, "])), ", send_options, ")"});
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetSendOptions(
base::JSONReader::Read(send_options)->GetDict().Clone());
@@ -999,7 +999,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, SignMessage) {
EXPECT_EQ(base::Value(true), result6.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetError(SolanaProviderError::kUserRejectedRequest, kErrorMessage);
@@ -1051,7 +1051,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, Request) {
result5.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetError(SolanaProviderError::kUserRejectedRequest, kErrorMessage);
@@ -1071,7 +1071,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, OnAccountChanged) {
EXPECT_EQ(base::Value(kTestPublicKey), result.value);
TestSolanaProvider* provider = test_content_browser_client_.GetProvider(
- web_contents(browser())->GetMainFrame());
+ web_contents(browser())->GetPrimaryMainFrame());
ASSERT_TRUE(provider);
provider->SetEmitEmptyAccountChanged(true);
@@ -1219,7 +1219,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, Iframe3P) {
SCOPED_TRACE(testing::Message() << c.script << c.iframe_url);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), c.top_url));
content::RenderFrameHost* main_frame =
- web_contents(browser())->GetMainFrame();
+ web_contents(browser())->GetPrimaryMainFrame();
EXPECT_TRUE(content::EvalJs(main_frame, c.script).ExtractBool());
EXPECT_TRUE(
NavigateIframeToURL(web_contents(browser()), "test", c.iframe_url));
@@ -1231,7 +1231,7 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, Iframe3P) {
SCOPED_TRACE(testing::Message() << c.script << c.top_url << c.iframe_url);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), c.top_url));
content::RenderFrameHost* main_frame =
- web_contents(browser())->GetMainFrame();
+ web_contents(browser())->GetPrimaryMainFrame();
EXPECT_TRUE(content::EvalJs(main_frame, c.script).ExtractBool());
EXPECT_TRUE(
NavigateIframeToURL(web_contents(browser()), "test", c.iframe_url));
@@ -1247,24 +1247,24 @@ IN_PROC_BROWSER_TEST_F(SolanaProviderRendererTest, SecureContextOnly) {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
constexpr char kEvalSolana[] = "typeof window.braveSolana !== 'undefined'";
content::RenderFrameHost* main_frame =
- web_contents(browser())->GetMainFrame();
+ web_contents(browser())->GetPrimaryMainFrame();
EXPECT_TRUE(content::EvalJs(main_frame, kEvalSolana).ExtractBool());
// Insecure context
url = embedded_test_server()->GetURL("a.com", "/simple.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
- main_frame = web_contents(browser())->GetMainFrame();
+ main_frame = web_contents(browser())->GetPrimaryMainFrame();
EXPECT_FALSE(content::EvalJs(main_frame, kEvalSolana).ExtractBool());
// Secure context localhost HTTP
url = embedded_test_server()->GetURL("localhost", "/simple.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
- main_frame = web_contents(browser())->GetMainFrame();
+ main_frame = web_contents(browser())->GetPrimaryMainFrame();
EXPECT_TRUE(content::EvalJs(main_frame, kEvalSolana).ExtractBool());
// Secure context 127.0.0.1 HTTP
url = embedded_test_server()->GetURL("localhost", "/simple.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
- main_frame = web_contents(browser())->GetMainFrame();
+ main_frame = web_contents(browser())->GetPrimaryMainFrame();
EXPECT_TRUE(content::EvalJs(main_frame, kEvalSolana).ExtractBool());
}
diff --git a/browser/decentralized_dns/test/decentralized_dns_navigation_throttle_browsertest.cc b/browser/decentralized_dns/test/decentralized_dns_navigation_throttle_browsertest.cc
index c9f91f295fdb..6f360c26be36 100644
--- a/browser/decentralized_dns/test/decentralized_dns_navigation_throttle_browsertest.cc
+++ b/browser/decentralized_dns/test/decentralized_dns_navigation_throttle_browsertest.cc
@@ -92,7 +92,7 @@ IN_PROC_BROWSER_TEST_F(DecentralizedDnsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(DecentralizedDnsOptInPage::kTypeForTesting,
GetInterstitialType(web_contents));
@@ -113,7 +113,7 @@ IN_PROC_BROWSER_TEST_F(DecentralizedDnsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(DecentralizedDnsOptInPage::kTypeForTesting,
GetInterstitialType(web_contents));
@@ -133,7 +133,7 @@ IN_PROC_BROWSER_TEST_F(DecentralizedDnsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(DecentralizedDnsOptInPage::kTypeForTesting,
GetInterstitialType(web_contents));
@@ -153,7 +153,7 @@ IN_PROC_BROWSER_TEST_F(DecentralizedDnsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(DecentralizedDnsOptInPage::kTypeForTesting,
GetInterstitialType(web_contents));
diff --git a/browser/download/brave_download_item_model.cc b/browser/download/brave_download_item_model.cc
index 24152867b8e1..66702812067e 100644
--- a/browser/download/brave_download_item_model.cc
+++ b/browser/download/brave_download_item_model.cc
@@ -50,7 +50,7 @@ std::u16string BraveDownloadItemModel::GetTooltipText() {
// Returns origin url text and sets |is_secure|.
std::u16string BraveDownloadItemModel::GetOriginURLText(bool* is_secure) {
*is_secure = false;
- const GURL gurl = model_->download()->GetURL();
+ const GURL gurl = model_->GetDownloadItem()->GetURL();
if (gurl.is_empty()) {
return std::u16string();
}
diff --git a/browser/ephemeral_storage/blob_url_browsertest.cc b/browser/ephemeral_storage/blob_url_browsertest.cc
index 743830d71b12..06d5c84a5b4a 100644
--- a/browser/ephemeral_storage/blob_url_browsertest.cc
+++ b/browser/ephemeral_storage/blob_url_browsertest.cc
@@ -127,7 +127,8 @@ class BlobUrlBrowserTestBase : public EphemeralStorageBrowserTest {
FramesWithRegisteredBlobs RegisterBlobs(const GURL& url) {
FramesWithRegisteredBlobs frames_with_registered_blobs;
- content::RenderFrameHost* main_frame = LoadURLInNewTab(url)->GetMainFrame();
+ content::RenderFrameHost* main_frame =
+ LoadURLInNewTab(url)->GetPrimaryMainFrame();
const std::vector rfhs = GetFrames(main_frame);
for (size_t idx = 0; idx < rfhs.size(); ++idx) {
diff --git a/browser/ephemeral_storage/ephemeral_storage_1p_browsertest.cc b/browser/ephemeral_storage/ephemeral_storage_1p_browsertest.cc
index 15764d32c0d5..ad4483a05a6d 100644
--- a/browser/ephemeral_storage/ephemeral_storage_1p_browsertest.cc
+++ b/browser/ephemeral_storage/ephemeral_storage_1p_browsertest.cc
@@ -98,7 +98,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
// We set a value in the page where all the frames are first-party.
SetValuesInFrames(first_party_tab, "b.com - first party", "from=b.com");
- // The page this tab is loaded via a.com and has two b.com third-party
+ // The page in this tab is loaded via a.com and has two b.com third-party
// iframes. The third-party iframes should have ephemeral storage. That means
// that their values should be shared by third-party b.com iframes loaded from
// a.com.
@@ -180,14 +180,18 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
WebContents* site_b = LoadURLInNewTab(b_site_ephemeral_storage_url_);
// Main frame and 1p frame.
- EXPECT_FALSE(SetIDBValue(site_a->GetMainFrame()));
- EXPECT_FALSE(SetIDBValue(content::ChildFrameAt(site_a->GetMainFrame(), 2)));
+ EXPECT_FALSE(SetIDBValue(site_a->GetPrimaryMainFrame()));
+ EXPECT_FALSE(
+ SetIDBValue(content::ChildFrameAt(site_a->GetPrimaryMainFrame(), 2)));
// 3p frames.
- EXPECT_FALSE(SetIDBValue(content::ChildFrameAt(site_a->GetMainFrame(), 0)));
- EXPECT_FALSE(SetIDBValue(content::ChildFrameAt(site_a->GetMainFrame(), 1)));
+ EXPECT_FALSE(
+ SetIDBValue(content::ChildFrameAt(site_a->GetPrimaryMainFrame(), 0)));
+ EXPECT_FALSE(
+ SetIDBValue(content::ChildFrameAt(site_a->GetPrimaryMainFrame(), 1)));
// 3p frame.
- EXPECT_FALSE(SetIDBValue(content::ChildFrameAt(site_b->GetMainFrame(), 2)));
+ EXPECT_FALSE(
+ SetIDBValue(content::ChildFrameAt(site_b->GetPrimaryMainFrame(), 2)));
}
IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
@@ -277,13 +281,15 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
.empty());
// JS cookie request should return valid results.
- EXPECT_EQ("name=acom", GetCookiesInFrame(site_a_set_cookies->GetMainFrame()));
- EXPECT_EQ("name=bcom", GetCookiesInFrame(site_b_set_cookies->GetMainFrame()));
- EXPECT_EQ("name=acom", GetCookiesInFrame(site_a->GetMainFrame()));
+ EXPECT_EQ("name=acom",
+ GetCookiesInFrame(site_a_set_cookies->GetPrimaryMainFrame()));
+ EXPECT_EQ("name=bcom",
+ GetCookiesInFrame(site_b_set_cookies->GetPrimaryMainFrame()));
+ EXPECT_EQ("name=acom", GetCookiesInFrame(site_a->GetPrimaryMainFrame()));
// The third-party iframe should not have the b.com cookie that was set on the
// main frame.
- RenderFrameHost* main_frame = site_a->GetMainFrame();
+ RenderFrameHost* main_frame = site_a->GetPrimaryMainFrame();
RenderFrameHost* iframe_a = content::ChildFrameAt(main_frame, 0);
RenderFrameHost* iframe_b = content::ChildFrameAt(main_frame, 1);
EXPECT_EQ("", GetCookiesInFrame(iframe_a));
@@ -298,11 +304,11 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
ASSERT_EQ("name=bcom_ephemeral", GetCookiesInFrame(iframe_a));
ASSERT_EQ("name=bcom_ephemeral", GetCookiesInFrame(iframe_b));
- // The cookie set in the ephemeral area should not visible in the main
+ // The cookie set in the ephemeral area should not be visible in the main
// cookie storage.
EXPECT_TRUE(content::GetCookies(browser()->profile(), GURL("https://b.com/"))
.empty());
- EXPECT_EQ("name=bcom", GetCookiesInFrame(site_b->GetMainFrame()));
+ EXPECT_EQ("name=bcom", GetCookiesInFrame(site_b->GetPrimaryMainFrame()));
// Navigating to a new TLD should clear all ephemeral cookies after keep-alive
// timeout.
@@ -339,7 +345,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), a_site_ephemeral_storage_url_));
- RenderFrameHost* site_a_main_frame = web_contents->GetMainFrame();
+ RenderFrameHost* site_a_main_frame = web_contents->GetPrimaryMainFrame();
RenderFrameHost* nested_frames_tab =
content::ChildFrameAt(site_a_main_frame, 3);
ASSERT_NE(nested_frames_tab, nullptr);
@@ -348,7 +354,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pBrowserTest,
ASSERT_NE(first_party_nested_acom, nullptr);
WebContents* site_b_tab = LoadURLInNewTab(b_site_ephemeral_storage_url_);
- RenderFrameHost* site_b_main_frame = site_b_tab->GetMainFrame();
+ RenderFrameHost* site_b_main_frame = site_b_tab->GetPrimaryMainFrame();
RenderFrameHost* third_party_nested_acom =
content::ChildFrameAt(site_b_main_frame, 2);
ASSERT_NE(first_party_nested_acom, nullptr);
@@ -532,11 +538,12 @@ IN_PROC_BROWSER_TEST_F(
}
// By default SESSION_ONLY setting means that data for a website should be
-// deleted after a restart, but this also implicitly change how a website
+// deleted after a restart, but this also implicitly changes how a website
// behaves in 3p context: when the setting is explicit, Chromium removes 3p
-// restrictions which effectively allows the website store any data persistently
-// in 3p context. We change Chromium behaviour for this option to keep blocking
-// a website in 3p context when a global "block_third_party" option is enabled.
+// restrictions which effectively allows the website to store any data
+// persistently in 3p context. We change Chromium's behavior for this option to
+// keep blocking a website in 3p context when a global "block_third_party"
+// option is enabled.
IN_PROC_BROWSER_TEST_F(EphemeralStorage1pDisabledBrowserTest,
SessionOnlyModeUsesEphemeralStorage) {
SetCookieSetting(b_site_ephemeral_storage_url_, CONTENT_SETTING_SESSION_ONLY);
diff --git a/browser/ephemeral_storage/ephemeral_storage_1p_domain_block_browsertest.cc b/browser/ephemeral_storage/ephemeral_storage_1p_domain_block_browsertest.cc
index 7787583d4ab3..a6c9b7e8c6e1 100644
--- a/browser/ephemeral_storage/ephemeral_storage_1p_domain_block_browsertest.cc
+++ b/browser/ephemeral_storage/ephemeral_storage_1p_domain_block_browsertest.cc
@@ -66,7 +66,7 @@ class EphemeralStorage1pDomainBlockBrowserTest
}
void Click(WebContents* web_contents, const std::string& id) {
- content::RenderFrameHost* frame = web_contents->GetMainFrame();
+ content::RenderFrameHost* frame = web_contents->GetPrimaryMainFrame();
frame->ExecuteJavaScriptForTests(
base::ASCIIToUTF16("document.getElementById('" + id + "').click();\n"),
base::NullCallback());
@@ -99,7 +99,7 @@ class EphemeralStorage1pDomainBlockBrowserTest
ClickAndWaitForNavigation(first_party_tab, "primary-button");
}
- RenderFrameHost* main_frame = first_party_tab->GetMainFrame();
+ RenderFrameHost* main_frame = first_party_tab->GetPrimaryMainFrame();
SetValuesInFrame(main_frame, "a.com", "from=a.com");
ValuesFromFrame main_frame_values = GetValuesFromFrame(main_frame);
@@ -124,7 +124,7 @@ class EphemeralStorage1pDomainBlockBrowserTest
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), a_site_simple_url_));
ExpectValuesFromFrameAreEmpty(
- FROM_HERE, GetValuesFromFrame(first_party_tab->GetMainFrame()));
+ FROM_HERE, GetValuesFromFrame(first_party_tab->GetPrimaryMainFrame()));
EXPECT_EQ(GetCookieSetting(a_site_simple_url_),
ContentSetting::CONTENT_SETTING_SESSION_ONLY);
}
@@ -142,7 +142,7 @@ class EphemeralStorage1pDomainBlockBrowserTest
{
ValuesFromFrame first_party_values =
- GetValuesFromFrame(first_party_tab->GetMainFrame());
+ GetValuesFromFrame(first_party_tab->GetPrimaryMainFrame());
EXPECT_EQ("a.com", first_party_values.local_storage);
EXPECT_EQ("a.com", first_party_values.session_storage);
EXPECT_EQ("from=a.com", first_party_values.cookies);
@@ -187,7 +187,7 @@ IN_PROC_BROWSER_TEST_F(
FirstPartyEphemeralIsNotEnabledIfLocalStorageDataStored) {
// Store local storage value in a.com.
WebContents* first_party_tab = LoadURLInNewTab(a_site_simple_url_);
- SetStorageValueInFrame(first_party_tab->GetMainFrame(), "a.com",
+ SetStorageValueInFrame(first_party_tab->GetPrimaryMainFrame(), "a.com",
StorageType::Local);
// Navigate away to b.com.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), b_site_simple_url_));
@@ -219,7 +219,7 @@ IN_PROC_BROWSER_TEST_F(
ClickAndWaitForNavigation(first_party_tab, "primary-button");
ExpectValuesFromFrameAreEmpty(
- FROM_HERE, GetValuesFromFrame(first_party_tab->GetMainFrame()));
+ FROM_HERE, GetValuesFromFrame(first_party_tab->GetPrimaryMainFrame()));
EXPECT_EQ(0u, GetAllCookies().size());
EXPECT_EQ(GetCookieSetting(a_site_simple_url_),
ContentSetting::CONTENT_SETTING_SESSION_ONLY);
@@ -242,7 +242,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorage1pDomainBlockBrowserTest,
EXPECT_FALSE(IsShowingInterstitial(first_party_tab));
ValuesFromFrame first_party_values =
- GetValuesFromFrame(first_party_tab->GetMainFrame());
+ GetValuesFromFrame(first_party_tab->GetPrimaryMainFrame());
EXPECT_EQ("a.com", first_party_values.local_storage);
EXPECT_EQ("a.com", first_party_values.session_storage);
EXPECT_EQ("from=a.com", first_party_values.cookies);
diff --git a/browser/ephemeral_storage/ephemeral_storage_browsertest.cc b/browser/ephemeral_storage/ephemeral_storage_browsertest.cc
index ad6668e788d6..29bf2448b430 100644
--- a/browser/ephemeral_storage/ephemeral_storage_browsertest.cc
+++ b/browser/ephemeral_storage/ephemeral_storage_browsertest.cc
@@ -210,7 +210,7 @@ void EphemeralStorageBrowserTest::SetValuesInFrame(RenderFrameHost* frame,
void EphemeralStorageBrowserTest::SetValuesInFrames(WebContents* web_contents,
std::string storage_value,
std::string cookie_value) {
- RenderFrameHost* main = web_contents->GetMainFrame();
+ RenderFrameHost* main = web_contents->GetPrimaryMainFrame();
SetValuesInFrame(main, storage_value, cookie_value);
SetValuesInFrame(content::ChildFrameAt(main, 0), storage_value, cookie_value);
SetValuesInFrame(content::ChildFrameAt(main, 1), storage_value, cookie_value);
@@ -227,7 +227,7 @@ EphemeralStorageBrowserTest::GetValuesFromFrame(RenderFrameHost* frame) {
EphemeralStorageBrowserTest::ValuesFromFrames
EphemeralStorageBrowserTest::GetValuesFromFrames(WebContents* web_contents) {
- RenderFrameHost* main_frame = web_contents->GetMainFrame();
+ RenderFrameHost* main_frame = web_contents->GetPrimaryMainFrame();
return {
GetValuesFromFrame(main_frame),
GetValuesFromFrame(content::ChildFrameAt(main_frame, 0)),
@@ -805,7 +805,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
// The third-party iframe should not have the b.com cookie that was set on the
// main frame.
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
- RenderFrameHost* main_frame = web_contents->GetMainFrame();
+ RenderFrameHost* main_frame = web_contents->GetPrimaryMainFrame();
RenderFrameHost* iframe_a = content::ChildFrameAt(main_frame, 0);
RenderFrameHost* iframe_b = content::ChildFrameAt(main_frame, 1);
ASSERT_EQ("", GetCookiesInFrame(iframe_a));
@@ -931,7 +931,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
// Gather all WebContents and frames in a usable structure.
base::flat_map> frames;
for (auto* wc : {site_a_tab1, site_a_tab2, site_b_tab1, site_b_tab2}) {
- auto* main_rfh = wc->GetMainFrame();
+ auto* main_rfh = wc->GetPrimaryMainFrame();
CreateBroadcastChannel(main_rfh);
frames[wc].push_back(main_rfh);
for (size_t child_idx = 0; child_idx < 4; ++child_idx) {
@@ -1017,7 +1017,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), a_site_ephemeral_storage_url_));
- RenderFrameHost* site_a_main_frame = web_contents->GetMainFrame();
+ RenderFrameHost* site_a_main_frame = web_contents->GetPrimaryMainFrame();
RenderFrameHost* nested_frames_tab =
content::ChildFrameAt(site_a_main_frame, 3);
ASSERT_NE(nested_frames_tab, nullptr);
@@ -1026,7 +1026,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
ASSERT_NE(first_party_nested_acom, nullptr);
WebContents* site_b_tab = LoadURLInNewTab(b_site_ephemeral_storage_url_);
- RenderFrameHost* site_b_main_frame = site_b_tab->GetMainFrame();
+ RenderFrameHost* site_b_main_frame = site_b_tab->GetPrimaryMainFrame();
RenderFrameHost* third_party_nested_acom =
content::ChildFrameAt(site_b_main_frame, 2);
ASSERT_NE(first_party_nested_acom, nullptr);
diff --git a/browser/ephemeral_storage/hsts_partitioning_browsertest.cc b/browser/ephemeral_storage/hsts_partitioning_browsertest.cc
index 902fb66b2694..5927c019353a 100644
--- a/browser/ephemeral_storage/hsts_partitioning_browsertest.cc
+++ b/browser/ephemeral_storage/hsts_partitioning_browsertest.cc
@@ -160,17 +160,17 @@ class HSTSPartitioningBrowserTestBase : public InProcessBrowserTest {
return result;
}
- base::Value NetworkContextGetHSTSState(const std::string& host) {
+ base::Value::Dict NetworkContextGetHSTSState(const std::string& host) {
content::StoragePartition* partition =
browser()->profile()->GetDefaultStoragePartition();
base::RunLoop run_loop;
- base::Value result;
+ base::Value::Dict result;
partition->GetNetworkContext()->GetHSTSState(
- host,
- base::BindLambdaForTesting([&run_loop, &result](base::Value sts_state) {
- result = std::move(sts_state);
- run_loop.Quit();
- }));
+ host, base::BindLambdaForTesting(
+ [&run_loop, &result](base::Value::Dict sts_state) {
+ result = std::move(sts_state);
+ run_loop.Quit();
+ }));
run_loop.Run();
return result;
}
@@ -481,13 +481,13 @@ IN_PROC_BROWSER_TEST_F(HSTSPartitioningEnabledBrowserTest, NetworkContextAPI) {
ExpectHSTSState(a_com_rfh, "a.com", true);
EXPECT_TRUE(NetworkContextIsHSTSActiveForHost("a.com"));
EXPECT_TRUE(
- NetworkContextGetHSTSState("a.com").FindIntKey("dynamic_upgrade_mode"));
+ NetworkContextGetHSTSState("a.com").FindInt("dynamic_upgrade_mode"));
SetHSTS(a_com_rfh, "b.com");
ExpectHSTSState(a_com_rfh, "b.com", true);
EXPECT_FALSE(NetworkContextIsHSTSActiveForHost("b.com"));
EXPECT_FALSE(
- NetworkContextGetHSTSState("b.com").FindIntKey("dynamic_upgrade_mode"));
+ NetworkContextGetHSTSState("b.com").FindInt("dynamic_upgrade_mode"));
GURL b_com_url("http://b.com/iframe.html");
auto* b_com_rfh = ui_test_utils::NavigateToURLWithDisposition(
@@ -511,8 +511,8 @@ IN_PROC_BROWSER_TEST_F(HSTSPartitioningEnabledBrowserTest,
NetworkContextAddHSTS) {
NetworkContextAddHSTS("sub.a.com");
EXPECT_TRUE(NetworkContextIsHSTSActiveForHost("sub.a.com"));
- EXPECT_TRUE(NetworkContextGetHSTSState("sub.a.com")
- .FindIntKey("dynamic_upgrade_mode"));
+ EXPECT_TRUE(
+ NetworkContextGetHSTSState("sub.a.com").FindInt("dynamic_upgrade_mode"));
GURL a_com_url("http://sub.a.com/iframe.html");
auto* a_com_rfh = ui_test_utils::NavigateToURL(browser(), a_com_url);
diff --git a/browser/farbling/brave_font_whitelist_browsertest.cc b/browser/farbling/brave_font_whitelist_browsertest.cc
index b0e71aa32c09..9071a0ec9790 100644
--- a/browser/farbling/brave_font_whitelist_browsertest.cc
+++ b/browser/farbling/brave_font_whitelist_browsertest.cc
@@ -8,7 +8,6 @@
#include "brave/components/content_settings/renderer/brave_content_settings_agent_impl.h"
#include "brave/third_party/blink/renderer/brave_font_whitelist.h"
#include "content/public/renderer/render_frame.h"
-#include "content/public/renderer/render_view.h"
#include "content/public/test/render_view_test.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/web/web_document.h"
diff --git a/browser/favicon/favicon_database_browsertest.cc b/browser/favicon/favicon_database_browsertest.cc
index 5f7b22ece164..fc42675d82b2 100644
--- a/browser/favicon/favicon_database_browsertest.cc
+++ b/browser/favicon/favicon_database_browsertest.cc
@@ -157,7 +157,7 @@ class BraveFaviconDatabaseBrowserTest : public InProcessBrowserTest {
ui_test_utils::UrlLoadObserver load_complete(
landing_url(), content::NotificationService::AllSources());
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
- EXPECT_EQ(contents()->GetMainFrame()->GetLastCommittedURL(), url);
+ EXPECT_EQ(contents()->GetPrimaryMainFrame()->GetLastCommittedURL(), url);
load_complete.Wait();
EXPECT_EQ(contents()->GetLastCommittedURL(), landing_url());
diff --git a/browser/ipfs/ipfs_tab_helper.cc b/browser/ipfs/ipfs_tab_helper.cc
index 853b7d8b6250..bb55fb20c35f 100644
--- a/browser/ipfs/ipfs_tab_helper.cc
+++ b/browser/ipfs/ipfs_tab_helper.cc
@@ -152,8 +152,8 @@ void IPFSTabHelper::ResolveIPFSLink() {
auto resolved_callback = base::BindOnce(&IPFSTabHelper::HostResolvedCallback,
weak_ptr_factory_.GetWeakPtr());
const auto& key =
- web_contents()->GetMainFrame()
- ? web_contents()->GetMainFrame()->GetNetworkIsolationKey()
+ web_contents()->GetPrimaryMainFrame()
+ ? web_contents()->GetPrimaryMainFrame()->GetNetworkIsolationKey()
: net::NetworkIsolationKey();
resolver_->Resolve(host_port_pair, key, net::DnsQueryType::TXT,
std::move(resolved_callback));
diff --git a/browser/ipfs/test/ipfs_navigation_throttle_browsertest.cc b/browser/ipfs/test/ipfs_navigation_throttle_browsertest.cc
index d9fd9cef3833..a434369f4db7 100644
--- a/browser/ipfs/test/ipfs_navigation_throttle_browsertest.cc
+++ b/browser/ipfs/test/ipfs_navigation_throttle_browsertest.cc
@@ -180,7 +180,7 @@ IN_PROC_BROWSER_TEST_F(IpfsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSNotConnectedPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
@@ -196,7 +196,7 @@ IN_PROC_BROWSER_TEST_F(IpfsNavigationThrottleBrowserTest,
// time without interstitials.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), ipfs_url()));
web_contents = browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(nullptr, GetInterstitialType(web_contents));
EXPECT_EQ(gateway_url(), web_contents->GetURL());
}
@@ -215,7 +215,7 @@ IN_PROC_BROWSER_TEST_F(IpfsNavigationThrottleBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(nullptr, GetInterstitialType(web_contents));
}
diff --git a/browser/ipfs/test/ipfs_not_connected_page_browsertest.cc b/browser/ipfs/test/ipfs_not_connected_page_browsertest.cc
index e1a75277a77b..ae5c6bfd7019 100644
--- a/browser/ipfs/test/ipfs_not_connected_page_browsertest.cc
+++ b/browser/ipfs/test/ipfs_not_connected_page_browsertest.cc
@@ -145,7 +145,7 @@ IN_PROC_BROWSER_TEST_F(IpfsNotConnectedPageBrowserTest,
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSNotConnectedPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
@@ -159,7 +159,7 @@ IN_PROC_BROWSER_TEST_F(IpfsNotConnectedPageBrowserTest,
// time without interstitials.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), ipfs_url()));
web_contents = browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(nullptr, GetInterstitialType(web_contents));
EXPECT_EQ(gateway_url(), web_contents->GetURL());
}
diff --git a/browser/ipfs/test/ipfs_onboarding_page_browsertest.cc b/browser/ipfs/test/ipfs_onboarding_page_browsertest.cc
index 562b1a670bcf..fd4a590ea333 100644
--- a/browser/ipfs/test/ipfs_onboarding_page_browsertest.cc
+++ b/browser/ipfs/test/ipfs_onboarding_page_browsertest.cc
@@ -172,7 +172,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, ShowAndUseLocalNode) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSOnboardingPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
@@ -188,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, ShowAndUseLocalNode) {
// time without interstitials.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), ipfs_url()));
web_contents = browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(nullptr, GetInterstitialType(web_contents));
EXPECT_EQ(resolved_url, web_contents->GetURL());
}
@@ -207,7 +207,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, ShowAndUseGateway) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSOnboardingPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
@@ -222,7 +222,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, ShowAndUseGateway) {
// time without interstitials.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), ipfs_url()));
web_contents = browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(nullptr, GetInterstitialType(web_contents));
EXPECT_EQ(gateway_url(), web_contents->GetURL());
}
@@ -241,7 +241,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, LearnMore) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSOnboardingPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
@@ -270,7 +270,7 @@ IN_PROC_BROWSER_TEST_F(IpfsOnboardingPageBrowserTest, OpenSettings) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetMainFrame()));
+ EXPECT_TRUE(WaitForRenderFrameReady(web_contents->GetPrimaryMainFrame()));
EXPECT_EQ(IPFSOnboardingPage::kTypeForTesting,
GetInterstitialType(web_contents));
EXPECT_FALSE(GetPrefs()->GetBoolean(kIPFSAutoFallbackToGateway));
diff --git a/browser/ipfs/test/ipfs_service_browsertest.cc b/browser/ipfs/test/ipfs_service_browsertest.cc
index 5340f920d412..402c131efd4f 100644
--- a/browser/ipfs/test/ipfs_service_browsertest.cc
+++ b/browser/ipfs/test/ipfs_service_browsertest.cc
@@ -870,7 +870,7 @@ IN_PROC_BROWSER_TEST_F(IpfsServiceBrowserTest,
int child_index = 0;
while (auto* child_frame =
- ChildFrameAt(contents->GetMainFrame(), child_index++)) {
+ ChildFrameAt(contents->GetPrimaryMainFrame(), child_index++)) {
auto location =
EvalJs(child_frame,
"const timer = setInterval(function () {"
@@ -903,7 +903,7 @@ IN_PROC_BROWSER_TEST_F(IpfsServiceBrowserTest, CannotLoadIframeFromHTTP) {
int child_index = 0;
while (auto* child_frame =
- ChildFrameAt(contents->GetMainFrame(), child_index++)) {
+ ChildFrameAt(contents->GetPrimaryMainFrame(), child_index++)) {
auto location =
EvalJs(child_frame,
"const timer = setInterval(function () {"
@@ -938,7 +938,7 @@ IN_PROC_BROWSER_TEST_F(IpfsServiceBrowserTest,
int child_index = 0;
while (auto* child_frame =
- ChildFrameAt(contents->GetMainFrame(), child_index++)) {
+ ChildFrameAt(contents->GetPrimaryMainFrame(), child_index++)) {
auto location =
EvalJs(child_frame,
"const timer = setInterval(function () {"
@@ -992,10 +992,11 @@ IN_PROC_BROWSER_TEST_F(IpfsServiceBrowserTest, CanLoadIFrameFromIPFS) {
contents->GetLastCommittedURL(),
ipfs::GetIPFSGatewayURL("Qmc2JTQo4iXf24g98otZmGFQq176eQ2Cdbb88qA5ToMEvC",
"simple_content", GetDefaultIPFSGateway(prefs)));
- EXPECT_EQ(ChildFrameAt(contents->GetMainFrame(), 0)->GetLastCommittedURL(),
- ipfs::GetIPFSGatewayURL(
- "Qmc2JTQo4iXf24g98otZmGFQq176eQ2Cdbb88qA5ToMEvC",
- "simple_content_2", GetDefaultIPFSGateway(prefs)));
+ EXPECT_EQ(
+ ChildFrameAt(contents->GetPrimaryMainFrame(), 0)->GetLastCommittedURL(),
+ ipfs::GetIPFSGatewayURL("Qmc2JTQo4iXf24g98otZmGFQq176eQ2Cdbb88qA5ToMEvC",
+ "simple_content_2",
+ GetDefaultIPFSGateway(prefs)));
}
// Make sure an can load within another ipfs:// scheme
diff --git a/browser/net/brave_network_delegate_browsertest.cc b/browser/net/brave_network_delegate_browsertest.cc
index f6748cd42c63..a93de1b2fc26 100644
--- a/browser/net/brave_network_delegate_browsertest.cc
+++ b/browser/net/brave_network_delegate_browsertest.cc
@@ -335,7 +335,7 @@ IN_PROC_BROWSER_TEST_F(BraveNetworkDelegateBrowserTest,
"nested_iframe");
content::RenderFrameHost* child_frame =
- content::ChildFrameAt(web_contents->GetMainFrame(), 0);
+ content::ChildFrameAt(web_contents->GetPrimaryMainFrame(), 0);
NavigateRenderFrameToURL(child_frame, "iframe_cookie",
subdomain_first_party_cookie_url_);
diff --git a/browser/net/brave_site_hacks_network_delegate_helper_browsertest.cc b/browser/net/brave_site_hacks_network_delegate_helper_browsertest.cc
index 32f688d3374c..a6ea8b93e1bf 100644
--- a/browser/net/brave_site_hacks_network_delegate_helper_browsertest.cc
+++ b/browser/net/brave_site_hacks_network_delegate_helper_browsertest.cc
@@ -190,7 +190,8 @@ class BraveSiteHacksNetworkDelegateBrowserTest : public InProcessBrowserTest {
ui_test_utils::UrlLoadObserver load_complete(
landing_url, content::NotificationService::AllSources());
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), original_url));
- EXPECT_EQ(contents()->GetMainFrame()->GetLastCommittedURL(), original_url);
+ EXPECT_EQ(contents()->GetPrimaryMainFrame()->GetLastCommittedURL(),
+ original_url);
load_complete.Wait();
EXPECT_EQ(contents()->GetLastCommittedURL(), landing_url);
diff --git a/browser/net/global_privacy_control_network_delegate_helper_browsertest.cc b/browser/net/global_privacy_control_network_delegate_helper_browsertest.cc
index ae1aae56f1c9..7b7148200172 100644
--- a/browser/net/global_privacy_control_network_delegate_helper_browsertest.cc
+++ b/browser/net/global_privacy_control_network_delegate_helper_browsertest.cc
@@ -85,8 +85,10 @@ IN_PROC_BROWSER_TEST_F(GlobalPrivacyControlNetworkDelegateBrowserTest,
const GURL target = https_server().GetURL("a.test", "/index.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), target));
- auto* rfh =
- browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame();
+ auto* rfh = browser()
+ ->tab_strip_model()
+ ->GetActiveWebContents()
+ ->GetPrimaryMainFrame();
EXPECT_EQ(true, content::EvalJs(rfh, "navigator.globalPrivacyControl"));
EXPECT_EQ(true, content::EvalJs(rfh,
diff --git a/browser/net/ipfs_redirect_network_delegate_helper_browsertest.cc b/browser/net/ipfs_redirect_network_delegate_helper_browsertest.cc
index 457647cf218b..8be51d479c96 100644
--- a/browser/net/ipfs_redirect_network_delegate_helper_browsertest.cc
+++ b/browser/net/ipfs_redirect_network_delegate_helper_browsertest.cc
@@ -88,7 +88,7 @@ IN_PROC_BROWSER_TEST_F(IpfsRedirectNetworkDelegateHelperBrowserTest,
// Try to navigate to the url. The navigation should be canceled and the
// NavigationHandle should have the right error code.
EXPECT_TRUE(ui_test_utils::NavigateToURL(private_browser, ipfs_url()));
- EXPECT_TRUE(private_wc->GetMainFrame()->IsErrorDocument());
+ EXPECT_TRUE(private_wc->GetPrimaryMainFrame()->IsErrorDocument());
EXPECT_EQ(net::ERR_INCOGNITO_IPFS_NOT_ALLOWED, observer.net_error_code());
}
@@ -108,7 +108,7 @@ IN_PROC_BROWSER_TEST_F(IpfsRedirectNetworkDelegateHelperBrowserTest,
// Try to navigate to the url. The navigation should be canceled and the
// NavigationHandle should have the right error code.
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), ipfs_url()));
- EXPECT_TRUE(wc->GetMainFrame()->IsErrorDocument());
+ EXPECT_TRUE(wc->GetPrimaryMainFrame()->IsErrorDocument());
EXPECT_EQ(net::ERR_IPFS_DISABLED, observer.net_error_code());
}
diff --git a/browser/permissions/brave_wallet_permission_context_browsertest.cc b/browser/permissions/brave_wallet_permission_context_browsertest.cc
index 4c8850405965..4d582eac393e 100644
--- a/browser/permissions/brave_wallet_permission_context_browsertest.cc
+++ b/browser/permissions/brave_wallet_permission_context_browsertest.cc
@@ -122,8 +122,8 @@ IN_PROC_BROWSER_TEST_F(BraveWalletPermissionContextBrowserTest,
// No allowed accounts before setting permissions.
BraveWalletPermissionContext::GetAllowedAccounts(
- blink::PermissionType::BRAVE_ETHEREUM, web_contents()->GetMainFrame(),
- addresses,
+ blink::PermissionType::BRAVE_ETHEREUM,
+ web_contents()->GetPrimaryMainFrame(), addresses,
base::BindOnce(&OnGetAllowedAccountsResult, &was_called, true,
std::vector()));
@@ -145,8 +145,8 @@ IN_PROC_BROWSER_TEST_F(BraveWalletPermissionContextBrowserTest,
ContentSetting::CONTENT_SETTING_ALLOW);
}
BraveWalletPermissionContext::GetAllowedAccounts(
- blink::PermissionType::BRAVE_ETHEREUM, web_contents()->GetMainFrame(),
- addresses,
+ blink::PermissionType::BRAVE_ETHEREUM,
+ web_contents()->GetPrimaryMainFrame(), addresses,
base::BindOnce(&OnGetAllowedAccountsResult, &was_called, true,
expected_allowed_accounts));
content::RunAllTasksUntilIdle();
diff --git a/browser/permissions/permission_lifetime_manager_browsertest.cc b/browser/permissions/permission_lifetime_manager_browsertest.cc
index b9d56c087909..02b070456d2b 100644
--- a/browser/permissions/permission_lifetime_manager_browsertest.cc
+++ b/browser/permissions/permission_lifetime_manager_browsertest.cc
@@ -114,7 +114,7 @@ class PermissionLifetimeManagerBrowserTest : public InProcessBrowserTest {
}
content::RenderFrameHost* GetActiveMainFrame() {
- return active_web_contents()->GetMainFrame();
+ return active_web_contents()->GetPrimaryMainFrame();
}
void ReadPreTestData() {
diff --git a/browser/permissions/permission_manager_browsertest.cc b/browser/permissions/permission_manager_browsertest.cc
index d87c0c223187..8bf94559e8a6 100644
--- a/browser/permissions/permission_manager_browsertest.cc
+++ b/browser/permissions/permission_manager_browsertest.cc
@@ -169,8 +169,8 @@ IN_PROC_BROWSER_TEST_F(PermissionManagerBrowserTest, RequestPermissions) {
permission_request_manager);
permission_manager()->RequestPermissionsForOrigin(
- permissions, web_contents()->GetMainFrame(), origin.GetURL(), true,
- base::DoNothing());
+ permissions, web_contents()->GetPrimaryMainFrame(), origin.GetURL(),
+ true, base::DoNothing());
content::RunAllTasksUntilIdle();
@@ -206,8 +206,8 @@ IN_PROC_BROWSER_TEST_F(PermissionManagerBrowserTest, RequestPermissions) {
observer->Reset();
permission_manager()->RequestPermissionsForOrigin(
- permissions, web_contents()->GetMainFrame(), origin.GetURL(), true,
- base::DoNothing());
+ permissions, web_contents()->GetPrimaryMainFrame(), origin.GetURL(),
+ true, base::DoNothing());
content::RunAllTasksUntilIdle();
EXPECT_TRUE(permission_request_manager->IsRequestInProgress())
@@ -296,8 +296,8 @@ IN_PROC_BROWSER_TEST_F(PermissionManagerBrowserTest,
permission_request_manager);
permission_manager()->RequestPermissionsForOrigin(
- permissions, web_contents()->GetMainFrame(), origin.GetURL(), true,
- base::DoNothing());
+ permissions, web_contents()->GetPrimaryMainFrame(), origin.GetURL(),
+ true, base::DoNothing());
content::RunAllTasksUntilIdle();
diff --git a/browser/renderer_context_menu/brave_mock_render_view_context_menu.cc b/browser/renderer_context_menu/brave_mock_render_view_context_menu.cc
index 335183f6c431..ba4bc740e49c 100644
--- a/browser/renderer_context_menu/brave_mock_render_view_context_menu.cc
+++ b/browser/renderer_context_menu/brave_mock_render_view_context_menu.cc
@@ -133,7 +133,7 @@ void BraveMockRenderViewContextMenu::AddSubMenu(int command_id,
item.has_submenu = true;
items_.push_back(item);
- for (int i = 0; i < model->GetItemCount(); ++i) {
+ for (size_t i = 0; i < model->GetItemCount(); ++i) {
MockMenuItem sub_item;
sub_item.is_submenu = true;
if (model->GetTypeAt(i) != ui::MenuModel::TYPE_SEPARATOR) {
diff --git a/browser/renderer_context_menu/brave_spelling_menu_observer_browsertest.cc b/browser/renderer_context_menu/brave_spelling_menu_observer_browsertest.cc
index 55d0f4147696..5b191aa2c5f1 100644
--- a/browser/renderer_context_menu/brave_spelling_menu_observer_browsertest.cc
+++ b/browser/renderer_context_menu/brave_spelling_menu_observer_browsertest.cc
@@ -14,6 +14,7 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "components/prefs/pref_service.h"
#include "components/spellcheck/browser/pref_names.h"
+#include "components/spellcheck/common/spellcheck_features.h"
#include "content/public/browser/context_menu_params.h"
#include "content/public/test/browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -73,9 +74,20 @@ class BraveSpellingMenuObserverTest : public InProcessBrowserTest {
private:
std::unique_ptr observer_;
std::unique_ptr menu_;
+
+#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
+ base::test::ScopedFeatureList feature_list_;
+#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
};
+#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
+BraveSpellingMenuObserverTest::BraveSpellingMenuObserverTest() {
+ feature_list_.InitAndDisableFeature(
+ spellcheck::kWinDelaySpellcheckServiceInit);
+}
+#else
BraveSpellingMenuObserverTest::BraveSpellingMenuObserverTest() = default;
+#endif
BraveSpellingMenuObserverTest::~BraveSpellingMenuObserverTest() = default;
diff --git a/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc b/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc
index b4b0bf2b6d4b..b4e26ddf3fd2 100644
--- a/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc
+++ b/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc
@@ -27,9 +27,9 @@ void BraveSpellingOptionsSubMenuObserver::InitMenu(
// 2. We overrode RenderViewContextMenu::AddSpellCheckServiceItem so that the
// spelling suggestions toggle isn't added to the menu by the base class.
DCHECK(!use_spelling_service_.GetValue());
- DCHECK_EQ(
- submenu_model_.GetIndexOfCommandId(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE),
- -1);
+ DCHECK(
+ !submenu_model_.GetIndexOfCommandId(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE)
+ .has_value());
// Check if we ended up with a separator as the last item and, if so, get rid
// of it.
diff --git a/browser/resources/settings/brave_appearance_page/BUILD.gn b/browser/resources/settings/brave_appearance_page/BUILD.gn
index 7146452789a6..45c05547a955 100644
--- a/browser/resources/settings/brave_appearance_page/BUILD.gn
+++ b/browser/resources/settings/brave_appearance_page/BUILD.gn
@@ -32,7 +32,6 @@ js_library("brave_appearance_browser_proxy") {
js_library("brave_theme") {
deps = [
":brave_appearance_browser_proxy",
- "//chrome/browser/resources/settings:router",
"//ui/webui/resources/js:cr.m",
"//ui/webui/resources/js:load_time_data.m",
"//ui/webui/resources/js:web_ui_listener_behavior.m",
@@ -43,7 +42,6 @@ js_library("brave_theme") {
js_library("super_referral") {
deps = [
- "//chrome/browser/resources/settings:router",
"//ui/webui/resources/js:cr.m",
"//ui/webui/resources/js:i18n_behavior.m",
"//ui/webui/resources/js:load_time_data.m",
diff --git a/browser/resources/settings/brave_appearance_page/brave_theme.html b/browser/resources/settings/brave_appearance_page/brave_theme.html
index 3cb652a2ca31..e8fa0a210430 100644
--- a/browser/resources/settings/brave_appearance_page/brave_theme.html
+++ b/browser/resources/settings/brave_appearance_page/brave_theme.html
@@ -13,7 +13,7 @@
-
diff --git a/browser/resources/settings/brave_appearance_page/brave_theme.js b/browser/resources/settings/brave_appearance_page/brave_theme.js
index 3c733863d86a..f72ca4188695 100644
--- a/browser/resources/settings/brave_appearance_page/brave_theme.js
+++ b/browser/resources/settings/brave_appearance_page/brave_theme.js
@@ -8,7 +8,7 @@ import {WebUIListenerBehavior} from 'chrome://resources/js/web_ui_listener_behav
import {routes} from '../route.js';
import {Router} from '../router.js';
import 'chrome://resources/cr_elements/md_select_css.m.js';
-import '../settings_shared_css.js';
+import '../settings_shared.css.js';
import '../settings_vars.css.js';
import {loadTimeData} from "../i18n_setup.js"
import {BraveAppearanceBrowserProxy, BraveAppearanceBrowserProxyImpl} from './brave_appearance_browser_proxy.js';
diff --git a/browser/resources/settings/brave_appearance_page/sidebar.js b/browser/resources/settings/brave_appearance_page/sidebar.js
index ad6b19585a38..1a924c004ad2 100644
--- a/browser/resources/settings/brave_appearance_page/sidebar.js
+++ b/browser/resources/settings/brave_appearance_page/sidebar.js
@@ -4,7 +4,7 @@
// you can obtain one at http://mozilla.org/MPL/2.0/.
import {Polymer, html} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
-import '../settings_shared_css.js';
+import '../settings_shared.css.js';
import '../settings_vars.css.js';
import {I18nBehavior} from 'chrome://resources/js/i18n_behavior.m.js'
diff --git a/browser/resources/settings/brave_appearance_page/toolbar.js b/browser/resources/settings/brave_appearance_page/toolbar.js
index 47789bebd348..c57c1d028ca8 100644
--- a/browser/resources/settings/brave_appearance_page/toolbar.js
+++ b/browser/resources/settings/brave_appearance_page/toolbar.js
@@ -5,7 +5,7 @@
import {Polymer, html} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
import {loadTimeData} from "../i18n_setup.js"
-import '../settings_shared_css.js';
+import '../settings_shared.css.js';
import '../settings_vars.css.js';
import { I18nBehavior } from 'chrome://resources/js/i18n_behavior.m.js'
diff --git a/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_on_exit_page.js b/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_on_exit_page.js
index 75e57bdc5512..be00f3ef8ebc 100644
--- a/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_on_exit_page.js
+++ b/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_on_exit_page.js
@@ -4,7 +4,7 @@
// you can obtain one at http://mozilla.org/MPL/2.0/.
import 'chrome://resources/cr_elements/shared_vars_css.m.js';
-import '../settings_shared_css.js';
+import '../settings_shared.css.js';
import '../settings_vars.css.js';
import '../controls/settings_checkbox.js';
diff --git a/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html b/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html
index 6c209deb42a7..6e479780a7dc 100644
--- a/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html
+++ b/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html
@@ -5,7 +5,7 @@
-
+
diff --git a/browser/resources/settings/brave_help_tips_page/brave_help_tips_page.html b/browser/resources/settings/brave_help_tips_page/brave_help_tips_page.html
index bfdd12c6e00b..b4dc1ec742e3 100644
--- a/browser/resources/settings/brave_help_tips_page/brave_help_tips_page.html
+++ b/browser/resources/settings/brave_help_tips_page/brave_help_tips_page.html
@@ -1,3 +1,4 @@
+
-
-
diff --git a/browser/resources/settings/brave_ipfs_page/add_ipfs_peer_dialog.html b/browser/resources/settings/brave_ipfs_page/add_ipfs_peer_dialog.html
index 378b70a8d98f..a351ea12277c 100644
--- a/browser/resources/settings/brave_ipfs_page/add_ipfs_peer_dialog.html
+++ b/browser/resources/settings/brave_ipfs_page/add_ipfs_peer_dialog.html
@@ -1,5 +1,5 @@
-
+