Skip to content

Commit

Permalink
[Android] Fix for unit tests II
Browse files Browse the repository at this point in the history
Chromium change:
https://chromium.googlesource.com/chromium/src/+/a65f80f87cc151be897131164e015d37bea1d155

[ToolbarMVC] Remove direct MenuButton interactions from Tabswitcher

This only requires giving TabSwitcherModeTTCoordinatorPhone a
MenuButtonCoordinator and setting the MenuButton view once inflation happens.
The logic removed (tinting, setting the onClick/accessibilityDelegate)
is now handled internally by MenuButtonCoordinator/MenuButton.

Bug: 1086676
  • Loading branch information
samartnik committed Oct 9, 2020
1 parent 1deb9a2 commit 1a01ca1
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ public BraveTabSwitcherModeTTPhoneClassAdapter(ClassVisitor visitor) {
deleteField(sBraveTabSwitcherModeTTPhoneClassName, "mToggleTabStackButton");
makeProtectedField(sTabSwitcherModeTTPhoneClassName, "mToggleTabStackButton");

deleteField(sBraveTabSwitcherModeTTPhoneClassName, "mMenuButton");
makeProtectedField(sTabSwitcherModeTTPhoneClassName, "mMenuButton");

deleteField(sBraveTabSwitcherModeTTPhoneClassName, "mShouldShowNewTabVariation");
makeProtectedField(sTabSwitcherModeTTPhoneClassName, "mShouldShowNewTabVariation");

Expand Down

0 comments on commit 1a01ca1

Please sign in to comment.