Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video doesn't get added to blocked list when prompt is closed #862

Closed
srirambv opened this issue Aug 28, 2018 · 2 comments
Closed

Video doesn't get added to blocked list when prompt is closed #862

srirambv opened this issue Aug 28, 2018 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Video doesn't get added to blocked list when prompt is closed

Steps to Reproduce

  1. Clean profile on 0.54.2
  2. Open YouTube and play a video
  3. Autoplay prompt shows up when video is loaded, ignore it and click the play button, video starts to play
  4. Close the autoplay notification prompt, shows added to block list
  5. Open Setting->Advanced->Privacy->Content Settings->Autoplay no exception added to block list
  6. Click on Autoplay button in YouTube tab, balloon notification shows Continue blocking video

Actual result:

autoplay

Expected result:

Should not play video until user clicks deny or allow in the autoplay balloon to make a choice. If user clicks Allow should autoplay, If user click block it should be click to play

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Reproducible on current release:

No. b-l does what the setting says

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa to verify on other platforms as well

@LaurenWags
Copy link
Member

Reproduces on macOS using 0.54.2 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}

@srirambv srirambv modified the milestones: Releasable builds 0.55.x, Backlog Aug 29, 2018
@darkdh
Copy link
Member

darkdh commented Sep 7, 2018

This is expected for all content setting. If you click prompt, nothing will be added to the block list. It just blocked it this time.
You can try other content settings which is default ask like notification or geolocation

@darkdh darkdh closed this as completed Sep 7, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid Sep 9, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants