Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay follow up #699

Open
darkdh opened this issue Aug 7, 2018 · 6 comments
Open

Autoplay follow up #699

darkdh opened this issue Aug 7, 2018 · 6 comments
Assignees

Comments

@darkdh
Copy link
Member

darkdh commented Aug 7, 2018

  1. play() video instead of reload when user click "Allow" from permission bubble (suggested by @bbondy)
  2. Merge autoplay and sound into one site setting (suggested by @bridiver)
  3. Add "allow muted video" option tracked in (Allow block audio only for autoplay, and make that the default #1088)
  4. Improve patch of chrome/browser/content_settings/tab_specific_content_settings.cc
  5. Default allow rules for popular sites tracked in (Whitelist some sites to not block autoplay by default #1089)
  6. Handle cases like users specify different autoplay policy in about:flag (we currently use User gesture required as default but we respect users choices)
  7. autoplay icon (cc @bradleyrichter)
@tildelowengrimm
Copy link
Contributor

Is default-allow for popular sites the right move?

@darkdh
Copy link
Member Author

darkdh commented Aug 13, 2018

you can check Safari to see this whitelist behavior

@bridiver
Copy link
Contributor

@tomlowenthal that's what we do now so this is just for feature parity

@tildelowengrimm
Copy link
Contributor

Okay, but what if we did this instead and it was beautiful: https://twitter.com/potch/status/1024406683940843521

djdsyo3v4aay2va

@darkdh
Copy link
Member Author

darkdh commented Aug 14, 2018

We already have this. Did you try 0.53.3 brave-browser?

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Aug 14, 2018

Just did. Sorry for the hassle!

@bbondy bbondy added this to the Backlog milestone Aug 16, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants