Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Shields UX to indicate when blocking might be breaking a site #5307

Open
tildelowengrimm opened this issue Jul 20, 2019 · 1 comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P4 Planned work. We expect to get to it "soon".

Comments

@tildelowengrimm
Copy link
Contributor

From #1025.

I think there are two parts to this:
Design the UX: Should this be like the autoplay blocked UI? Should it match Chromium's site-settings blocking icon format?
Tune the Behavior: Should this happen every time device recognition or cookies or something else is blocked? That presents an over-notification and annoyance risk. Should we use some heuristic to estimate when it might be causing problems? What heuristic?

@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P4 Planned work. We expect to get to it "soon". needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature/shields/panel Front-end design and functionality of the Shields panel. labels Jul 20, 2019
@NumDeP
Copy link

NumDeP commented Oct 9, 2019

1 - When you're on a site which is breaking because of Shields, you sometimes feel like you're looking at where's wally until you realise there's a problem and you don't know what aspect is actually blocking the site from functioning effectively and unfortunately have to turn off Shields and let everything in just to get it running as intended, when it might just be one blocked thing causing the issue.
For a browser that's suppose to save time and presents that visually, this process usually wastes a lot of time. That's not a dig at the team but just my opinion that it would be wicked if you could moved it up a notch to P3 :)

2 - Wouldn't it help the team if we were to use this issue to list all the sites that are not currently/properly functional with Shields on, this way you could improve Shield's blocking feature and improve the UX of this feature?

3 - As for the behaviour, I don't know what exactly it was but something from the team during the development of the Muon version gave me the impression that something clever would happen behind the scenes of Brave's engine, that would essentially allow users to easily access a website without any hassle which is prohibiting a user to effectively peruse it and not to forget, sites that also have anti-ad blocking mechanisms that don't allow users to access articles. Was I wrong to think this?

4 - I think it would be good to have this discussion in connection with #4246 & #1926 as it relates to onboarding and how it could be bothersome for new users and possibly integrate the UX, understandably with different text.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

2 participants