Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide tipping banner when clicking outside of it and after a few seconds #4607

Closed
agentofuser opened this issue May 25, 2019 · 2 comments
Closed
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@agentofuser
Copy link

Description

After tipping someone, the (very large) banner stays visible, and I have to click on a very small target to make it go away.

Steps to Reproduce

  1. Tip someone
  2. Try to hide/close the banner

Actual result:

Banner stays on top unless you click small "x" on the top right corner.

Expected result:

  • Clicking outside should hide it.
  • Pressing Esc or Enter should hide it.
  • It should close itself after a few seconds. (I can always check the Rewards screen.)

Reproduces how often:

Every time.

Brave version (brave://version info)

0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision | 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS | Mac OS X

Version/Channel Information:

All channels.

  • Can you reproduce this issue with the current release?
    Don't know.
  • Can you reproduce this issue with the beta channel?
    Don't know.
  • Can you reproduce this issue with the dev channel?
    Partially. The banner auto closes after a few seconds. Esc also makes it go away. (Enter doesn't.) Clicking outside doesn't hide it.
  • Can you reproduce this issue with the nightly channel?
    Yes.
@srirambv
Copy link
Contributor

Assuming this is on twitter tip banner since you mentioned nightly only so its a duplicate of #4590. More discussion there.

@agentofuser
Copy link
Author

@srirambv I tested this on a regular website too and had the same result.

@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels May 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants