Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing flag for Israel on VPN #44093

Closed
2 of 6 tasks
srirambv opened this issue Feb 19, 2025 · 4 comments · Fixed by brave/brave-core#27734
Closed
2 of 6 tasks

Missing flag for Israel on VPN #44093

srirambv opened this issue Feb 19, 2025 · 4 comments · Fixed by brave/brave-core#27734
Assignees
@fallaciousreasoning
Labels
bug feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.75.x - Release #5

Comments

@srirambv
Copy link
Contributor

Description

Missing flag for Israel on VPN

Steps to reproduce

  1. Open VPN panel
  2. Israel doesn't show flag icon

Actual result

Image

Expected result

Show icon for all countries

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.77.42 Chromium: 133.0.6943.98 (Official Build) nightly (64-bit)
Revision ef1581a73961ebbbd5165036f13d6fb388737c59
OS Windows 11 Version 24H2 (Build 26100.2894)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @aguscruiz @simonhong @fallaciousreasoning
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 19, 2025
@fallaciousreasoning fallaciousreasoning self-assigned this Feb 19, 2025
@fallaciousreasoning fallaciousreasoning mentioned this issue Feb 19, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 20, 2025
@kjozwiak
Copy link
Member

@fallaciousreasoning sounds like the above affects 1.76.x as well. Mind creating an uplift? Small change which won't require much QA effort so probably worth uplifting.

This was referenced Feb 21, 2025
Merged
Merged
@simonhong
Copy link
Member

@fallaciousreasoning sounds like the above affects 1.76.x as well. Mind creating an uplift? Small change which won't require much QA effort so probably worth uplifting.

Created https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1740120358646509

@LaurenWags
Copy link
Member

Requires 1.75.181 or higher for verification 👍🏻

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.75.181 Chromium: 133.0.6943.141 (Official Build) (64-bit)
-- | --
Revision | a562c054c7c8c395c9a417781852d8ec3e0b96f5
OS | Windows 10 Version 22H2 (Build 19045.5555)

Image

@LaurenWags LaurenWags mentioned this issue Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
bug feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.75.x - Release #5
Development

Successfully merging a pull request may close this issue.

[VPN] Add missing country-il icon brave/brave-core
8 participants
@mattmcalister @kjozwiak @simonhong @fallaciousreasoning @srirambv @LaurenWags @GeetaSarvadnya @brave-builds