Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dark theme customization we're adding on top of chromium #43289

Open
1 of 6 tasks
aguscruiz opened this issue Jan 14, 2025 · 0 comments
Open
1 of 6 tasks

Remove dark theme customization we're adding on top of chromium #43289

aguscruiz opened this issue Jan 14, 2025 · 0 comments
Assignees
@aguscruiz
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@aguscruiz
Copy link

aguscruiz commented Jan 14, 2025 •
edited
Loading

Description

The customized and darker default theme we have right now is causing some issues with contrast agains the color dark themes, so we want to explore removing that layer of customization we do here ui/color/brave_sys_color_mixer.cc

Image

Steps to reproduce

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@aguscruiz aguscruiz self-assigned this Jan 14, 2025
@aguscruiz aguscruiz added the design A design change, especially one which needs input from the design team label Jan 15, 2025
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jan 17, 2025
@rebron rebron moved this to In progress in Front End Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aguscruiz aguscruiz

Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Front End
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @aguscruiz