Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared pinned tab may not work after Chromium 125 #37973

Closed
Tracked by #28873
sangwoo108 opened this issue May 1, 2024 · 0 comments · Fixed by brave/brave-core#23429
Closed
Tracked by #28873

Shared pinned tab may not work after Chromium 125 #37973

sangwoo108 opened this issue May 1, 2024 · 0 comments · Fixed by brave/brave-core#23429
Assignees
@sangwoo108
Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.66.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented May 1, 2024 •
edited
Loading

Upstream removed a feature that was used by SharedPinnedTabService. Need to investigate how we can resurrect the feature.

brave/brave-core#22936 (comment)
@sangwoo108 sangwoo108 mentioned this issue May 1, 2024
Closed
@sangwoo108 sangwoo108 self-assigned this May 1, 2024
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No OS/Desktop release-notes/exclude feature/pinned-tabs labels May 1, 2024
This was referenced May 1, 2024
Merged
Merged
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 5, 2024
@mkarolin mkarolin mentioned this issue May 5, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Fix SharedPinnedTab functionality brave/brave-core
2 participants
@sangwoo108 @brave-builds