You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similarly, If I set the browser language as Marathi I get the metrics Brave.Core.PrimaryLang response value as 106 but the index value corresponds to Marathi language is 133 via brave-core/components/misc_metrics/language_metrics.cc
@GeetaSarvadnya You will want to refer to the actual index within kOrderedLangCodes, rather than the line number. If you'd like to use the line number, you could subtract 26 from the line number to get the index. If the language occurs after line 55, subtract 1 in addition to account for the comment on line 55.
Thanks @DJAndries !
Verified the issue again on Windows 10 x64 1.64.90 , comparing the actau langcodes matching with reponse value and browser language. It's working as expected
Description
Follow up of #34853 - The metric value index isn't matches the primary language set in the browser
Steps to Reproduce
Brave.Core.PrimaryLang
Brave.Core.PrimaryLang
is shown underlogs_constellation_prep_slow
andconstellation_logs_slow
blocksBrave.Core.PrimaryLang
value37
corresponds toAzerbaijani
but the primary language set at the browserEnglish (United States)
Actual result:
The metrics
Brave.Core.PrimaryLang
value37
corresponds toAzerbaijani
but the primary language set at the browserEnglish (United States)
Expected result:
The metric index value should match the primary language set in the browser
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @mattmcalister @DJAndries
The text was updated successfully, but these errors were encountered: