Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send tab to self menu location #34650

Open
AlexeyBarabash opened this issue Nov 30, 2023 · 1 comment
Open

Fix send tab to self menu location #34650

AlexeyBarabash opened this issue Nov 30, 2023 · 1 comment
Assignees
@AlexeyBarabash
Labels
feature/sync OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

Steps To Reproduce

  1. Join sync chain with some devices
  2. Open any url
  3. Open hamburger menu -> share -> send to devices

Menu is placed above the toolbar:
image

Expected to have menu from the bottom.
@AlexeyBarabash AlexeyBarabash added the OS/Android Fixes related to Android browser functionality label Nov 30, 2023
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 30, 2023
@AlexeyBarabash AlexeyBarabash mentioned this issue Nov 30, 2023
Merged
25 tasks
@kjozwiak kjozwiak added this to the 1.63.x - Nightly milestone Dec 1, 2023
@kjozwiak kjozwiak closed this as completed Dec 1, 2023
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Dec 1, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2023 •
edited
Loading

Re-opening. I thought the above was being addressed/fixed by brave/brave-core#21168 which isn't the case. The above will need to be fixed in a follow up PR. Thanks for getting an issue filed @AlexeyBarabash 👍

@kjozwiak kjozwiak reopened this Dec 1, 2023
@kjozwiak kjozwiak removed this from the 1.63.x - Nightly milestone Dec 1, 2023
@rebron rebron moved this to Untriaged backlog in Sync - All platforms Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude
Projects
Sync - All platforms
Status: Untriaged backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjozwiak @AlexeyBarabash