-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 120.0.6099.35 to Chromium 120.0.6099.56. #34648
Comments
The above will be uplifted into |
Quick overview of the work remaining re: affected areas due to Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #33471 (comment):
Platforms that still need to check/verify the affected areas due to
|
Verified with
Verifying desktop affected areas as listed via #33471 (comment): Tabs bar context menus look correctly (on a tab and on empty space) - PASSED
Note, no context menu for vertical tabs when right clicking on empty space in vertical tabs bar. This matches 1.60.125 with Chromium 119.
Side panel UI looks/functions correctly - PASSED
Power Bookmarks
In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55 Sync works - PASSED
Magnet URLs work - PASSED
Interstitial pages - PASSEDCase 1:
Case 2:
Case 3: Request OTR Steps:
Confirmed that
|
Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Case 4: Shields domain block interstitial
- Verified the test plan from First-party domain blocking #14134 (comment)
- Confirmed that interstitial-page warning message is shown when shields are set to "Aggressive" ad blocking mode
101com.com | 00px.net | zzhc.vnet.cn | 101order.com |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Verified with
Tabs bar context menus look correctly (on a tab and on empty space)
Side panel UI looks/functions correctly.
Power Bookmarks
In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55
Sync works
Magnet URLs work
Interstitial pages_InprogressCase 1:
Case 2:
Case 3: Request OTR Steps:
Confirmed that
|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
---|
Case 4: Shields domain block interstitial
- Verified the test plan from First-party domain blocking #14134 (comment)
- Confirmed that interstitial-page warning message is shown when shields are set to "Aggressive" ad blocking mode
101com.com | 00px.net | zzhc.vnet.cn | 101order.com |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Verification passed on
OffchainENS.mov |
Verified on
|
Labelling as |
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/120.0.6099.35..120.0.6099.56?pretty=fuller&n=10000
QA tests:
Additional checks:
The text was updated successfully, but these errors were encountered: