Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 120.0.6099.35 to Chromium 120.0.6099.56. #34648

Closed
mkarolin opened this issue Nov 30, 2023 · 9 comments · Fixed by brave/brave-core#21169
Closed

Upgrade from Chromium 120.0.6099.35 to Chromium 120.0.6099.56. #34648

mkarolin opened this issue Nov 30, 2023 · 9 comments · Fixed by brave/brave-core#21169

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/120.0.6099.35..120.0.6099.56?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2023

The above will be uplifted into 1.61.x via brave/brave-core#21135 hence not adding the required version for verification on 1.62.x.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2023

Quick overview of the work remaining re: affected areas due to C120 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #33471 (comment):

Platforms that still need to check/verify the affected areas due to C117 changes as per #33471 (comment).

  • macOS - affected areas still need to be checked/verified that they haven't regressed
  • Linux - affected areas still need to be checked/verified that they haven't regressed

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 4, 2023

Verification PASSED on

Brave | 1.61.94 Chromium: 120.0.6099.56 (Official Build) (64-bit)
-- | --
Revision | 72759647494f071d653f8a61465fadf5f361b06e
OS | Windows 10 Version 22H2 (Build 19045.3693)

image

@LaurenWags
Copy link
Member

LaurenWags commented Dec 4, 2023

Verified with

Brave | 1.61.94 Chromium: 120.0.6099.56 (Official Build) (x86_64)
-- | --
Revision | 72759647494f071d653f8a61465fadf5f361b06e
OS | macOS Version 13.6.1 (Build 22G313)

Verifying desktop affected areas as listed via #33471 (comment):

Tabs bar context menus look correctly (on a tab and on empty space) - PASSED
  • Confirmed that Tabs bar context menus are shown correctly, compared to 1.60.125 with Chromium 119
  • Spot checked Tabs bar context menu options for functionality

Note, no context menu for vertical tabs when right clicking on empty space in vertical tabs bar. This matches 1.60.125 with Chromium 119.

1.60.125 1.61.94
Screenshot 2023-12-04 at 9 04 01 AM Screenshot 2023-12-04 at 9 01 33 AM
Screenshot 2023-12-04 at 9 04 09 AM Screenshot 2023-12-04 at 9 01 43 AM
Screenshot 2023-12-04 at 9 04 18 AM Screenshot 2023-12-04 at 9 01 54 AM
Side panel UI looks/functions correctly - PASSED
  • Confirmed that the icons are aligned properly on the sidebar
  • Confirmed the icon's border padding on both sides is even
  • Confirmed the click on each icon functions correctly.

Power Bookmarks

  • Confirmed that imported bookmarks are shown under the sidepanel
  • Confirmed that bookmarks folder structure remained same in power bookmarks (note, differences re: Mobile and Other bookmarks as noted with Add search, sort, and editing features to the Bookmarks side panel #34021 (comment))
  • Confirmed that bookmarks can be opened in new tab/window/private window without any issues
  • Confirmed that the bookmarks folders or bookmarks can be edited/renamed
  • Confirmed that bookmarks or bookmarks folders can be moved into another bookmarks folders works as expected (need to use Edit/Move functionality, not drag and drop as noted verification notes referenced above)
  • Confirmed that bookmarks can be deleted without any issues
  • Confirmed that imported bookmarks can be opened without any issues

In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55

Sync works - PASSED
  • Verified the sync functionality in general it works fine without any issues
  • Confirmed the bookmarks synced across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are synced across all the devices in a sync chain
  • Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
  • Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • When 2 devices are in a sync chain, remove a device resets the sync chain
Magnet URLs work - PASSED
  • Confirmed that magnet links opens up the WebTorrent file
  • Confirmed that WebTorrent file can be downloaded
  • Confirmed that magnet links doesn't open in PT/TOR windows
Interstitial pages - PASSED

Case 1:

  1. Clean profile 1.61.x
  2. Open ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR in a new tab
  3. Confirmed that the Interstitial page opens up
  4. Click on the Use a Brave local IPFS node
  5. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
  6. Click on Use a public gateway
  7. Confirm that the IPFS page is opened https://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi.ipfs.dweb.link/
Example Example Example
Screenshot 2023-12-04 at 1 26 12 PM Screenshot 2023-12-04 at 1 27 03 PM Screenshot 2023-12-04 at 1 26 26 PM

Case 2:
Verified the test plan from brave/brave-core#6782 (comment)

Example Example Example Example Example
Screenshot 2023-12-04 at 1 30 54 PM Screenshot 2023-12-04 at 1 32 22 PM Screenshot 2023-12-04 at 1 32 45 PM Screenshot 2023-12-04 at 1 33 24 PM Screenshot 2023-12-04 at 1 33 34 PM

Case 3: Request OTR
Followed the test plan from #28750 (comment)

Steps:

  1. installed 1.61.x
  2. set brave://flags/#brave-request-otr-tab to Enabled
  3. visited a request-OTR enrolled site: loveisrespect.org
  4. confirmed that the “would you like OTR mode” interstitial appears
  5. clicked Proceed Off-The-Record to go into OTR mode
  6. confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode
  7. opened dev tools went into the console and ran this code: window.localStorage.braveQATest = true
  8. closed the OTR’ed site
  9. confirmed that the OTR’ed site was not included in your browsing history
  10. revisited loveisrespect.org, this time declining OTR mode
  11. opened the dev tools console and ran this in the console: console.log(window.localStorage.braveQATest)

Confirmed that undefined was returned

Example Example Example Example Example Example Example
Screenshot 2023-12-04 at 1 37 17 PM Screenshot 2023-12-04 at 1 37 37 PM Screenshot 2023-12-04 at 1 38 09 PM Screenshot 2023-12-04 at 1 38 59 PM Screenshot 2023-12-04 at 1 39 37 PM Screenshot 2023-12-04 at 1 40 05 PM Screenshot 2023-12-04 at 1 40 34 PM

Case 4: Shields domain block interstitial

101com.com 00px.net zzhc.vnet.cn 101order.com
Screenshot 2023-12-04 at 1 44 54 PM Screenshot 2023-12-04 at 1 45 08 PM Screenshot 2023-12-04 at 1 45 35 PM Screenshot 2023-12-04 at 1 45 49 PM

@btlechowski
Copy link

Verified with

Brave 1.61.94 Chromium: 120.0.6099.56 (Official Build) (64-bit)
Revision 72759647494f071d653f8a61465fadf5f361b06e
OS Linux
Tabs bar context menus look correctly (on a tab and on empty space)
  • Confirmed that Tabs bar context menus are shown correctly
  • Confirmed that Tabs bar context menus works fine
image image
Side panel UI looks/functions correctly.
  • Confirmed that the icons are aligned properly on the sidebar
  • Confirmed the icon's border padding on both sides is even
  • Confirmed the click on each icon functions correctly.

Power Bookmarks

  • Confirmed that imported bookmarks are shown under the sidepanel
  • Confirmed that bookmarks folder structure remained same in power bookmarks
  • Confirmed that bookmarks can be opened in new tab/window/private window without any issues
  • Confirmed that the bookmarks folders or bookmarks can be edited/renamed
  • Confirmed that bookmarks or bookmarks folders can be moved into another bookmarks folders works as expected
  • Confirmed that bookmarks can be delete without any issues
  • Confirmed that imported bookmarks can be opened without any issues

In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55

image image
Sync works
  • Verified the sync functionality in general it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks syched across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, hostory, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain

image

Magnet URLs work
  • Confirmed that magnet links opens up the WebTorrent file
  • Confirmed that WebTorrent file can be downloaded
  • Confirmed that magnet links doesn't open in PT/TOR windows
image image
Interstitial pages_Inprogress

Case 1:

  1. Clean profile 1.61.x
  2. Open ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR in a new tab
  3. Confirmed that the Interstitial page opens up
  4. Click on the Use a Brave local IPFS node
  5. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
  6. Click on Use a public gateway
  7. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
image image

Case 2:
Verified the test plan from brave/brave-core#6782 (comment)

image image image

Case 3: Request OTR
Followed the test plan from #28750 (comment)

Steps:

  1. installed `1.61.x
  2. set brave://flags/#brave-request-otr-tab to Enabled
  3. visited a request-OTR enrolled site: loveisrespect.org
  4. confirmed that the “would you like OTR mode” interstitial appears
  5. clicked Proceed Off-The-Record to go into OTR mode
  6. confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode
  7. opened dev tools went into the console and ran this code: window.localStorage.braveQATest = true
  8. closed the OTR’ed site
  9. confirmed that the OTR’ed site was not included in your browsing history
  10. revisited loveisrespect.org, this time declining OTR mode
  11. opened the dev tools console and ran this in the console: console.log(window.localStorage.braveQATest)

Confirmed that undefined was returned

image image image image image image

Case 4: Shields domain block interstitial

101com.com 00px.net zzhc.vnet.cn 101order.com
image image image image

@hffvld
Copy link
Contributor

hffvld commented Dec 4, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
Brave build: 1.61.94 
Chromium: 120.0.6099.56 (Official Build) (64-bit) 

1 2
1 2

@srirambv
Copy link
Contributor

srirambv commented Dec 5, 2023

Verification passed on

Brave 1.61.97 Chromium: 120.0.6099.56 (Official Build) (arm64)
Revision 06ca6e12ac1f53536386f61c923915da7d128e75
OS macOS Version 14.1.2 (Build 23B92)
  • Verified steps from https://github.com/brave/brave-browser/issues/24990#issuecomment-1296701139
OffchainENS.mov

@Uni-verse
Copy link
Contributor

Uni-verse commented Dec 5, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.61.94 Chromium: 120.0.6099.56 (Official Build) (64-bit) 
Revision	72759647494f071d653f8a61465fadf5f361b06e
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-12-04 at 12 05 22 PM Screenshot 2023-12-04 at 12 05 35 PM

@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2023

Labelling as QA/No & release-notes/exclude in favour of #34723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment