Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 119 to Chromium 120. #33471

Closed
mkarolin opened this issue Oct 6, 2023 · 6 comments · Fixed by brave/brave-core#20434
Closed

Upgrade from Chromium 119 to Chromium 120. #33471

mkarolin opened this issue Oct 6, 2023 · 6 comments · Fixed by brave/brave-core#20434
Assignees
Labels

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Oct 6, 2023

Upgrade from Chromium 119 to Chromium 120

https://chromium.googlesource.com/chromium/src/+log/119.0.6045.7..120.0.6048.1/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

iOS Affected areas:
TBD

Android Affected areas:

  • Send tab to other device (double check it works as intended)
  • Brave shields and privacy settings (double check no regression in this section)
  • Main app menu UI (double check there is no regression)
  • Sync (double check it generally works)
  • Home button (double check it works as expected)
  • Top toolbar (double check there are no excessive items)
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 28, 2023

Verification PASSED on

Brave | 1.62.86 Chromium: 120.0.6099.35 (Official Build) nightly (64-bit)
-- | --
Revision | f248c65a74007536fb36959f92fc01fcb752e5fc
OS | Windows 10 Version 22H2 (Build 19045.3693)
Tabs bar context menus look correctly (on a tab and on empty space)_PASSED
  • Confirmed that Tabs bar context menus are shown correctly
  • Confirmed that Tabs bar context menus works fine
Example Example
image image
Side panel UI looks/functions correctly._PASSED
  • Confirmed that the icons are aligned properly on the sidebar
  • Confirmed the icon's border padding on both sides is even
  • Confirmed the click on each icon functions correctly.

Power Bookmarks

  • Confirmed that imported bookmarks are shown under the sidepanel
  • Confirmed that bookmarks folder structure remained same in power bookmarks
  • Confirmed that bookmarks can be opened in new tab/window/private window without any issues
  • Confirmed that the bookmarks folders or bookmarks can be edited/renamed
  • Confirmed that bookmarks or bookmarks folders can be moved into another bookmarks folders works as expected
  • Confirmed that bookmarks can be delete without any issues
  • Confirmed that imported bookmarks can be opened without any issues

In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55

Sync works_PASSED
  • Verified the sync functionality in general it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks syched across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, hostory, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Magnet URLs work_PASSED
  • Confirmed that magnet links opens up the WebTorren file
  • Confirmed that WebTorren file can be downloaded
  • Confirmed that magnet links doesn't open in PT/TOR windows
Interstitial pages_Inprogress_PASSED

Case 1:

  1. Clean profile 1.62.90
  2. Open ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR in a new tab
  3. Confirmed that the Interstitial page opens up
  4. Click on the Use a Brave local IPFS node
  5. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
  6. Click on Use a public gateway
  7. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
Example Example
image (2) image

Case 2:
Verified the test plan from brave/brave-core#6782 (comment)

IPFS

Case 3: Request OTR
Followed the test plan from #28750 (comment)

Steps:

  1. installed `1.62.x
  2. set brave://flags/#brave-request-otr-tab to Enabled
  3. visited a request-OTR enrolled site: loveisrespect.org
  4. confirmed that the “would you like OTR mode” interstitial appears
  5. clicked Proceed Off-The-Record to go into OTR mode
  6. confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode
  7. opened dev tools went into the console and ran this code: window.localStorage.braveQATest = true
  8. closed the OTR’ed site
  9. confirmed that the OTR’ed site was not included in your browsing history
  10. revisited loveisrespect.org, this time declining OTR mode
  11. opened the dev tools console and ran this in the console: console.log(window.localStorage.braveQATest)

Confirmed that undefined was returned

Example Example Example Example Example Example Example Example Example
image image image image image image image image image

Case 4: Shields domain block interstitial

101com.com 00px.net zzhc.vnet.cn 101order.com
image image image image

Settings comparison

Components updater

  • No new components are added as part of CR 120
  • Components are updates successfully without any error
1.60.118 Chromium: 119.0.6045.163 1.62.87 Chromium: 120.0.6099.35
image image

@GeetaSarvadnya
Copy link

@srirambv The desktop affected area item Decentralized DNS (See test plan in https://github.com/brave/brave-browser/issues/24990#issuecomment-1296701139) is related to wallet could you verify the same on CR120 build? Thanks!

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.90 Chromium: 120.0.6099.35 (Official Build) nightly (64-bit)
Revision 276c6d1
OS Linux
  • Verified steps from https://github.com/brave/brave-browser/issues/24990#issuecomment-1296701139
33471.mp4

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using the following version:

Brave	1.62.86 Chromium: 120.0.6099.35 (Official Build) canary (32-bit) 
Revision	f248c65a74007536fb36959f92fc01fcb752e5fc
OS	Android 13; Build/TP1A.220624.014; 33; REL
Send to device
C119 C120
Screenshot 2023-11-30 at 5 53 53 PM Screenshot 2023-11-30 at 6 01 42 PM
Brave Shields and privacy settings
  • Ensured Brave shields and privacy settings have not regressed
  • Ensured users can set per site settings in Brave Shields
  • Ensured ads are blocked and users can disable shields
  • Ensured global settings effect webpages
C119 C120
Screenshot 2023-11-30 at 6 31 48 PM Screenshot 2023-11-30 at 6 38 13 PM
Main app menu UI
  • Ensured main app menu has not regressed
C119 C120
Screenshot 2023-11-30 at 6 20 50 PM Screenshot 2023-11-30 at 6 26 56 PM
Screenshot 2023-11-30 at 6 35 52 PM Screenshot 2023-11-30 at 6 36 33 PM
Sync
  • Ensured sync works on fresh and upgraded profile
  • Ensured starting sync chain and adding multiple devices works
  • Ensured joining with phrase and scanning works
  • Ensured data is synced
Example Example
Screenshot 2023-11-30 at 6 05 59 PM Screenshot 2023-11-30 at 6 06 21 PM
Home button
  • Ensured default home page is set to Brave's homepage
  • Ensured setting custom url for homepage will take user when they tap the home button in the toolbar
  • Ensured that users can set homepage back to Brave's homepage
  • Ensured homepage settings are retained on upgraded profile
Home set to Yahoo.com (Private) Home set to Yahoo.com Default Home set to brave homepage
Screenshot 2023-11-30 at 6 28 15 PM Screenshot 2023-11-30 at 6 28 24 PM Screenshot 2023-11-30 at 6 28 33 PM Screenshot 2023-11-30 at 6 29 33 PM
Top toolbar
  • Ensured top toolbar functionality has not regressed on Tablet.

@hffvld
Copy link
Contributor

hffvld commented Dec 1, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 U1B2.230922.013 release-keys
Brave build: 1.63.2 
Chromium: 120.0.6099.35 (Official Build) canary (64-bit) 

Send tab to other device (double check it works as intended)
1 2
1 2
1 2
Brave shields and privacy settings (double check no regression in this section)
  • Verified that Brave Shields & privacy settings are working. Checked some settings like Block trackers & ads, Upgrade connections to HTTPS, Clear data on exit, Block cookie consent noticesandLock Private tabs when you leave Brave`
1 2 3
1 2 3
1 2 3
Main app menu UI (double check there is no regression)
  • Verified that the main app menu UI is fine
  • Verified that sub-menus are working fine as well
  • Verified that enabling and disabling toggle switches is working
1 2 3
1 2 3
1 2 3
Sync (double check it generally works)
  • Verified that the Sync between multiple devices (Android, iOS and MacOS) is working fine
1 2
1 2
3 4
2023-11-30_14-21-54_2.mov
Home button (double check it works as expected)
  • Verified that the Home button looks and works fine
1 2 3
1 2 3
Top toolbar (double check there are no excessive items)
  • Verified that the Top toolbar UI and functionality work fine
1 2 3
1 2 3
1 2 3

@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2023

Labelling as QA/No & release-notes/exclude in favour of #34648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants