-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 119 to Chromium 120. #33471
Comments
Verification PASSED on
Tabs bar context menus look correctly (on a tab and on empty space)_PASSED
Side panel UI looks/functions correctly._PASSED
Power Bookmarks
In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55 Sync works_PASSED
Magnet URLs work_PASSED
Interstitial pages_Inprogress_PASSEDCase 1:
Case 2: Case 3: Request OTR Steps:
Confirmed that
|
Example | Example | Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Case 4: Shields domain block interstitial
- Verified the test plan from First-party domain blocking #14134 (comment)
- Confirmed that interstitial-page warning message is shown when shields are set to "Aggressive" ad blocking mode
101com.com | 00px.net | zzhc.vnet.cn | 101order.com |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Settings comparison
- New settings
On-device site data
cookies settings is added as part of CR120, bot sure whether to retain this settings in brave or not - thread for more details https://bravesoftware.slack.com/archives/C7VLGSR55/p1701180529136849?thread_ts=1701121933.276189&cid=C7VLGSR55
- Settings
Show images on tab hover preview cards
is inherited from chrome - Logged CR 120 - Redundant settingsShow images on tab hover preview cards
is inherited from chrome #34608
Components updater
@srirambv The desktop affected area item |
Verification passed on
33471.mp4 |
Verified on
Send to device
Brave Shields and privacy settings
Sync
Home button
Top toolbar
|
Verified on
Send tab to other device (double check it works as intended)
Brave shields and privacy settings (double check no regression in this section)
Main app menu UI (double check there is no regression)
Sync (double check it generally works)
2023-11-30_14-21-54_2.mov |
Labelling as |
Upgrade from Chromium 119 to Chromium 120
https://chromium.googlesource.com/chromium/src/+log/119.0.6045.7..120.0.6048.1/?pretty=fuller&n=10000
QA tests:
This is a major Chromium version bump, please do full passes.
Desktop Affected areas:
iOS Affected areas:
TBD
Android Affected areas:
The text was updated successfully, but these errors were encountered: