Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview crashes when opening bookmarked items #329

Closed
srirambv opened this issue Jun 13, 2018 · 3 comments
Closed

Webview crashes when opening bookmarked items #329

srirambv opened this issue Jun 13, 2018 · 3 comments
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Webview crashes when opening bookmarked items

Steps to Reproduce

  1. Build release version from source
  2. Import bookmarks from attached bookmark file (bookmarks_5000.zip)
  3. Right click on 0-99 folder and click on Open all (98)
  4. Wait till all the bookmark loads in tabs, many tabs has webview crash

Actual result:

Webview crashes when opening bookmarked items

Expected result:

None of the opened tabs should have webview crash

Reproduces how often:

100%

Brave version (about:brave info)

c84b457 (release build)

Additional Information

No console logs for any webview crash
may be related to #218

@srirambv srirambv added crash/webview Only tab webview crash. Browser doesn't crash needs-investigation A bug not 100% confirmed/fixed labels Jun 13, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy self-assigned this Jun 14, 2018
@bbondy bbondy assigned emerick and unassigned bbondy Jul 6, 2018
@emerick
Copy link
Contributor

emerick commented Aug 2, 2018

@srirambv In light of the findings in #481 (comment), I would retest by running from a command prompt or Windows Explorer. Results seem much better for me when I do that.

@emerick
Copy link
Contributor

emerick commented Aug 3, 2018

Spoke with @srirambv and we think the non-native shell is the root cause as discussed above, so closing this issue. Will reopen if we ever encounter this while using cmd.exe.

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Checked all pages, no crash

Verification Pass with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
Checked all pages, no crashes.

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added QA/Yes and removed needs-investigation A bug not 100% confirmed/fixed labels Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants