Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show test networks in a separate section and show icons #31815

Closed
Pavneet-Sing opened this issue Jul 24, 2023 · 2 comments · Fixed by brave/brave-core#19467
Closed

Show test networks in a separate section and show icons #31815

Pavneet-Sing opened this issue Jul 24, 2023 · 2 comments · Fixed by brave/brave-core#19467
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jul 24, 2023 •
edited
Loading

Description

Show test networks in a separate section (without any nested hierarchy).

Actual result

Test networks are being shown under primary networks as nested list

Expected result

Screenshot from 2023-07-24 16-41-35
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jul 24, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jul 24, 2023
@Pavneet-Sing Pavneet-Sing changed the title Show test networks in a separate section Show test networks in a separate section and show icons Jul 25, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 28, 2023
Merged
25 tasks
@simoarpe simoarpe moved this to In Review in Web3 Jul 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 31, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 31, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 3, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Aug 8, 2023

The above requires 1.57.42 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.57.42 x64 build

  • Verified steps from issue description
  • Verified test networks are listed under a separate Test Networks heading
31815.mp4

@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Show test networks separately brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds