Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary network position changes when any network is selected #31610

Closed
srirambv opened this issue Jul 13, 2023 · 3 comments · Fixed by brave/brave-core#19467
Closed

Secondary network position changes when any network is selected #31610

srirambv opened this issue Jul 13, 2023 · 3 comments · Fixed by brave/brave-core#19467
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Secondary network position changes when any network is selected

Steps to reproduce

  1. Visit any page that triggers Web3 connection to shown wallet icon in URL bar
  2. Open the panel and select network selector
  3. Select any network and look at the position of the secondary networks

Actual result

Network.selector.position.mp4

Expected result

Should not change position

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 13

Brave version

1.57.1 x64 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @simoarpe

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jul 13, 2023
@srirambv srirambv added this to Web3 Jul 13, 2023
@simoarpe
Copy link

It seems from the video recorded that also primary network position changes when tapped.

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jul 14, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jul 14, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jul 20, 2023
@simoarpe simoarpe moved this from Backlog to In Review in Web3 Jul 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 31, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 31, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Aug 8, 2023

The above requires 1.57.42 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 13 running 1.57.42 x64 build

  • Verified steps from issue description
  • Verified secondary networks position doesn't change when a different network is selected
31610.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants