Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Market asset detail screen #30717

Closed
simoarpe opened this issue May 31, 2023 · 1 comment · Fixed by brave/brave-core#18849
Closed

(Wallet) Market asset detail screen #30717

simoarpe opened this issue May 31, 2023 · 1 comment · Fixed by brave/brave-core#18849
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@simoarpe
Copy link

Description

Implement asset detail screen that shows:

  • Logo and asset name
  • Price and percentage change
  • BTC equivalent
  • Asset graph
  • Information rank
  • Price data powered by CoinGecko

iOS preview
Simulator Screenshot - iPhone 14 Pro - 2023-05-31 at 17 11 21
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 31, 2023
@simoarpe simoarpe added this to Web3 May 31, 2023
@simoarpe simoarpe mentioned this issue May 31, 2023
Closed
@simoarpe simoarpe moved this to In Progress in Web3 Jun 9, 2023
@simoarpe simoarpe mentioned this issue Jun 9, 2023
Merged
25 tasks
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Jun 9, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 12, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 12, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57.18 x64 Beta Build

  • Verified steps from brave/brave-core#18849
  • Verified transactions are not displayed when a token is selected from Market tab
  • Verified accounts are not displayed when a token is selected from Market tab
  • Verified the card view containing coin info is displayed when a token is selected from Market tab
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
30717-ARM.mp4
30717-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement coin market detail screen brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds