Upgrade from Chromium 114 to Chromium 115 #30200

emerick · 2023-05-08T13:07:14Z

Upgrade from Chromium 114 to Chromium 115

https://chromium.googlesource.com/chromium/src/+log/114.0.5735.110..115.0.5790.24/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

Verify that page info dialog (via lock icon) looks correct and functions as expected
Verify that omnibox works as expected, including autocomplete functionality
Verify that disabling/enabling autocomplete works as expected
Verify that cookie-related settings look correct and function as expected
Verify that content settings work as expected
Verify that Widevine-related functionality works as expected
Verify that download bubble works as expected
Verify that bookmarks and bookmark manager work as expected
Verify that Safari bookmarks importer works as expected
Verify that creating/using a new profile works as expected and that modals don't reference upstream branding (note that profile creation now occurs immediately, unlike in previous releases)

iOS Affected areas:

No specific changes of note

Android Affected areas:

Import/export bookmarks
Check QR code in url bar works
New tab page layout
Sync (double check it generally works)
Verify that SafeBrowsing works

GeetaSarvadnya · 2023-06-20T14:36:53Z

Verification PASSED on

Brave | 1.54.72 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Windows 10 Version 22H2 (Build 19045.3086)

Logged Icon is missing for Protected content ID's content settings #31160
Logged Shield settings is missing from the site settings #31161
Logged Shield settings icon missing in brave://settings/content page #31162
Logged CR 115 - Create a profile modal is referencing the upstream branding instead of the Brave #31173
Logged CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218
Encountered the issue Hamburger menu is shown at all screen sizes on brave://extensions #31181

Verify that page info dialog (via lock icon) looks correct and functions as expected_PASSED

Default info

The lock icon is changed which is expected as part of toolbar icons chage issue (Issue is mentioned in the setting comparison)
Conformed that click on lock icon shows the info dialog which has site name, connection is secure and cookies and site settings as expected
Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
Confirmed that click on Cookies displays the cookies info
Confirmed that click on the Site settings opens up the content settings for a site as expected, logged Icon is missing for Protected content ID's content settings #31160

Example	Example	Example	Example	Example

Update the cookies setting

Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
Go to global shield settings and change the cookies setting to "Block all"
Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
Go to brave://settings/cookies and select "Allow all cookies"
Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
Go to global shield settings and ensure that the cookies setting is set to "Disabled" due to step 5

step 1	step 2	step 3	step 4	step 5	step 6	step 7

Update site settings via lock icon

Open youtube.com and open any video and click on the lock icon and navigate to site settings
Set "Autoplay" settings to "Block"
Reload the video
Confirm that autoplay was blocked on this page icon is shown on the URL bar
Tap on the icon and allow the autoplay
Tap on the lock icon and ensure that "Sound" setting is enabled
Disable the "Sound" settings via lock icon
Confirm that video is playing without audio
Go to site setting and change the setting from "Mute" to "Allow"
Reload the video and ensure that the audio is autoplayed

Example	Example

Verify that disabling/enabling autocomplete works as expected_PASSED

Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
Open the buzzfeed.com in any tab
Keep the Top sites still disabled/unchecked
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
Keep the brave://settings/appearance setting as it is
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
Disable the main switch Show autocomplete suggestions in address bar
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF

step 2	step 3	step 4	step 7	step 8	step 9	step 10	step 11	step 12	step 13	step 14	step 15	step 16	step 17

Verify that omnibox works as expected, including autocomplete functionality_PASSED

Autocomplete functionality is tested in the item above
Confirmed that Omnibox looks good in both light and dark theme
Toolbar icons looks good in the omnibox
Logged CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218

Light mode	Dark mode

Verify that cookie-related settings look correct and function as expected_PASSED

Verified the cookies in Verify that page info dialog (via lock icon) looks correct and functions as expected case above

Verify that content settings work as expected_PASSED

Autoplay

Confirmed that the content settings are working as expected
Open a Youtube.com and click on the lock icon and navigate to Site settings, look for the Autoplay settings, by default it's set to "Allow (Default)", open any video in youtube.com and ensured that the video is autoplayed.
Set Autoplay settings to "Block" for youtube.com and reload the youtube.com and open any video and ensured that the video is NOT autoplayed.
Confirmed that Autoplay was blocked on this page icon is displayed in the URL bar

Example	Example	Example	Example	Example

Block script

Confirmed that Block scripts content settings works as expected
Open Twitter.com and click on the locak icon and navigate to Site settings and confirm that the Java scripts content settings is set to default "Allow(default)"
Set the Java scripts content settings to "Block" for Twitter and reload the twitter.com and ensured that the java scripts are blocked on this page and page doesn't load
Open the shields settings and ensured that the Java scripts is blocked via Shields

Example	Example	Example	Example	Example

Verify that Widevine-related functionality works as expected_PASSED

Confirmed that Widevine extension is disabled via brave://settings/extensions
Cnfirmed that Install Google Widevine notification is not shown when the Widevine extension is enabled via brave://settings/extensions
Confirmed that Install Widevine notification shown when user navigates to https://www.netflix.com/browse
Confirm that once user allow the Install Widevine notification, user can stream netflix videos
Confirm that user gets the Install Google Widevine notification when videos are played via CNN.com
Confirmed that the Widevine functionality works as expected in general

Example	Example	Example	Example

Verify that download bubble works as expected_PASSED

Confirmed download functionality works as expected
Confirmed the progress-meter color is "blurple" and matches the download button
Confirmed toolbar download button style is as expected
Confirmed that a tiny popup is auto opened when download completes
Confirmed that Shown in folder opens up the download file path
Confirmed that a file can be downloaded via PT and TOR tabs as well

Example	Example	Example

Verify that bookmarks and bookmark manager work as expected_PASSED

Confirmed that Bookmarks feature is working as expected in general
Confirmed that bookmarks can be imported from other browser
Confirmed that new bookmarks can be added
Confirmed that added bookmarks can be edited/removed
Confirmed that Bookmarks, Save passwords, Extensions and History are imported from other browsers
Confimed that imported bookmarks can be opened
Confirmed that bookmarks are shown in the bookmarks manager

Example	Example	Example

Verify that creating/using a new profile works as expected and that modals don't reference upstream branding (note that profile creation now occurs immediately, unlike in previous releases)_PASSED

Encountred and logged CR 115 - Create a profile modal is referencing the upstream branding instead of the Brave #31173
Confirmed that click on Create a new profile redirects to Who's using Brave? modal popup
Confirmed that Welcome screen is displayed when user click on + or Add
Confirmed that user can create the new profiles via PT and TOR tab windows
Confirmed that user can edit the created profile
Enable rewards in Profile 1 and change the global shield settings and SE and socialBlocking settings via brave://settings in Profile 1
Open Profle 2 and ensured that the preference changes made in the brave://settings in profile 1 are not reflected in Profile 2
Confirmed that each profile is independant
Restart the browser and ensured that select profiles modal popup is displayed

Example	Example	Example	Example	Example	Example

Settings comparison

No new settings are added as part of CR 115
The toolbar icons and settings icons are updated as part of Brave, (Ref [Leo Icons]: Update Toolbar Icons #30186)

Example	Example

Show sidebar settings option is shown first under brave://settings/appearance, (Ref Sidebar's Show on right option should located first #30810)
Move Improve search suggestions option is moved to brave://settings/search (Ref Move Improve search suggestions option to brave://settings/search #30878)

Components updater

A new components is added as part of Brave
Components are updates successfully without any error

`1.52.126 Chromium: 114.0.5735.133`	`1.54.72 Chromium: 115.0.5790.32`

Brave startup calls

Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

GeetaSarvadnya · 2023-06-21T10:24:06Z

@emerick The item Verify that Safari bookmarks importer works as expected needs to be verified on macOS correct? On windows, I have downloaded/installed Safari and added few bookmarks but Safari browser is NOT listed in the brave importer dropdown. Also, when I try to download any extensions via Safari, I am getting Safari can't find the server for https://extensions.apple.com/en-US/ message

Example	Example

cc: @kjozwiak @LaurenWags

emerick · 2023-06-21T10:59:56Z

@GeetaSarvadnya Yes, this only needs to be checked on Mac. I think Safari is no longer supported on Windows.

LaurenWags · 2023-06-21T19:19:05Z

Verified importing of Safari bookmarks with

Brave | 1.55.2 Chromium: 115.0.5790.32 (Official Build) nightly (x86_64)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | macOS Version 13.4 (Build 22F66)

We don't offer import of Safari bookmarks through our importer (see #27170).

So what a user has to do is export bookmarks from Safari (File > Export > Bookmarks) and then import them into Brave using the "Bookmarks HTML File" import option under brave://settings/importData.

Compared release channel version 1.52.126 Chromium: 114.0.5735.133 and confirmed when using 1.55.2 Chromium: 115.0.5790.32 importing bookmarks from Safari behaved as expected.

1.52.126	1.55.2

Uni-verse · 2023-06-22T17:27:05Z

Verified on Samsung Galaxy S21 5G using the following version(s):

Brave	1.54.73 Chromium: 115.0.5790.32 (Official Build) canary (64-bit) 
Revision	f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Import/export bookmarks

Verified Import/Export bookmarks works on fresh and upgraded profile.
Verified user is able to Import/Export bookmark folders with bookmarks

Example	Example	Example

QR Scanner

Verified scanning QR from the url bar will highlight url
Verified navigating to scanned url is successful

Example	Example	Example

NTP Layout

Verified NTP layout on fresh and upgraded profile
Verified NTP layout with top bar and bottom bar configurations
Verified white background is displayed when disabling background images in new tab page settings
Verified NTPSI images are not shown if disabled via new tab page settings
Verified Brave news opt in card is shown on fresh profile
Verified Brave news feed is shown when user enables news

Example	Example	Example	Example

Sync

Verified starting sync chain from device as well as joining sync chain works
Verified history, bookmarks and open tabs are shown on other devices
Verified passwords and autofill is synced
Verified sharing links using Send to devices
Verified removing device/deleting sync chain removes sync chain from device

Example	Example	Example

SafeBrowsing

Verified Safe Browsing protection works using test page https://testsafebrowsing.appspot.com

Example	Example	Example	Example	Example	Example	Example

kjozwiak · 2023-06-23T05:36:06Z

Closing/Labelling as QA/No & release-notes/exclude in favour of #31207 (comment).

LaurenWags · 2023-06-23T13:24:40Z

Verified with

Brave | 1.53.103 Chromium: 115.0.5790.32 (Official Build) (x86_64)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | macOS Version 13.4.1 (Build 22F82)

Verify that page info dialog (via lock icon) looks correct and functions as expected - PASSED

Default info

The lock icon is displayed as expected
Confirmed that click on lock icon shows the info dialog which has site name, connection is secure and cookies and site settings as expected
Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
Confirmed that click on Cookies displays the cookies info
Confirmed that click on the Site settings opens up the content settings for a site as expected

Example	Example	Example	Example	Example

Update the cookies setting

Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
Go to global shield settings and change the cookies setting to "Block all"
Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
Go to brave://settings/cookies and select "Allow all cookies"
Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
Go to global shield settings and ensure that the cookies setting is set to "Disabled" due to step 5

step 1	step 2	step 3	step 4	step 5	step 6	step 7

Update site settings via lock icon

Open youtube.com and open any video and click on the lock icon and navigate to site settings
Set "Autoplay" settings to "Block"
Reload the video
Confirm that autoplay was blocked on this page icon is shown on the URL bar
Tap on the icon and allow the autoplay
Tap on the lock icon and ensure that "Sound" setting is enabled
Disable the "Sound" settings via lock icon
Confirm that video is playing without audio
Go to site setting and change the setting from "Mute" to "Allow"
Reload the video and ensure that the audio is autoplayed

Example	Example

Verify that disabling/enabling autocomplete works as expected - PASSED

Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
Open the buzzfeed.com in any tab
Keep the Top sites still disabled/unchecked
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
Keep the brave://settings/appearance setting as it is
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
Disable the main switch Show autocomplete suggestions in address bar
Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF

step 2	step 3	step 4	step 7	step 8	step 9	step 10	step 11	step 12	step 13	step 14	step 15	step 16	step 17

Verify that omnibox works as expected, including autocomplete functionality - PASSED

Autocomplete functionality is tested in the item above
Confirmed that Omnibox looks good in both light and dark theme
Toolbar icons looks good in the omnibox
Encountered CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218

Light mode	Dark mode

Verify that cookie-related settings look correct and function as expected - PASSED

Verified the cookies in Verify that page info dialog (via lock icon) looks correct and functions as expected case above

Verify that content settings work as expected - PASSED

Autoplay

Confirmed that the content settings are working as expected
Open a Youtube.com and click on the lock icon and navigate to Site settings, look for the Autoplay settings, by default it's set to "Allow (Default)", open any video in youtube.com and ensured that the video is autoplayed.
Set Autoplay settings to "Block" for youtube.com and reload the youtube.com and open any video and ensured that the video is NOT autoplayed.
Confirmed that Autoplay was blocked on this page icon is displayed in the URL bar

Example	Example	Example	Example	Example	Example

Block script

Confirmed that Block scripts content settings works as expected
Open Twitter.com and click on the locak icon and navigate to Site settings and confirm that the Java scripts content settings is set to default "Allow(default)"
Set the Java scripts content settings to "Block" for Twitter and reload the twitter.com and ensured that the java scripts are blocked on this page and page doesn't load
Open the shields settings and ensured that the Java scripts is blocked via Shields

Example	Example	Example	Example	Example

stephendonner · 2023-06-23T14:13:33Z

Verification `PASSED` using

Brave | 1.53.103 Chromium: 115.0.5790.32 (Official Build) (x86_64)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | macOS Version 14.0 (Build 23A5276g)

Verify that Widevine-related functionality works as expected - PASSED

Confirmed that Widevine extension is disabled via brave://settings/extensions
Cnfirmed that Install Google Widevine notification is not shown when the Widevine extension is enabled via brave://settings/extensions
Confirmed that Install Widevine notification shown when user navigates to https://www.netflix.com/browse
Confirm that once user allow the Install Widevine notification, user can stream netflix videos
Confirm that user gets the Install Google Widevine notification when videos are played via CNN.com, hulu.com, and the other Widevine-using providers listed in the table below
Confirmed that the Widevine functionality works as expected in general

Component version

Widevine Content Decryption Module - Version: 4.10.2652.1

example	example	example	example	example	example	example	example

`Max (formerly HBOMax)`	`Netflix`	`YouTube Free, w/Ads`	`Disney+`	`Pluto.tv`

Verify that download bubble works as expected - PASSED

`Blocked - Insecure download` - `PASSED`

example	example	example	example	example

`Blocked - Malicious file` - `PASSED`

example	example	example	example	example	example	example	example	example

`Blocked - Dangerous file` - `PASSED`

example	example	example	example	example	example

Verify that bookmarks and bookmark manager work as expected - PASSED

Confirmed that Bookmarks feature is working as expected in general
Confirmed that bookmarks can be imported from other browser
Confirmed that new bookmarks can be added
Confirmed that added bookmarks can be edited/removed
Confirmed that Bookmarks, Save passwords, Extensions and History are imported from other browsers
Confirmed that imported bookmarks can be opened
Confirmed that bookmarks are shown in the bookmarks manager
Confirmed opening multiple tabs from imported bookmarks, using files from https://github.com/brave/qa-resources/tree/master/SampleBookmarks

example	example	example	example	example	example

Verify that Safari bookmarks importer works as expected - PASSED

`Onboarding tour` - `PASSED`

example	example	example	example	example	example

`Brave` -> `Import Bookmarks and Settings` - `PASSED`

example	example	example	example

`App menu` -> `Bookmarks` - `Import Bookmarks and Settings...` - `PASSED`

example	example	example	example

`brave://settings/importData` - `PASSED`

example	example	example	example

Verify that creating/using a new profile works as expected and that modals don't reference upstream branding (note that profile creation now occurs immediately, unlike in previous releases) - PASSED

Confirmed that clicking on Create a new profile redirects to Who's using Brave? modal popup
Confirmed that Welcome screen is displayed when user click on + or Add
Confirmed that user can create the new profiles via PT and TOR tab windows
Confirmed that user can edit the created profile
Enable rewards in Profile 1 and change the global shield settings and SE and socialBlocking settings via brave://settings in Profile 1
Open Profle 2 and ensured that the preference changes made in the brave://settings in profile 1 are not reflected in Profile 2
Confirmed that each profile is independant
Restart the browser and ensured that select profiles modal popup is displayed

example	example	example	example	example	example	example	example

MadhaviSeelam · 2023-06-26T20:40:03Z

Verification PASSED using

Brave	1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit) 
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Linux

Encountered Icon is missing for Protected content ID's content settings #31160 - Couldn't reproduce as the icon is shown for Protected content IDs
Encountered Shield settings is missing from the site settings #31161 expected due to Extraneous Shields settings label in cookies' site details page #30208
Encountered Shield settings icon missing in brave://settings/content page #31162 - expected due to Extraneous Shields settings label in cookies' site details page #30208
Encountered CR 115 - Create a profile modal is referencing the upstream branding instead of the Brave #31173 - Reproduced
Encountered CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218 - Reproduced

Verify that page info dialog (via lock icon) looks correct and functions as expected_PASSED

Default info

The lock icon is changed which is expected as part of toolbar icons chage issue (Issue is mentioned in the setting comparison)
Conformed that click on lock icon shows the info dialog which has site name, connection is secure and cookies and site settings as expected
Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
Confirmed that click on Cookies displays the cookies info
Confirmed that click on the Site settings opens up the content settings for a site as expected

Example	Example	Example	Example	Example

Update the cookies setting

Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
Go to global shield settings and change the cookies setting to "Block all"
Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
Shields setting for the site shows Block all cookies
Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
Go to brave://settings/cookies and select "Allow all cookies"
Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
Go to global shield settings and ensure that the cookies setting is set to "Allow all cookies" due to step
Shields setting for the site shows Block all cookies

step 1	step 2	step 3	step 4	step 5	step 6	step 7	step 8	step 9

Update site settings via lock icon

Open youtube.com and open any video and click on the lock icon and navigate to site settings
Set "Autoplay" settings to "Block"
Reload the video
Confirm that autoplay was blocked on this page icon is shown on the URL bar
Tap on the icon and allow the autoplay
Tap on the lock icon and ensure that "Sound" setting is enabled
Disable the "Sound" settings via lock icon
Confirm that video is playing without audio
Go to site setting and change the setting from "Mute" to "Allow"
Reload the video and ensure that the audio is autoplayed

example	example	example	example	example

Verify that omnibox works as expected, including autocomplete functionality_PASSED

Autocomplete functionality is tested in the item above
Confirmed that Omnibox looks good in both light and dark theme
Toolbar icons looks good in the omnibox

Light mode	Dark mode

Verify that disabling/enabling autocomplete works as expected_PASSED

Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
Open a new tab and enter the string was in the URL bar and ensured that washingtonpost.com is in the autocomplete suggestion list
Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
Open the washingtonpost.com in any tab
Keep the Top sites still disabled/unchecked
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
Bookmark the site washingtonpost.com which is already opened in step 5 and close the tab
Keep the brave://settings/appearance setting as it is
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is shown in the autocomplete suggestion list as washingtonpost.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
Enable all the 3 switches under Show autocomplete suggestions in address bar main switch
Disable the main switch Show autocomplete suggestions in address bar
Open a new tab and enter the string was in the URL bar and ensured that the washingtonpost.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF

step 1	step 2	step 3	step 4	step 5	step 7	step 8	step 9	step 10	step 11	step 12	step 13	step 14	step 16	step 17

Verify that cookie-related settings look correct and function as expected_PASSED

Verified the cookies in Verify that page info dialog (via lock icon) looks correct and functions as expected case above

Verify that content settings work as expected_PASSED

Autoplay

Confirmed that the content settings are working as expected
Open a Youtube.com and click on the lock icon and navigate to Site settings, look for the Autoplay settings, by default it's set to "Allow (Default)", open any video in youtube.com and ensured that the video is autoplayed.
Set Autoplay settings to "Block" for youtube.com and reload the youtube.com and open any video and ensured that the video is NOT autoplayed.
Confirmed that Autoplay was blocked on this page icon is displayed in the URL bar

Example	Example	Example	Example	Example

Block script

Confirmed that Block scripts content settings works as expected
Open Twitter.com and click on the locak icon and navigate to Site settings and confirm that the Java scripts content settings is set to default "Allow(default)"
Set the Java scripts content settings to "Block" for Twitter and reload the twitter.com and ensured that the java scripts are blocked on this page and page doesn't load
Open the shields settings and ensured that the Java scripts is blocked via Shields

Example	Example	Example	Example	Example

Verify that Widevine-related functionality works as expected_PASSED

Confirmed that Widevine extension is disabled via brave://settings/extensions
Cnfirmed that Install Google Widevine notification is not shown when the Widevine extension is enabled via brave://settings/extensions
Confirmed that Install Widevine notification shown when user navigates to https://www.netflix.com/browse
Confirm that once user allow the Install Widevine notification, user can stream netflix videos
Confirm that user gets the Install Google Widevine notification when videos are played via CNN.com
Confirmed that the Widevine functionality works as expected in general

Example	Example	Example	Example

Verify that download bubble works as expected_PASSED

Confirmed download functionality works as expected
Confirmed the progress-meter color is "blurple" and matches the download button
Confirmed toolbar download button style is as expected
Confirmed that a tiny popup is auto opened when download completes
Confirmed that Shown in folder opens up the download file path
Confirmed that a file can be downloaded via PT and TOR tabs as well

Example	Example	Example	Example

Verify that bookmarks and bookmark manager work as expected_PASSED

Confirmed that Bookmarks feature is working as expected in general
Confirmed that bookmarks can be imported from other browser
Confirmed that new bookmarks can be added
Confirmed that added bookmarks can be edited/removed
Confirmed that Bookmarks, Save passwords, Extensions and History are imported from other browsers
Confimed that imported bookmarks can be opened
Confirmed that bookmarks are shown in the bookmarks manager

Example	Example	Example

Verify that creating/using a new profile works as expected and that modals don't reference upstream branding (note that profile creation now occurs immediately, unlike in previous releases)_PASSED

Encountred CR 115 - Create a profile modal is referencing the upstream branding instead of the Brave #31173
Confirmed that click on Create a new profile redirects to Who's using Brave? modal popup
Confirmed that Welcome screen is displayed when user click on + or Add
Confirmed that user can create the new profiles via PT and TOR tab windows
Confirmed that user can edit the created profile
Enable rewards in Profile 1 and change the global shield settings and SE and socialBlocking settings via brave://settings in Profile 1
Open Profle 2 and ensured that the preference changes made in the brave://settings in profile 1 are not reflected in Profile 2
Confirmed that each profile is independent
Restart the browser and ensured that select profiles modal popup is displayed

Example	Example	Example	Example

Settings comparison

No new settings are added as part of CR 115
***The toolbar icons and settings icons are updated as part of Brave only in nightly, (Ref [Leo Icons]: Update Toolbar Icons #30186) - not applicable for 1.53.104

Example	Example

Components updater

Components are updates successfully without any error

`1.52.129 Chromium: 114.0.5735.198`	`1.53.104 Chromium: 115.0.5790.40`

hffvld · 2023-06-27T19:29:42Z

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.53.104
Chromium: 115.0.5790.40 (Official Build) (64-bit)
Revision: 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}

Import/Export bookmarks

ACTUAL RESULTS:

Verified Import/Export bookmarks work on fresh and upgraded profiles.
Verified user is able to Import/Export bookmark folders with bookmarks

1	2	3	4

Check QR code in URL bar works

ACTUAL RESULTS:

Verified scanning QR code from the URL bar will highlight URL
Verified navigating to scanned URL is successful

1	2

New tab page layout

ACTUAL RESULTS:

Verified NTP layout on fresh and upgraded profile
Verified white background is displayed when disabling background images in new tab page settings
Verified NTP SI is not shown if disabled via new tab page settings
Verified Brave news opt-in card is shown on fresh profile
Verified Brave news feed is shown when a user enables news

1	2	3	4

Sync (double-check it generally works)

ACTUAL RESULTS:

Verified starting Sync chain from a device as well as joining Sync chain works
Verified History, Bookmarks and Opened tabs are shown on other devices
Verified passwords and autofill are synced
Verified sharing links using Send to devices
Verified removing device/deleting sync chain removes sync chain from device

1	2	3

4	5	6

Verify that SafeBrowsing works

ACTUAL RESULTS:

Verified Safe Browsing protection works using the test page https://testsafebrowsing.appspot.com

1	2	3	4

5	6	7	8

emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels May 8, 2023

emerick assigned emerick, samartnik and cdesouza-chromium May 8, 2023

emerick mentioned this issue May 8, 2023

Upgrade from Chromium 114 to Chromium 115 brave/brave-core#18388

Merged

25 tasks

emerick closed this as completed in brave/brave-core#18388 Jun 19, 2023

brave-builds added this to the 1.54.x - Nightly milestone Jun 19, 2023

This was referenced Jun 20, 2023

Icon is missing for Protected content ID's content settings #31160

Closed

Shield settings is missing from the site settings #31161

Closed

Shield settings icon missing in brave://settings/content page #31162

Closed

emerick mentioned this issue Jun 20, 2023

Upgrade from Chromium 114 to Chromium 115 (1.53.x) brave/brave-core#18967

Merged

25 tasks

GeetaSarvadnya mentioned this issue Jun 20, 2023

CR 115 - Create a profile modal is referencing the upstream branding instead of the Brave #31173

Closed

LaurenWags added the QA Pass-Win64 label Jun 21, 2023

GeetaSarvadnya mentioned this issue Jun 22, 2023

CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218

Closed

Uni-verse added the QA Pass - Android ARM label Jun 22, 2023

kjozwiak modified the milestones: 1.54.x - Beta, 1.53.x - Release Jun 23, 2023

kjozwiak added QA/No and removed QA/Yes release-notes/include labels Jun 23, 2023

kjozwiak added the release-notes/exclude label Jun 23, 2023

kjozwiak mentioned this issue Jun 23, 2023

Upgrade from Chromium 115.0.5790.32 to Chromium 115.0.5790.40 #31207

Closed

stephendonner added the QA Pass-macOS label Jun 23, 2023

hffvld added the QA Pass - Android Tab label Jun 27, 2023

MadhaviSeelam added the QA Pass-Linux label Jun 28, 2023

kjozwiak mentioned this issue Jun 29, 2023

Upgrade from Chromium 115.0.5790.40 to Chromium 115.0.5790.56 #31362

Closed

kjozwiak mentioned this issue Aug 10, 2023

Upgrade from Chromium 116.0.5845.62 to Chromium 116.0.5845.82. #32168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 114 to Chromium 115 #30200

Upgrade from Chromium 114 to Chromium 115 #30200

emerick commented May 8, 2023 •

edited

Loading

GeetaSarvadnya commented Jun 20, 2023 •

edited

Loading

GeetaSarvadnya commented Jun 21, 2023 •

edited

Loading

emerick commented Jun 21, 2023

LaurenWags commented Jun 21, 2023

Uni-verse commented Jun 22, 2023 •

edited

Loading

kjozwiak commented Jun 23, 2023

LaurenWags commented Jun 23, 2023 •

edited

Loading

stephendonner commented Jun 23, 2023 •

edited

Loading

`Blocked - Insecure download` - `PASSED`

`Blocked - Malicious file` - `PASSED`

`Blocked - Dangerous file` - `PASSED`

`Onboarding tour` - `PASSED`

`Brave` -> `Import Bookmarks and Settings` - `PASSED`

`App menu` -> `Bookmarks` - `Import Bookmarks and Settings...` - `PASSED`

`brave://settings/importData` - `PASSED`

MadhaviSeelam commented Jun 26, 2023 •

edited

Loading

hffvld commented Jun 27, 2023

Upgrade from Chromium 114 to Chromium 115 #30200

Upgrade from Chromium 114 to Chromium 115 #30200

Comments

emerick commented May 8, 2023 • edited Loading

GeetaSarvadnya commented Jun 20, 2023 • edited Loading

GeetaSarvadnya commented Jun 21, 2023 • edited Loading

emerick commented Jun 21, 2023

LaurenWags commented Jun 21, 2023

Uni-verse commented Jun 22, 2023 • edited Loading

Import/export bookmarks

QR Scanner

NTP Layout

Sync

SafeBrowsing

kjozwiak commented Jun 23, 2023

LaurenWags commented Jun 23, 2023 • edited Loading

stephendonner commented Jun 23, 2023 • edited Loading

Verification PASSED using

Blocked - Insecure download - PASSED

Blocked - Malicious file - PASSED

Blocked - Dangerous file - PASSED

Onboarding tour - PASSED

Brave -> Import Bookmarks and Settings - PASSED

App menu -> Bookmarks - Import Bookmarks and Settings... - PASSED

brave://settings/importData - PASSED

MadhaviSeelam commented Jun 26, 2023 • edited Loading

hffvld commented Jun 27, 2023

emerick commented May 8, 2023 •

edited

Loading

GeetaSarvadnya commented Jun 20, 2023 •

edited

Loading

GeetaSarvadnya commented Jun 21, 2023 •

edited

Loading

Uni-verse commented Jun 22, 2023 •

edited

Loading

LaurenWags commented Jun 23, 2023 •

edited

Loading

stephendonner commented Jun 23, 2023 •

edited

Loading

Verification `PASSED` using

`Blocked - Insecure download` - `PASSED`

`Blocked - Malicious file` - `PASSED`

`Blocked - Dangerous file` - `PASSED`

`Onboarding tour` - `PASSED`

`Brave` -> `Import Bookmarks and Settings` - `PASSED`

`App menu` -> `Bookmarks` - `Import Bookmarks and Settings...` - `PASSED`

`brave://settings/importData` - `PASSED`

MadhaviSeelam commented Jun 26, 2023 •

edited

Loading