Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old icons in rewards settings in 0.59.x #3013

Closed
btlechowski opened this issue Jan 18, 2019 · 4 comments
Closed

Old icons in rewards settings in 0.59.x #3013

btlechowski opened this issue Jan 18, 2019 · 4 comments

Comments

@btlechowski
Copy link

Follow up from #1825

Steps to Reproduce

  1. open brave://rewards
  2. Turn off rewards

Actual result:

image

Expected result:

image

Brave version (brave://version info)

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Not reproducible in 0.60.15 Windows 7

cc @brave/legacy_qa @NejcZdovc @ryanml

@ryanml
Copy link
Contributor

ryanml commented Jan 18, 2019

All we should need to do for this one is uplift the brave-ui update.

Only issue is, Ads aren't on 59.x yet, so the update would remove the Coming Soon text, which may be an issue. cc: @NejcZdovc @btlechowski

@NejcZdovc
Copy link
Contributor

I think it's fine if we just not do this in 0.59

@srirambv
Copy link
Contributor

I agree with @NejcZdovc .

cc: @rebron to take call on keeping the issue open

@NejcZdovc
Copy link
Contributor

closing for now, we can reopen it if needed

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 19, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants