Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads will not be served on clean profile till browser restart after few page reloads #29854

Closed
btlechowski opened this issue Apr 19, 2023 · 2 comments

Comments

@btlechowski
Copy link

btlechowski commented Apr 19, 2023

With no variation seed it is possible to lose user activity score but not gain it.
All new users will be affected till browser restart.
We need to tweak our default values.

Note: after score timeout is reached, the score is reset to 0

Steps to Reproduce

  1. Clean profile
  2. Run Brave
  3. Enable rewards and ads
  4. Open brave://welcome
  5. Reload brave://welcome 5 times (using F5)

Actual result:

User activity goes below zero, but can't increase it therefor no ads are shown

[32234:32234:0419/161820.902780:VERBOSE2:permission_rule_util.cc(25)] User was inactive
[32234:32234:0419/161820.902965:VERBOSE1:notification_ad_serving.cc(106)] Notification ad not served: Not allowed due to permission rules
[32234:32234:0419/161820.965328:VERBOSE1:browser_manager.cc(120)] Browser did resign active
[32234:32234:0419/161820.967812:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 17 (-2:0:900 s)

[32234:32234:0419/161841.263945:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 11 (-2:0:900 s)
[32234:32234:0419/161841.298041:VERBOSE2:permission_rule_util.cc(25)] User was inactive
[32234:32234:0419/161841.298821:VERBOSE1:new_tab_page_ad_serving.cc(62)] New tab page ad not served: Not allowed due to permission rules

Expected result:

User is able to view the ads on clean install

Reproduces how often:

Easily reproduced

Version/Channel Information:

Brave 1.51.96 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
Revision 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS Ubuntu 18.04 LTS

cc @tmancey @aseren @iambrianfung @rebron

@btlechowski btlechowski changed the title Ads will not be served till browser restart after few page reloads Ads will not be served on clean profile till browser restart after few page reloads Apr 19, 2023
@tmancey
Copy link
Contributor

tmancey commented Apr 19, 2023

This is working as expected, I will reach out in DM

@tmancey tmancey self-assigned this Apr 19, 2023
@tmancey
Copy link
Contributor

tmancey commented Apr 19, 2023

Closing, please see DM. Thanks

@tmancey tmancey closed this as completed Apr 19, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants