"You can start a private call in Brave" showing up multiple times in one profile on ntp

[wknapik]

Description

This is showing up multiple times in the same profile on release channel on Linux

So far I've seen it 7 times in a few days, the last 3 today

Steps to Reproduce

1. Open new tab

Actual result:

This is showing up multiple times per profile

Expected result:

This should show up once per profile

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Brave	1.49.132 Chromium: 111.0.5563.147 (Official Build) (64-bit)
Revision	029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? ?
• Can you reproduce this issue with the nightly channel? ?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

[wknapik]

This is now happening multiple times a day on v1.50.114 on Linux

[wknapik]

This stopped for a while and then I got it again 2 days ago in v1.50.125 on Linux, only once so far

[wknapik]

Haven't seen this since the last message

[kjozwiak]

Removing OS/Linux as we'll need to verify on other platforms as well due to removing the Brave Talk prompt entirely.

[kjozwiak]

The above requires 1.53.101 or higher for 1.53.x verification 👍

[stephendonner]

Removing OS/Linux as we'll need to verify on other platforms as well due to removing the Brave Talk prompt entirely.

Adding QA/Test-All-Platforms, given the above. Please remove if I misunderstood!

[stephendonner]

Verification PASSED using

Brave | 1.53.102 Chromium: 114.0.5735.133 (Official Build) (x86_64)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | macOS Version 14.0 (Build 23A5276g)

New profile - PASS

Steps:

1. installed 1.53.102
2. launched Brave
3. completed onboarding
4. examined the new-tab page
5. hovered over the Brave Talk icon on the Customize row
6. confirmed You can start a private call in Brave. icon tooltip
7. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave. promo is gone; also confirmed I could launch and use Brave Talk from its icon

new-tab page	You can start a private call in Brave. tooltip	Brave Talk	Customize Dashboard dialog

Upgrade - PASS

Steps:

1. installed 1.52.126
2. launched Brave
3. populated a typical browsing session, with bookmarks, etc.
4. opened a new-tab page
5. confirmed I saw the You can start a private call in Brave. promo, above the Brave Talk icon, on the bottom Customize row in the new-tab page
6. updated to and launched 1.53.102
7. opened a new-tab page
8. hovered over the Brave Talk icon on the Customize row
9. confirmed it read You can start a private call in Brave Talk.
10. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave Talk. promo is no longer present; also confirmed working Brave Talk via its icon

N.B. the screenshots are in order of testing, but I had to recreate a few screenshots, and couldn't readily make the promo tooltip appear in 1.52.x, so re-used the profile, and thus the new-tab page's timestamps are out of order, accordingly.

1.52.126	1.53.102	You can start a private call in Brave Talk. tooltip	Customize Dashboard dialog

[MadhaviSeelam]

Verification PASSED using

Brave | 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Linux

Steps:

1. installed 1.53.102
2. launched Brave
3. completed onboarding
4. examined the new-tab page
5. hovered over the Brave Talk icon on the Customize row
6. confirmed You can start a private call in Brave. icon tooltip
7. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave. promo is not shown; also confirmed I could launch and use Brave Talk from its icon

new-tab page	You can start a private call in Brave. tooltip	Brave Talk	Customize Dashboard dialog

Upgrade - PASS

Steps:

1. installed 1.52.126
2. launched Brave
3. populated a typical browsing session, with bookmarks, etc.
4. opened a new-tab page
5. confirmed I saw the You can start a private call in Brave. promo, above the Brave Talk icon, on the bottom Customize row in the new-tab page
6. updated to and launched 1.53.102
7. opened a new-tab page
8. hovered over the Brave Talk icon on the Customize row
9. confirmed it read You can start a private call in Brave Talk.
10. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave Talk. promo is no longer present; also confirmed working Brave Talk via its icon

*Note: Have not seen You can start a private call in Brave Talk in 1.52.126 or 1.49.132

1.52.126	You can start a private call in Brave Talk. tooltip	Customize Dashboard dialog

[MadhaviSeelam]

Verification PASSED using

Brave | 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)

Steps:

1. installed 1.53.102
2. launched Brave
3. completed onboarding
4. examined the new-tab page
5. hovered over the Brave Talk icon on the Customize row
6. confirmed You can start a private call in Brave. icon tooltip
7. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave. promo is not shown; also confirmed I could launch and use Brave Talk from its icon

new-tab page	You can start a private call in Brave. tooltip	Brave Talk	Customize Dashboard dialog

Upgrade - PASS

Steps:

1. installed 1.52.126
2. launched Brave
3. populated a typical browsing session, with bookmarks, etc.
4. opened a new-tab page
5. confirmed I saw the You can start a private call in Brave. promo, above the Brave Talk icon, on the bottom Customize row in the new-tab page
6. updated to and launched 1.53.102
7. opened a new-tab page
8. hovered over the Brave Talk icon on the Customize row
9. confirmed it read You can start a private call in Brave Talk.
10. clicked on the Brave Talk icon

Confirmed the You can start a private call in Brave Talk. promo is no longer present; also confirmed working Brave Talk via its icon

*Note: Have not seen You can start a private call in Brave Talk in 1.52.126

1.52.126	You can start a private call in Brave Talk. tooltip	Customize Dashboard dialog

[stephendonner]

Ah, @MadhaviSeelam of course - the promo-tooltip removal was uplifted to 1.52.x over in brave/brave-core#18825, so in the future if we needed to recreate those scenarios, we could use 1.51.x, looks like 👍 But our testing seems good to me.