You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here: #26285 (comment) you explained how $badfilter wasn't working as a custom rule because of the different engines being use the by adblocker and how merging engines like in #5461 was needed to fix the issue.
The thing is, while $badfilter can be used now as a custom filter, it only applies to Custom lists/rules and Regional lists, not to default ones, something that also happens when creating more important exceptions like example#@#.class and when using ||example^$ghide, they also don't apply to Default lists.
So is if there is something wrong with it or is it meant to be working that way even if engines are merged? I just don't know if the merge was just to make the adblocker better and still treat the lists as separately, or it is not working as it was meant to be working by you.
I just noticed the issue earlier, because I wanted to fix a site that wasn't working properly with uBlock or Brave; the site is awful, and needs 'ads to be clicked' in one tab, to get the timer going in another tab, the problem in Brave is that a generic cosmetic ##ins.adsbygoogle was used, so I needed to use ghide to avoid that, I also noticed in my tests that creating a normal cosmetic exception wasn't working as I expected it, until I removed the default lists and then used them as custom lists to be able to use these features.
I don't mind using default lists as custom, even if the updating process is not the best and takes time to update so many lists, so if this behavior is meant to be, I guess I will not mind keep running them as custom and manually update them, if I get features working properly/as expected across all lists like in other adblockers.
The text was updated successfully, but these errors were encountered:
@Emi-TheDhamphirInLoveUnderTheFrozenStar sorry I missed this earlier - yes, for now $badfilter in custom filters only works for anything not in the default lists. Some of the exception logic also isn't wired up to be properly excepted across engines. Luckily there are only two engines now rather than 1 for every list. I'd like to eventually get everything into just 1 engine if possible but that likely won't happen in the near future.
I'd like to add a brave://flags flag to disable the default engine altogether though, and then all the default lists can be manually added to subscription lists instead to support this kind of use-case. As of brave/brave-core#18836expires is now supported which should make this a bit less cumbersome to deal with.
+1
That would be a great workaround.
For the moment what I do is to go to the iodkpdagapdfkphljnddpjlldadblomo folder, delete the Folder with the txt default lists, and then go to permissions and deny any write permission. Pretty easy to do in Windows but a flag would make it really easy.
But having a flag would be 100 times easier!
ghost
changed the title
Question regarding: Merge adblock engines #5461
Add a flag to Disable Default Filter list, in order to easy troubleshoot lists and filters easier.
Sep 9, 2023
ghost
referenced
this issue
in brave/adblock-lists
Nov 1, 2023
Hi @antonok-edm I have a question.
Here: #26285 (comment) you explained how $badfilter wasn't working as a custom rule because of the different engines being use the by adblocker and how merging engines like in #5461 was needed to fix the issue.
The thing is, while
$badfilter
can be used now as a custom filter, it only applies to Custom lists/rules and Regional lists, not to default ones, something that also happens when creating more important exceptions likeexample#@#.class
and when using||example^$ghide
, they also don't apply to Default lists.So is if there is something wrong with it or is it meant to be working that way even if engines are merged? I just don't know if the merge was just to make the adblocker better and still treat the lists as separately, or it is not working as it was meant to be working by you.
I just noticed the issue earlier, because I wanted to fix a site that wasn't working properly with uBlock or Brave; the site is awful, and needs 'ads to be clicked' in one tab, to get the timer going in another tab, the problem in Brave is that a generic cosmetic
##ins.adsbygoogle
was used, so I needed to use ghide to avoid that, I also noticed in my tests that creating a normal cosmetic exception wasn't working as I expected it, until I removed the default lists and then used them as custom lists to be able to use these features.I don't mind using default lists as custom, even if the updating process is not the best and takes time to update so many lists, so if this behavior is meant to be, I guess I will not mind keep running them as custom and manually update them, if I get features working properly/as expected across all lists like in other adblockers.
The text was updated successfully, but these errors were encountered: