Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab switching with mouse wheel is not working with #brave-change-active-tab-on-scroll-event enabled on vertical tabs #28893

Open
btlechowski opened this issue Mar 3, 2023 · 3 comments

Comments

@btlechowski
Copy link

Follow up to #27694

Steps to Reproduce

Steps:

  1. Enable brave://flags/#brave-vertical-tabs
  2. Enable brave://flags/#brave-change-active-tab-on-scroll-event
  3. Open few NTP
  4. Change tabs layout to vertical tabs (Right click on any tab)
  5. hover over tab bar and move your mouse wheel

Actual result:

Nothing happens

Expected result:

the active tab is changed through mouse wheel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.51.5 Chromium: 111.0.5563.50 (Official Build) nightly (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Ubuntu 18.04 LTS

cc @sangwoo108

@sangwoo108
Copy link

sangwoo108 commented Mar 3, 2023

Hi, @btlechowski , is it disabled when #brave-change-active-tab-on-scroll-event is off? We're giving a chance to disable it, so if it's disabled with the flag off, then it's exepcted behavior.

@btlechowski
Copy link
Author

btlechowski commented Mar 6, 2023

@sangwoo108 the switching with mouse wheel is disabled when #brave-change-active-tab-on-scroll-event is on.
It is also disabled when #brave-change-active-tab-on-scroll-event is off

@why-not-try-calmer
Copy link

why-not-try-calmer commented Jan 10, 2024

I can confirm. #brave-change-active-tab-on-scroll-event simply doesn't work with vertical tabs.

Version 1.61.114 Chromium: 120.0.6099.199 (Official build) (64 bits).

@sangwoo108 sangwoo108 self-assigned this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants