Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Exit dialog text for Sync #2884

Closed
rebron opened this issue Jan 9, 2019 · 6 comments
Closed

update Exit dialog text for Sync #2884

rebron opened this issue Jan 9, 2019 · 6 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 9, 2019

Description

screen shot 2019-01-09 at 2 54 24 pm

Updated

  1. Change text above to read:
    Are you sure?
    "Sync is still waiting to confirm your new device connection. If you close this window, your sync chain will be reset and you will need to start over."

  2. Change "Exit Modal" button text from "Exit Modal" to read "Close Anyway"

@rebron
Copy link
Collaborator Author

rebron commented Jan 10, 2019

@alexwykoff @rossmoody I think we could be more descriptive/clear than just having the options labeled 'Cancel' and 'Exit'
Also see: #2863

@rossmoody
Copy link
Contributor

Cancel on the initial screen makes sense to me, but perhaps on the confirmation modal that appears Resume and Exit might be more appropriate.

@rebron rebron added bug and removed bug labels Jan 10, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jan 10, 2019

I'm thinking maybe we use 'Back' instead of 'Cancel' or 'Resume' and 'Exit', 'Exit Sync' or 'Stop Sync'.

@bradleyrichter
Copy link

@rebron I think we could try something slightly different:

"Sync is still waiting to confirm your new device connection. If you close this window, your sync chain will be reset and you will need to start over."

[Cancel] [Close Anyway]

@rebron
Copy link
Collaborator Author

rebron commented Jan 10, 2019

@bradleyrichter that sounds better. I'll update the original description.

@btlechowski
Copy link

btlechowski commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 11 36 35 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants