Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disable Autoplay support #281

Closed
bbondy opened this issue Jun 6, 2018 · 1 comment · Fixed by brave/brave-core#222
Closed

Add disable Autoplay support #281

bbondy opened this issue Jun 6, 2018 · 1 comment · Fixed by brave/brave-core#222
Assignees
@darkdh
Labels
feature/autoplay feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jun 6, 2018 •
edited by srirambv
Loading

To keep in line with browser-laptop
image
@srirambv srirambv mentioned this issue Jun 15, 2018
Closed
@srirambv srirambv added the feature/global-settings Settings at browser level independent of shields settings label Jun 15, 2018
@darkdh darkdh mentioned this issue Jul 10, 2018
Merged
9 tasks
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified autoplay bubble is shown when a site is loaded with media content
  • Verified Allow in the autoplay bubble, clicking media content starts to play
  • Verified Deny in the autoplay bubble, doens't load media content
  • Verified changing Auto play setting from site details dropdown asks to reload the page and changes take effect

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • Verified autoplay off by default notification is shown in URL bar
  • Verified if change setting to Ask:
  • Verified Allow in the autoplay bubble, clicking media content starts to play
  • Verified Deny in the autoplay bubble, doens't load media content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/autoplay feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Enable granular control of autoplay brave/brave-core
5 participants
@bbondy @darkdh @srirambv @LaurenWags @GeetaSarvadnya