Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate getBuyUrl call to getBuyUrlV1 #27996

Closed
Pavneet-Sing opened this issue Jan 24, 2023 · 1 comment · Fixed by brave/brave-core#16872
Closed

Migrate getBuyUrl call to getBuyUrlV1 #27996

Pavneet-Sing opened this issue Jan 24, 2023 · 1 comment · Fixed by brave/brave-core#16872
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Migrate BlockchainRegistry getBuyUrl call to getBuyUrlV1 from AssetRatioService for broader support and to remove old dependency.

Expected result

The buy click option should work as expected.
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 24, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 24, 2023
Closed
@Pavneet-Sing Pavneet-Sing added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 24, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 27, 2023
@simoarpe simoarpe mentioned this issue Jan 31, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Feb 11, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 11, 2023
@srirambv
Copy link
Contributor

Verified as part of #23316 (comment). Verified Buy option works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Update on-ramp providers and add purchase method screen brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds