Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in menu properties #27856

Closed
SergeyZhukovsky opened this issue Jan 17, 2023 · 1 comment · Fixed by brave/brave-core#16706
Closed

Crash in menu properties #27856

SergeyZhukovsky opened this issue Jan 17, 2023 · 1 comment · Fixed by brave/brave-core#16706
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in GPS on stable 1.47.x. We need to have a check in that place https://github.com/brave/brave-core/blob/1.47.x/android/java/org/chromium/chrome/browser/app/appmenu/AppMenuIconRowFooter.java#L85

Crash stack:

Exception java.lang.reflect.UndeclaredThrowableException:
  at $Proxy0.dispatchTouchEvent ($Proxy0.java)
  at com.android.internal.policy.DecorView.dispatchTouchEvent (DecorView.java:456)
  at android.view.View.dispatchPointerEvent (View.java:13884)
  at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent (ViewRootImpl.java:6202)
  at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess (ViewRootImpl.java:5940)
  at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:5393)
  at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:5453)
  at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:5412)
  at android.view.ViewRootImpl$AsyncInputStage.forward (ViewRootImpl.java:5577)
  at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:5420)
  at android.view.ViewRootImpl$AsyncInputStage.apply (ViewRootImpl.java:5634)
  at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:5393)
  at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:5453)
  at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:5412)
  at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:5420)
  at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:5393)
  at android.view.ViewRootImpl.deliverInputEvent (ViewRootImpl.java:8343)
  at android.view.ViewRootImpl.doProcessInputEvents (ViewRootImpl.java:8312)
  at android.view.ViewRootImpl.enqueueInputEvent (ViewRootImpl.java:8263)
  at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent (ViewRootImpl.java:8482)
  at android.view.InputEventReceiver.dispatchInputEvent (InputEventReceiver.java:188)
  at android.os.MessageQueue.nativePollOnce (MessageQueue.java)
  at android.os.MessageQueue.next (MessageQueue.java:336)
  at android.os.Looper.loop (Looper.java:182)
  at android.app.ActivityThread.main (ActivityThread.java:7822)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:492)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1026)
Caused by java.lang.reflect.InvocationTargetException:
  at java.lang.reflect.Method.invoke (Method.java)
  at org.chromium.base.ApplicationStatus$WindowCallbackProxy.invoke (ApplicationStatus.java:246)
  at java.lang.reflect.Proxy.invoke (Proxy.java:1006)
Caused by java.lang.NullPointerException: Attempt to invoke interface method 'boolean org.chromium.chrome.browser.tab.Tab.canGoForward()' on a null object reference
  at org.chromium.chrome.browser.app.appmenu.AppMenuIconRowFooter.initialize (AppMenuIconRowFooter.java:85)
  at org.chromium.chrome.browser.appmenu.BraveTabbedAppMenuPropertiesDelegate.onFooterViewInflated (BraveTabbedAppMenuPropertiesDelegate.java:206)
  at org.chromium.chrome.browser.ui.appmenu.AppMenuHandlerImpl.onFooterViewInflated (AppMenuHandlerImpl.java:325)
  at org.chromium.chrome.browser.ui.appmenu.AppMenu.inflateFooter (AppMenu.java:642)
  at org.chromium.chrome.browser.ui.appmenu.AppMenu.show (AppMenu.java:268)
  at org.chromium.chrome.browser.ui.appmenu.AppMenuHandlerImpl.showAppMenu (AppMenuHandlerImpl.java:222)
  at org.chromium.chrome.browser.ui.appmenu.AppMenuButtonHelperImpl.showAppMenu (AppMenuButtonHelperImpl.java:122)
  at org.chromium.chrome.browser.ui.appmenu.AppMenuButtonHelperImpl.onTouch (AppMenuButtonHelperImpl.java:75)
  at android.view.View.dispatchTouchEvent (View.java:13612)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3131)
  at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:2731)
  at com.android.internal.policy.DecorView.superDispatchTouchEvent (DecorView.java:506)
  at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent (PhoneWindow.java:1857)
  at android.app.Activity.dispatchTouchEvent (Activity.java:4105)
  at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent (WindowCallbackWrapper.java:70)
  at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent (WindowCallbackWrapper.java:1)
@kjozwiak
Copy link
Member

Going to label this one as QA/No as there's no STR/Cases as we found the above via the GPS dashboard. However, we do run through a reduced manual pass which should flush anything out if the above caused any issues/regressions with the bottom menu including going forward/backwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants