Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Add SVG support to NFT images #27800

Closed
simoarpe opened this issue Jan 13, 2023 · 3 comments · Fixed by brave/brave-core#17330
Closed

(Wallet) Add SVG support to NFT images #27800

simoarpe opened this issue Jan 13, 2023 · 3 comments · Fixed by brave/brave-core#17330
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include security
Milestone
1.51.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Jan 13, 2023 •
edited
Loading

The Android framework does not support SVG images out of the box.
We are already using Glide, so a possible option would be to implement a custom SVG decoder using Glide, as explained in the official Glide examples.
This solution would require an external library to include into the codebase.
@simoarpe simoarpe added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 13, 2023
@simoarpe simoarpe mentioned this issue Jan 13, 2023
Merged
25 tasks
@diracdeltas
Copy link
Member

cc @kdenhartog @thypon for security considerations

@kdenhartog kdenhartog self-assigned this Jan 15, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 20, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 20, 2023
@kdenhartog kdenhartog removed their assignment Feb 1, 2023
@simoarpe simoarpe mentioned this issue Feb 22, 2023
Merged
25 tasks
@simoarpe
Copy link
Author

@diracdeltas, @kdenhartog, @thypon, requested security review: https://github.com/brave/security/issues/1202

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Mar 21, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 21, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.51.97 x64 Beta build

27800.mp4

@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Implement SVG support for NFT images brave/brave-core
7 participants
@jamesmudgett @diracdeltas @simoarpe @Pavneet-Sing @srirambv @kdenhartog @brave-builds