Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://settings/shields - AMP translation issue #25457

Closed
mbiesiad opened this issue Sep 16, 2022 · 1 comment · Fixed by brave/brave-core#15200
Closed

brave://settings/shields - AMP translation issue #25457

mbiesiad opened this issue Sep 16, 2022 · 1 comment · Fixed by brave/brave-core#15200
Assignees
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@mbiesiad
Copy link

Description

AMP part in brave://settings/shields is not translated.

Steps to Reproduce

  1. Set lang. other than English (ie.: Polish)
  2. Go to: brave://settings/?search=amp or: brave://settings/shields
  3. Take a look at part contains 'AMP'

Actual result:

div.label there is translated, but span#sub-label-text is not.

Always visit original (non-AMP) page URLs, instead of Google's Accelerated Mobile Page versions text is still displayed in English.

Expected result:

Consistency is maintained - mentioned part is also translated.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.43.93 Chromium: 105.0.5195.127

Miscellaneous Information:

Screenshot:
image

Best wishes,

@stephendonner
Copy link

Verified PASSED using

Brave 1.44.99 Chromium: 106.0.5249.55 (Oficjalna wersja) (x86_64)
Wersja 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
System operacyjny macOS Wersja 11.7 (kompilacja 20G817)
brave://settings/shields support.brave.com
Zrzut ekranu 2022-09-26 o 5 09 21 PM Zrzut ekranu 2022-09-26 o 5 14 03 PM

Confirmed translated text, as well as clicked on Dowiedz się więcej which went to https://support.brave.com/hc/en-us/articles/8611298579981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants