Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP background selections should accurately reflect only the current selection #25379

Closed
petemill opened this issue Sep 13, 2022 · 6 comments
Closed
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me OS/Desktop

Comments

@petemill
Copy link
Member

Description

Selecting a gradient child item results in the Solid colors top-level option being selected.

Steps to Reproduce

  1. Open NTP
  2. Select gradients
  3. choose a gradient

Actual result:

image

Expected result:

Gradients should be selected

Version/Channel Information:

Nightly 1.45.23

@sangwoo108
Copy link

Hi, @petemill ! I was trying to reproduce it but couldn't 😥. Could you try with clean profile if possbile? I'm wondering if there's something related to migration or other preference.

Also #25380 too.

@sangwoo108
Copy link

Hi @GeetaSarvadnya ! Could you possibly help me to reproduce this issue and #25380 please? I was trying to reproduce them on Nighly and Development version, but I couldn't 😥

@rebron
Copy link
Collaborator

rebron commented Sep 23, 2022

I saw this earlier but I'm not seeing this in later builds.

Couldn't reproduce in:

Brave 1.45.68 Chromium: 106.0.5249.55 (Official Build) beta (arm64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 13.0 (Build 22A5342f)
JavaScript V8 10.6.194.11
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

@rebron
Copy link
Collaborator

rebron commented Mar 29, 2023

cc: @GeetaSarvadnya Can you see if you can reproduce. I couldn't reproduce in 1.45.68 and can't reproduce in 1.49.132

@rebron rebron added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Mar 29, 2023
@GeetaSarvadnya
Copy link

@sangwoo108 @rebron Issue is NOT reproducible on Windows 10 x64 - 1.50.108.

Brave | 1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 10 Version 21H2 (Build 19044.2728)

@rebron
Copy link
Collaborator

rebron commented Jul 25, 2023

Closing per last two comments.

@rebron rebron closed this as completed Jul 25, 2023
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed bug QA/Yes release-notes/include needs-more-info The report requires more detail before we can decide what to do with this issue. labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me OS/Desktop
Projects
None yet
Development

No branches or pull requests

4 participants