Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons in brave://settings and advanced settings pages #24872

Closed
stephendonner opened this issue Aug 23, 2022 · 7 comments · Fixed by brave/brave-core#14780
Closed

Missing icons in brave://settings and advanced settings pages #24872

stephendonner opened this issue Aug 23, 2022 · 7 comments · Fixed by brave/brave-core#14780

Comments

@stephendonner
Copy link

Description

Missing icons in Privacy & Security sections in Settings

Steps to Reproduce

  1. install 1.44.60
  2. launch Brave
  3. open brave://settings/privacy
  4. look at the (missing) icons below Automatically send diagnostic reports

Actual result:

Screen Shot 2022-08-22 at 6 40 42 PM

Expected result:

Screen Shot 2022-08-22 at 6 42 38 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.60 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS macOS Version 11.6.8 (Build 20G730)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

cc @brave/qa-team @mkarolin @rebron @emerick

@mkarolin
Copy link
Contributor

This is not specific to cr105, seems to be present in Brave is up to date [Version 1.44.60 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)](https://brave.com/latest/) as well.
cc: @fallaciousreasoning looks to be related to brave/brave-core#14347

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 23, 2022

Missing icons in brave://settings/autofill, brave://settings/security and brave://settings/cookies
image
image
image

@fallaciousreasoning
Copy link

I'll take a look

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 24, 2022

@fallaciousreasoning The icons are missing in the pages below: Please note the icons or expand arrow or other icons (e.g search etc) are missing in almost all the pages in each settings. I posted the screenshots for few settings pages, but still there are many pleae make sure to fix the issue for all the settings pages.

brave://settings/content
image

image

image (2)

image

image

image

image

image

image

image

image

image

image

image

image

@GeetaSarvadnya GeetaSarvadnya changed the title Missing icons in Privacy & Security sections in Settings Missing icons in brave://settings Aug 24, 2022
@GeetaSarvadnya GeetaSarvadnya changed the title Missing icons in brave://settings Missing icons in brave://settings and advanced settings pages Aug 24, 2022
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking labels Aug 24, 2022
@rebron rebron added this to the 1.43.x - Release milestone Aug 24, 2022
@rebron rebron removed this from the 1.43.x - Release milestone Aug 24, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 26, 2022
@rebron
Copy link
Collaborator

rebron commented Sep 6, 2022

@fallaciousreasoning I think we need an uplift for this for 1.44.x

@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.44.78 or higher for 1.44.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.44.78 Chromium: 105.0.5195.102 (Official Build) beta (x86_64)
Revision 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS macOS Version 13.0 (Build 22A5331f)

Confirmed icons were restored again.

settings/privacy settings/security settings/autofill settings/cookies settings/content settings
Screenshot 2022-09-07 at 2 16 04 PM Screenshot 2022-09-07 at 2 16 45 PM Screenshot 2022-09-07 at 2 17 01 PM Screenshot 2022-09-07 at 2 17 30 PM Screenshot 2022-09-07 at 2 17 58 PM Screenshot 2022-09-07 at 2 18 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants