Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Brave Ads StringPref/JSON to GetListPref and GetDictPref #24529

Closed
tmancey opened this issue Aug 8, 2022 · 1 comment · Fixed by brave/brave-core#14540
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 8, 2022

No description provided.

@tmancey tmancey self-assigned this Aug 8, 2022
@tmancey tmancey changed the title Transition Brave Ads StringPref from JSON to base::Value Transition Brave Ads StringPref from JSON to base::Value Aug 8, 2022
@tmancey tmancey changed the title Transition Brave Ads StringPref from JSON to base::Value Transition Brave Ads JSON StringPref to base::Value Aug 8, 2022
@tmancey tmancey changed the title Transition Brave Ads JSON StringPref to base::Value Transition Brave Ads StringPref/JSON to GetListPref and GetDictPref Aug 9, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 10, 2022
@btlechowski
Copy link

btlechowski commented Sep 27, 2022

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Ubuntu 18.04 LTS

Verified Epsilon greedy bandit feature is enabled

[16126:16126:0927/180151.317959:VERBOSE1:features_util.cc(37)] Text classification feature is disabled
[16126:16126:0927/180151.318178:VERBOSE1:features_util.cc(40)] Epsilon greedy bandit feature is enabled

Verified ad was shown using epsilon greedy bandit

[17337:17337:0927/181357.760330:VERBOSE2:epsilon_greedy_bandit_model.cc(162)] Exploiting epsilon greedy bandit segments:
[17337:17337:0927/181357.760561:VERBOSE1:eligible_notification_ads_v1.cc(38)] Get eligible notification ads:
[17337:17337:0927/181357.764543:VERBOSE1:eligible_notification_ads_v1.cc(161)] Get eligible ads for untargeted segment
[17337:17337:0927/181357.786579:VERBOSE2:priority.h(34)] 11 ads with a priority of 1 in bucket 1
[17337:17337:0927/181357.786774:VERBOSE1:eligible_notification_ads_v1.cc(184)] 11 eligible ads out of 11 ads for untargeted segment
[17337:17337:0927/181357.787138:VERBOSE1:notification_ad.cc(132)] Opportunity arose to serve a notification ad
[17337:17337:0927/181357.787561:VERBOSE1:notification_ad_serving.cc(140)] Found 11 eligible ads
[17337:17337:0927/181357.787712:VERBOSE1:notification_ad_serving.cc(246)] Served notification ad:
  placementId: 7572446e-543d-42ae-8d03-d1de1e5dade8
  creativeInstanceId: 2db34507-c654-4302-92ee-7fba4a8bc1fe
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad9
  body: Ad9
  targetUrl: https://brave.com/

Verified epsilon_greedy_bandit_arms are extracted
image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants