Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet prototype pollution attack #24415

Closed
darkdh opened this issue Aug 3, 2022 · 1 comment · Fixed by brave/brave-core#14460
Closed

Wallet prototype pollution attack #24415

darkdh opened this issue Aug 3, 2022 · 1 comment · Fixed by brave/brave-core#14460
Assignees
@darkdh
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Milestone
1.45.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Aug 3, 2022

placeholder for https://github.com/brave/security/issues/940
@darkdh darkdh self-assigned this Aug 3, 2022
@darkdh darkdh added this to Web3 Aug 3, 2022
@darkdh darkdh moved this to In Review in Web3 Aug 3, 2022
@darkdh darkdh added the QA/Yes label Aug 3, 2022
@darkdh darkdh mentioned this issue Aug 3, 2022
Merged
25 tasks
@darkdh darkdh added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified release-notes/include labels Aug 3, 2022
@darkdh darkdh mentioned this issue Aug 10, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Aug 25, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 25, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2022

Verification passed on

Brave 1.45.88 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS Linux
24415.mp4

Verification passed on

Brave 1.45.88 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS Windows 11 Version 21H2 (Build 22000.978)
24415.mp4

Verification passed on

Brave 1.45.88 Chromium: 106.0.5249.91 (Official Build) beta (arm64)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS macOS Version 12.4 (Build 21F79)
24415.mov

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Prototype pollution prevention for wallet scripts brave/brave-core
5 participants
@diracdeltas @darkdh @srirambv @LaurenWags @brave-builds