Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No image shown for in-line ads #24276

Closed
srirambv opened this issue Jul 26, 2022 · 3 comments · Fixed by brave/brave-core#14345
Closed

No image shown for in-line ads #24276

srirambv opened this issue Jul 26, 2022 · 3 comments · Fixed by brave/brave-core#14345

Comments

@srirambv
Copy link
Contributor

Description

No image shown for in-line ads

Steps to Reproduce

  1. Enable Brave News on nightly
  2. Scroll down to view inline ads
  3. Image is not shown

Actual result:

image

Expected result:

Show images for in-line ads

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.42 Chromium: 103.0.5060.134 (Official Build) nightly (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS Windows 11 Version 21H2 (Build 22000.795)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @iambrianfung @tmancey @jsecretan @brave/legacy_qa

@btlechowski
Copy link

This is a regression. Not reproducible on 1.42.78. Verified staging and production

image image

@kjozwiak
Copy link
Member

The above requires 1.43.52 or higher for 1.43.x verification 👍

@btlechowski
Copy link

Verification passed on

Brave 1.43.58 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image

Verified inline ad can be viewed and user is paid for it

[9553:9553:0804/192003.651001:VERBOSE3:inline_content_ad_event_viewed.cc(24)] Viewed inline content ad with placement id 79fa1891-ee65-4506-bee8-c0243fbbf97e and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[9553:9553:0804/192003.658024:VERBOSE6:inline_content_ad_event_viewed.cc(32)] Successfully logged inline content ad viewed event
[9553:9553:0804/192003.685066:VERBOSE3:account.cc(164)] Successfully processed deposit for inline_content_ad with creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae and view valued at 0.01
[9553:9553:0804/192003.685604:VERBOSE1:confirmations.cc(61)] Confirming view for inline_content_ad with transaction id 0f252a6f-2532-4388-af81-e88bc4844361 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[9553:9553:0804/192003.688494:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[9553:9553:0804/192003.702577:VERBOSE1:redeem_unblinded_token.cc(71)] CreateConfirmation
[9553:9553:0804/192003.713318:VERBOSE2:redeem_unblinded_token.cc(72)] POST /v2/confirmation/{confirmation_id}/{credential}
[9553:9553:0804/192003.713832:VERBOSE6:redeem_unblinded_token.cc(76)] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJjaHJIdUNTRm1qZXYyMmc2b1psYVZaek9xS1FSMWxCK2JpUDFSTkFoNjNnPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiMTMyMjYxMzcxNDRhMjBiMzNkZWY4ZjJhYmNmZTI4ZjEzZGQ0MjAwY1wifV0sXCJjcmVhdGVkQXRUaW1lc3RhbXBcIjpcIjIwMjItMDgtMDRUMTc6MDA6MDAuMDAwWlwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlNDk1OGQwMC1lMzVjLTQxMzQtYTQwOC0xZmJjZjI3NGQ1YWVcIixcIm9keXNzZXlcIjpcImhvc3RcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJtcC83OWU2WmFtZ3gzdzJOd1B6ZlY5V0puY0dZNDJweFIwRGpUL1JhZ0dJPVwiLFwicm90YXRpbmdfaGFzaFwiOlwiMjE2Njg1ODM0OVwiLFwic3R1ZGllc1wiOltdLFwic3lzdGVtVGltZXN0YW1wXCI6XCIyMDIyLTA4LTA0VDE3OjAwOjAwLjAwMFpcIixcInR5cGVcIjpcInZpZXdcIixcInZlcnNpb25OdW1iZXJcIjpcIjEwNC4wLjUxMTIuODFcIn0iLCJzaWduYXR1cmUiOiJYcmJaM3FkZ3A3aEkzYnlJYTlsWHA0d1VXL05RNVlGYVlSS0F2RUc3M3V0ZHhUSnU3cmRUTHV2bDZGQ3VNYUpPcmZMbmV3K3ZwcWpQQ0lSV0krZ3lhZz09IiwidCI6IkhRWDk1U29DQ1Fvc0FoNnh3STRVTm5TOEtqeElsdElXRVhHTmhIWERwZXpaTGU5QVFuR0xnZXVmb0NycUdLcTZYSDd6VndJbFhOVFhXTmo4YVZiQld3PT0ifQ==
  Content: {"blindedPaymentTokens":["chrHuCSFmjev22g6oZlaVZzOqKQR1lB+biP1RNAh63g="],"buildChannel":"beta","catalog":[{"id":"13226137144a20b33def8f2abcfe28f13dd4200c"}],"createdAtTimestamp":"2022-08-04T17:00:00.000Z","creativeInstanceId":"e4958d00-e35c-4134-a408-1fbcf274d5ae","odyssey":"host","payload":{},"platform":"linux","publicKey":"mp/79e6Zamgx3w2NwPzfV9WJncGY42pxR0DjT/RagGI=","rotating_hash":"2166858349","studies":[],"systemTimestamp":"2022-08-04T17:00:00.000Z","type":"view","versionNumber":"104.0.5112.81"}
  Content Type: application/json
  Method: kPost
[9553:9553:0804/192004.553764:VERBOSE1:redeem_unblinded_token.cc(87)] OnCreateConfirmation
[9553:9553:0804/192004.560207:VERBOSE6:redeem_unblinded_token.cc(89)] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJjaHJIdUNTRm1qZXYyMmc2b1psYVZaek9xS1FSMWxCK2JpUDFSTkFoNjNnPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiMTMyMjYxMzcxNDRhMjBiMzNkZWY4ZjJhYmNmZTI4ZjEzZGQ0MjAwY1wifV0sXCJjcmVhdGVkQXRUaW1lc3RhbXBcIjpcIjIwMjItMDgtMDRUMTc6MDA6MDAuMDAwWlwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlNDk1OGQwMC1lMzVjLTQxMzQtYTQwOC0xZmJjZjI3NGQ1YWVcIixcIm9keXNzZXlcIjpcImhvc3RcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJtcC83OWU2WmFtZ3gzdzJOd1B6ZlY5V0puY0dZNDJweFIwRGpUL1JhZ0dJPVwiLFwicm90YXRpbmdfaGFzaFwiOlwiMjE2Njg1ODM0OVwiLFwic3R1ZGllc1wiOltdLFwic3lzdGVtVGltZXN0YW1wXCI6XCIyMDIyLTA4LTA0VDE3OjAwOjAwLjAwMFpcIixcInR5cGVcIjpcInZpZXdcIixcInZlcnNpb25OdW1iZXJcIjpcIjEwNC4wLjUxMTIuODFcIn0iLCJzaWduYXR1cmUiOiJYcmJaM3FkZ3A3aEkzYnlJYTlsWHA0d1VXL05RNVlGYVlSS0F2RUc3M3V0ZHhUSnU3cmRUTHV2bDZGQ3VNYUpPcmZMbmV3K3ZwcWpQQ0lSV0krZ3lhZz09IiwidCI6IkhRWDk1U29DQ1Fvc0FoNnh3STRVTm5TOEtqeElsdElXRVhHTmhIWERwZXpaTGU5QVFuR0xnZXVmb0NycUdLcTZYSDd6VndJbFhOVFhXTmo4YVZiQld3PT0ifQ==
  Response Status Code: 201
  Response: {"id":"fd49f954-d328-4d22-b5e7-962ede50a30b","payload":{},"createdAt":"2022-08-04T17:20:04.519Z","type":"view","modifiedAt":"2022-08-04T17:20:04.519Z","creativeInstanceId":"e4958d00-e35c-4134-a408-1fbcf274d5ae"}
[9553:9553:0804/192004.569186:VERBOSE1:redeem_unblinded_token.cc(116)] FetchPaymentToken
[9553:9553:0804/192004.569429:VERBOSE2:redeem_unblinded_token.cc(117)] GET /v2/confirmation/{confirmation_id}/paymentToken
[9553:9553:0804/192004.569594:VERBOSE6:redeem_unblinded_token.cc(121)] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/paymentToken
  Method: kGet
[9553:9553:0804/192004.821400:VERBOSE1:redeem_unblinded_token.cc(132)] OnFetchPaymentToken
[9553:9553:0804/192004.822110:VERBOSE6:redeem_unblinded_token.cc(134)] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[9553:9553:0804/192004.825261:VERBOSE1:redeem_unblinded_token.cc(152)] Payment token is not ready
[9553:9553:0804/192004.825457:VERBOSE1:redeem_unblinded_token.cc(374)] Failed to redeem unblinded token for inline_content_ad with confirmation id fd49f954-d328-4d22-b5e7-962ede50a30b, transaction id 0f252a6f-2532-4388-af81-e88bc4844361, creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae and view
[9553:9553:0804/192004.828142:VERBOSE1:confirmations.cc(213)] Added view confirmation for inline_content_ad with id fd49f954-d328-4d22-b5e7-962ede50a30b, transaction id 0f252a6f-2532-4388-af81-e88bc4844361 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae to the confirmations queue
[9553:9553:0804/192004.838592:VERBOSE1:refill_unblinded_tokens.cc(92)] No need to refill unblinded tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[9553:9553:0804/192004.839201:VERBOSE1:confirmations.cc(100)] Retry sending failed confirmations in 0 hours, 0 minutes, 1 second at 19:20:05.831
[9553:9553:0804/192008.107017:VERBOSE1:confirmations.cc(108)] Retry sending failed confirmations
[9553:9553:0804/192008.107139:VERBOSE1:confirmations.cc(237)] Removed view confirmation for inline_content_ad with id fd49f954-d328-4d22-b5e7-962ede50a30b, transaction id 0f252a6f-2532-4388-af81-e88bc4844361 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae from the confirmations queue
[9553:9553:0804/192008.108304:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[9553:9553:0804/192008.111891:VERBOSE1:redeem_unblinded_token.cc(116)] FetchPaymentToken
[9553:9553:0804/192008.111997:VERBOSE2:redeem_unblinded_token.cc(117)] GET /v2/confirmation/{confirmation_id}/paymentToken
[9553:9553:0804/192008.112067:VERBOSE6:redeem_unblinded_token.cc(121)] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/paymentToken
  Method: kGet
[9553:9553:0804/192008.858799:VERBOSE1:redeem_unblinded_token.cc(132)] OnFetchPaymentToken
[9553:9553:0804/192008.860749:VERBOSE6:redeem_unblinded_token.cc(134)] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v2/confirmation/fd49f954-d328-4d22-b5e7-962ede50a30b/paymentToken
  Response Status Code: 200
  Response: {"id":"fd49f954-d328-4d22-b5e7-962ede50a30b","createdAt":"2022-08-04T17:20:04.519Z","type":"view","modifiedAt":"2022-08-04T17:20:07.668Z","creativeInstanceId":"e4958d00-e35c-4134-a408-1fbcf274d5ae","paymentToken":{"publicKey":"hPG3j7g7Vb6y635dinW8AVX5Izkh22hXfLXzPpnRRw8=","batchProof":"T53CswjrVtAEc7Xfj3Ifa+6yiAFHE6c2WyUHI1kAlgzFs9hSy1niIp+4ke8oijgSX4xr1rK8OgBb5bjaSj8pAw==","signedTokens":["jJsRxoRW2mLfMFwHg/JcUkQBRGK/M0zXFISWqFMEwSs="]}}
[9553:9553:0804/192008.873668:VERBOSE1:redeem_unblinded_token.cc(358)] Successfully redeemed unblinded token for inline_content_ad with confirmation id fd49f954-d328-4d22-b5e7-962ede50a30b, transaction id 0f252a6f-2532-4388-af81-e88bc4844361, creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae and view

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants