Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Brave Ads cmd-line arg flags #24201

Closed
tmancey opened this issue Jul 21, 2022 · 1 comment · Fixed by brave/brave-core#14343
Closed

Decouple Brave Ads cmd-line arg flags #24201

tmancey opened this issue Jul 21, 2022 · 1 comment · Fixed by brave/brave-core#14343

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 21, 2022

No description provided.

@tmancey tmancey self-assigned this Jul 21, 2022
@tmancey tmancey changed the title Decouple Brave Ads cmd-line args Decouple Brave Ads cmd-line arg flags Jul 27, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 29, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#14343

staging - --enable-features not blocked

Used command like:

--enable-logging=stderr --vmodule="*/riations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --rewards=staging=true --enable-features="UserActivity:threshold/0.0"

was able to view the ad, --enable-features was not blocked

[13780:13780:0927/163205.884988:VERBOSE1:eligible_notification_ads_v1.cc(39)] Get eligible notification ads:
[13780:13780:0927/163205.892964:VERBOSE1:eligible_notification_ads_v1.cc(168)] Get eligible ads for untargeted segment
[13780:13780:0927/163205.910085:VERBOSE2:priority.h(34)] 11 ads with a priority of 1 in bucket 1
[13780:13780:0927/163205.910380:VERBOSE1:eligible_notification_ads_v1.cc(191)] 11 eligible ads out of 11 ads for untargeted segment
[13780:13780:0927/163205.910602:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad
[13780:13780:0927/163205.911041:VERBOSE1:notification_ad_serving.cc(127)] Found 11 eligible ads
[13780:13780:0927/163205.911281:VERBOSE1:notification_ad_serving.cc(199)] Served notification ad:
  placementId: 4ec94c46-9581-442e-af2f-a0ed85b529b3
  creativeInstanceId: d55f52f6-f02b-4808-b6e2-b2a7734ad836
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2
  body: Ad2
  targetUrl: https://brave.com/

production - --enable-features blocked

command line used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --enable-features="UserActivity:threshold/0.0"

The ad is not blocked.

[14997:14997:0927/165420.554075:VERBOSE1:eligible_notification_ads_v1.cc(39)] Get eligible notification ads:
[14997:14997:0927/165420.580474:VERBOSE1:eligible_notification_ads_v1.cc(168)] Get eligible ads for untargeted segment
[14997:14997:0927/165420.614147:VERBOSE2:priority.h(34)] 1 ads with a priority of 5 in bucket 1
[14997:14997:0927/165420.614331:VERBOSE1:eligible_notification_ads_v1.cc(191)] 1 eligible ads out of 1 ads for untargeted segment
[14997:14997:0927/165420.614411:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad
[14997:14997:0927/165420.614710:VERBOSE1:notification_ad_serving.cc(127)] Found 1 eligible ads
[14997:14997:0927/165420.614825:VERBOSE1:notification_ad_serving.cc(199)] Served notification ad:
  placementId: eda49a07-04a4-48f5-9077-13cd85272fd4
  creativeInstanceId: c80153f6-cf22-41c0-8c2c-24c1f9a23c96
  creativeSetId: 58c1dcd9-24a4-4886-bf5d-4235c3074110
  campaignId: 5c00bdb5-a8b2-4290-b51d-96e5db2da195
  advertiserId: 602b6c48-d465-4530-a78f-4488ab88815d
  segment: untargeted
  title: Ledger Nano S
  body: The world’s most popular hardware wallet
  targetUrl: https://shop.ledger.com/products/ledger-nano-s-plus?r=0ba5d7199327
[14997:14997:0927/165420.622443:VERBOSE1:ads_service_impl.cc(954)] Timeout notification ad with placement id eda49a07-04a4-48f5-9077-13cd85272fd4 in 120 seconds
[14997:14997:0927/165420.622670:VERBOSE3:notification_ad_event_served.cc(23)] Served notification ad with placement id eda49a07-04a4-48f5-9077-13cd85272fd4 and creative instance id c80153f6-cf22-41c0-8c2c-24c1f9a23c96
[14997:14997:0927/165420.632051:VERBOSE3:notification_ad_event_viewed.cc(23)] Viewed notification ad with placement id eda49a07-04a4-48f5-9077-13cd85272fd4 and creative instance id c80153f6-cf22-41c0-8c2c-24c1f9a23c96

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants