-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[speedreader] Dark/Light theme support #23447
Labels
design
A design change, especially one which needs input from the design team
feature/speedreader
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
25 tasks
Verified
|
Brave | 1.44.75 Chromium: 105.0.5195.102 (Official Build) beta (x86_64) |
---|---|
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4} |
OS | macOS Version 11.6.8 (Build 20G730) |
Steps:
- installed
1.44.75
- launched Brave
- deleted the
jicbkmdloagakknpihibphagfckhjdih
component directory - loaded
https://www.bbc.com/news/business-58559179
- clicked on the
Speedreader
icon - opened
Developer Tools
->Console
panel - entered
document.documentElement.setAttribute('data-theme', 'dark')
and pressedreturn
- confirmed the
Light
theme changed toDark
and was applied in Speedreader mode to the article - entered
document.documentElement.setAttribute('data-theme', 'light')
and pressedreturn
- confirmed the
Dark
theme changed toLight
and was applied - entered
document.documentElement.setAttribute('data-theme', 'sepia')
and pressedreturn
- confirmed the
Light
theme changed toSepia
and was applied - entered
document.documentElement.removeAttribute('data-theme')
and pressedreturn
- confirmed the
Dark
mode returned
step 3 | step 4-5 | steps 7-8 | steps 9-10 | steps 11-12 | steps 13-14 |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verification
|
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/speedreader
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Speedreader should automatically show a light or dark distilled page, according to the browser settings.
We need to negotiate the exact theme colors with the design team
The text was updated successfully, but these errors were encountered: