Overriding Full Screen Keyboard Shortcut Does Not Work Anymore

[kolinkorr839]

Description

On versions greater than 1.35.104 on macOS (10.15.7), when I switch the full-screen keyboard shortcut (View > Enter Full Screen) to become the zoom keyboard shortcut (Windows > Zoom), Brave does not acknowledge it and still does the full-screen command instead of the zoom command. This used to work on version 1.35.104 and below.

Steps to Reproduce

1. Add Zoom shortcut to be control-command-f by adding it here: System Preferences > Keyboard > App Shortcuts > Shortcuts.

2. Check that the Brave browser for versions 1.35.104 and 1.36.119 has modified these shortcuts. Go to View and you will see that the Enter Full Screen does not have the control-command-f shortcut keys anymore. Go to Window and you will see the Zoom now has the control-command-f shortcut keys.

3. Open Brave browser version 1.35.104, hit control-command-f and it maximizes the screen and does not enter full screen. Basically, it was able to override the "Enter Full Screen" keyboard shortcut.

4. Open Brave browser version 1.36.109 or 1.36.119 (latest), hit control-command-f and it will enter the full screen. This means that it was not able to override the "Enter Full Screen" keyboard shortcut. If you look at Windows > Zoom, you will see the new control-command-f shortcut but Brave does not honor this.

Actual result:

On 1.36.119, this is the actual result. Notice that after hitting the control-command-f, it still went to the full screen mode.

Expected result:

On 1.35.104, this is the correct result.

Reproduces how often:

Easily reproduced and consistent output.

Brave version (brave://version info)

Brave	1.35.104 Chromium: 98.0.4758.109 (Official Build) (x86_64)
Revision	03268453da2c7409eb1ee934d97abfc6f3b45420-refs/branch-heads/4758@{#1179}
OS	macOS Version 10.15.7 (Build 19H15)
JavaScript	V8 9.8.177.11
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.109 Safari/537.36
Command Line	/Users/kolinkorr/Desktop/Brave Browser 2.app/Contents/MacOS/Brave Browser -psn_0_140309959 --disable-client-side-phishing-detection --disable-domain-reliability --enable-dom-distiller --no-pings --component-updater=url-source=https://go-updater.brave.com/extensions --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --allow-insecure-localhost --flag-switches-end
Executable Path	/Users/kolinkorr/Desktop/Brave Browser 2.app/Contents/MacOS/Brave Browser
Profile Path	/Users/kolinkorr/Library/Application Support/BraveSoftware/Brave-Browser/Default
Linker	lld

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes.
• Can you reproduce this issue with the beta channel? Don't know.
• Can you reproduce this issue with the nightly channel? Don't know.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No.
• Does the issue resolve itself when disabling Brave Rewards? No.
• Is the issue reproducible on the latest version of Chrome? Yes.

Miscellaneous Information:

N/A