Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-contribute attention is not being recorded as per the settings set for Minimum page time and Minimum visits in Brave://rewards #21244

Open
MadhaviSeelam opened this issue Feb 23, 2022 · 1 comment
Assignees
Labels
feature/rewards intermittent-issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@MadhaviSeelam
Copy link

Description

Auto-contribute attention is not being recorded on the brave://rewards page as per the settings set for Minimum page time and Minium visits in the AC settings panel.

Steps to Reproduce

Scenario 1: 5 seconds - 10 visits

1.Clean profile
2.Launch Brave
3.Skip welcome tour
4.Click Start using Rewards
5.Go to brave://rewards
6.Click Auto-Contribute settings
7.Select 5 seconds in the Minimum page time before logging a visit dropdown
8.Select 10 visit in the Minimum visits for publisher relevance dropdown
9. Visit github.com/laurenwags
10.Wait for 5 seconds (Do not click away on the page)
11.No Attention should be recorded
12.Close the tab.
13. Visit github.com/laurenwags in another tab
14.Repeat 12,13 steps 9 times
15.Go to brave://rewards page to verify Attention is recorded in the Auto-Contribute Site table

Actual result:

Attention recorded: None

Expected result:

Attention should be recoded in percentage along with the visited site name

Example

5seconds10visits-no auto-contribute recorded
Scenario 2: 1 minute - 5 visits

1.Clean profile
2.Launch Brave
3.Skip welcome tour
4.Click Start using Rewards
5.Go to brave://rewards
6.Click Auto-Contribute settings
7.Select 1 minute for Minimum page time before logging a visit
8.Select 5 visits for Minimum visits for publisher relevance
9.Visit abcnews.com
10.Wait for 1 minute (Do not click away on the page!)
11.No Attention should be recorded
12.Close the tab
13.Visit abcnews.com in a new tab
14.Repeat 12,13 steps 4 times
15.Go to brave://rewards page to verify Attention is recorded in the Auto-Contribute Site table

Actual result:

Attention recorded: None

Expected result:

Attention should be recoded in percentage along with the visited site name

Scenario 3: 1 minute - 10 visits

1.Clean profile
2.Launch Brave
3.Skip welcome tour
4.Click Start using Rewards
5.Go to brave://rewards
6.Click Auto-Contribute settings
7.Select 1 minute for Minimum page time before logging a visit
8.Select 10 visits for Minimum visits for publisher relevance
9.Visit brave.com
10.Wait for 1 minute (Do not click away on the page!)
11.No Attention should be recorded
12.Close the tab
13.Visit brave.com in a new tab
14.Repeat 12,13 steps 9 times
15.Go to brave://rewards page to verify Attention is recorded in the Auto-Contribute Site table

Actual result:

Attention recorded: None

Expected result:

Attention should be recoded in percentage along with the visited site name

Scenario 4: 8 seconds - 1 visit

1.Clean profile
2.Launch Brave
3.Skip welcome tour
4.Click Start using Rewards
5.Retain default settings for Auto-Contribute in brave://rewards (8 seconds - 1 visit)
6.Visit abcnews.com
7.Wait for 8 seconds (Do not click away on the page)
8.Go to brave://rewards page to verify Attention is recorded in the Auto-Contribute Site table

Actual result:

Attention recorded: None

Expected result:

Attention should be recoded in percentage along with the visited site name

Example

8seconds_1visit_no_ac_recorded

Reproduces how often:

Intermittent issue.

Brave version (brave://version info)

Brave | 1.35.103 Chromium: 98.0.4758.102 (Official Build) (64-bit)
Revision | 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS | Windows 11 Version 21H2 (Build 22000.493)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Yes
    • [Version 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)]

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@stephendonner stephendonner changed the title Auto-contribute attention is not being recorded as per the settings set for Minimum page time and Minium visits in Brave://rewards Auto-contribute attention is not being recorded as per the settings set for Minimum page time and Minimum visits in Brave://rewards Feb 23, 2022
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 23, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Apr 21, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards intermittent-issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants