Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedreader article date should be localized #19452

Open
rillian opened this issue Nov 15, 2021 · 0 comments
Open

Speedreader article date should be localized #19452

rillian opened this issue Nov 15, 2021 · 0 comments

Comments

@rillian
Copy link

rillian commented Nov 15, 2021

Description

When speedreader can extract a timestamp from an article, it adds it to the header in the reader-mode version, but it uses a hard-coded US-style format like 'Jan. 01, 2018 12:53 PM' It would be better to present the 'Updated ' text translated and formatted according the the user's locale.

Steps to Reproduce

  1. Enable Speedreader
  2. Visit a news article
  3. Compare date format to locale and time zone

Actual result:

Updated Sep. 05, 2019 17:36 pm

Expected result:

5 November 2019, 11:36
(or some other appropriate local format)

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant