Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss the Tipping banner on user cues that indicate that they're moving on #1743

Closed
jenn-rhim opened this issue Oct 19, 2018 · 4 comments
Closed
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@jenn-rhim
Copy link

Description

Dismiss the tipping banner when the user

  • clicks outside of the banner
  • types in the URL bar

to support the user's natural, fluid navigation/browsing experience, instead of requiring them to explicitly 'close' the banner.

screen shot 2018-10-19 at 12 12 38 pm

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@jenn-rhim jenn-rhim changed the title Dismiss the Tipping banner on user cues that indicates they're moving on Dismiss the Tipping banner on user cues that indicate that they're moving on Oct 19, 2018
@NejcZdovc NejcZdovc added this to the 0.56.x - Beta milestone Oct 22, 2018
@petemill
Copy link
Member

I'd like to suggest that we move this one to 0.57.x as that's where we're going to land a new type of dialog that will support this. Since we want the dialog to be window-modal instead of tab-modal like it is currently, it doesn't seem like we should invest time in dismissing the current dialog, when it will be replaced cc @mandar-brave @rebron.

@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 19, 2018
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 22, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@agentofuser
Copy link

If #4590 is not going to be fixed, I think this issue should be made higher priority. It's pretty annoying for the banner not to go away on its own.

Also, it should be possible to dismiss it mouselessly with Esc and/or Enter.

@LaurenWags
Copy link
Member

++ on re-prioritizing this one based on discussions in #4590

@Miyayes Miyayes added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 8, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Jun 28, 2022

Closing in favor of #23740.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

9 participants