-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismiss the Tipping banner on user cues that indicate that they're moving on #1743
Comments
I'd like to suggest that we move this one to 0.57.x as that's where we're going to land a new type of dialog that will support this. Since we want the dialog to be window-modal instead of tab-modal like it is currently, it doesn't seem like we should invest time in dismissing the current dialog, when it will be replaced cc @mandar-brave @rebron. |
If #4590 is not going to be fixed, I think this issue should be made higher priority. It's pretty annoying for the banner not to go away on its own. Also, it should be possible to dismiss it mouselessly with Esc and/or Enter. |
++ on re-prioritizing this one based on discussions in #4590 |
Closing in favor of #23740. |
Description
Dismiss the tipping banner when the user
to support the user's natural, fluid navigation/browsing experience, instead of requiring them to explicitly 'close' the banner.
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: